From nobody Wed Oct 18 18:03:41 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4S9dy55KRRz4xKhF; Wed, 18 Oct 2023 18:03:41 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4S9dy54Jcqz4X9Z; Wed, 18 Oct 2023 18:03:41 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1697652221; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Z1V6Jx9+9LDWAlwx/qsSy4X6v0sqNujcc2lZr2m54ls=; b=kIjs/fwPpg8vQ1+Hd9GhP0GqhlHXYg7EqJ/LJ3nEPOAa7/51lw6NSV/YD+FcaMU9vx8iCY emakbQbZqmx2RemO54FHWYEVJr1VSg9A3u+lc7drjdNlbQgViqEQfLgRjz+/5CT2Kset+U gj2zzh3oUUV6QQe5mb3elhx2g6hVreiKU1KgsDXoWIleDSjzGSCHpMM7ow1Q2IXKfh9vXH JUvZxwmk/yOS9gRxGF7z71bxXkey7D2p5Ui4iAYBCp2YFU5mMhvmdzTaJwz6Oi89yYJ7YF hy1Tlac8vCZo30XTPmTsPVuo7PMh6IjAOwbg9Y9/Dsh8/hCkXMJt9NKJvoMOug== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1697652221; a=rsa-sha256; cv=none; b=GZa4ZpzQ4rqcYIUxB0yCAuYoSP7DrpUjzfEO7nvhBjPDAzbMb5voKGfBGIqDRctUvjZ3Av KDNddg6bIk9Vo3e1SJb15a4grrc1lTwJfiMfwCmBnGcc1zYeA7Xkw1IR4jypNHvcd/YOEe 9zb/qno5CJVGExwqVBFoJMM8HRXWWAoZ/8VcWdpp41jk7N4/2MrlpkFR9WIB8D1Oo4KJdm mqoh1O1v9K2/iMf9HcmM09DkktsmSWtTyshuIc5lLq7TZNNTnRKiTif0CnEuoy7iYnEMJV djUWdiGQw53kMBZJqrTSKycJfQyF9zV2nsJvrlAZWVRgd7HhIP0xDlFKem97Fw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1697652221; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Z1V6Jx9+9LDWAlwx/qsSy4X6v0sqNujcc2lZr2m54ls=; b=DgF99RNbbXtWvLXiYH/mLr8e4yzkx+HMjlB9mgTmR10okF5nIayLSVWpgtEdZMUfkD29Bm qivLBeK1qwEZAuJojN6JJ4TRLhfrhia4VRcL/3H5wNvyUHykz5x3FNDNBuS1FBiefo6pnP vDxL9ZaHitYJcDlGlPnXC3xukELGROWcrG3raUJsWiVUHFyM5FNM12RraPeLRu34d8WDat D3rQCMnYimaLOc0rDv8oDaxXyr2nwEFk+ec9ROexs12cHGxEmyzBuZPdOVllnt8SlrN8jv KCWLgP00OrPVGofr+yvcZPRIDUYsRkQhfqh+UhnJMBh/u9E9/G7e5uxyS/kR/g== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4S9dy52qp5z2RB; Wed, 18 Oct 2023 18:03:41 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 39II3fls044365; Wed, 18 Oct 2023 18:03:41 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 39II3fl0044362; Wed, 18 Oct 2023 18:03:41 GMT (envelope-from git) Date: Wed, 18 Oct 2023 18:03:41 GMT Message-Id: <202310181803.39II3fl0044362@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mitchell Horne Subject: git: 768fe2300987 - releng/14.0 - New cr_bsd_visible(): Whether BSD policies deny seeing subjects/objects List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mhorne X-Git-Repository: src X-Git-Refname: refs/heads/releng/14.0 X-Git-Reftype: branch X-Git-Commit: 768fe23009877b42a9f45b0ca9e9c05f9db76649 Auto-Submitted: auto-generated The branch releng/14.0 has been updated by mhorne: URL: https://cgit.FreeBSD.org/src/commit/?id=768fe23009877b42a9f45b0ca9e9c05f9db76649 commit 768fe23009877b42a9f45b0ca9e9c05f9db76649 Author: Olivier Certner AuthorDate: 2023-08-17 23:54:38 +0000 Commit: Mitchell Horne CommitDate: 2023-10-18 17:59:34 +0000 New cr_bsd_visible(): Whether BSD policies deny seeing subjects/objects This is a new helper function that leverages existing code: It calls successively cr_canseeotheruids(), cr_canseeothergids() and cr_canseejailproc() (as long as the previous didn't deny access). Will be used in a subsequent commit. Approved by: re (gjb) Reviewed by: mhorne Sponsored by: Kumacom SAS Differential Revision: https://reviews.freebsd.org/D40627 (cherry picked from commit e4a7b4f99cfd4931468c0866da4ae8b49cf5badb) (cherry picked from commit 4a78431a52e9e65c6181a943bca2430633350db1) --- sys/kern/kern_prot.c | 19 +++++++++++++++++++ sys/sys/proc.h | 1 + 2 files changed, 20 insertions(+) diff --git a/sys/kern/kern_prot.c b/sys/kern/kern_prot.c index ed15cb566499..1e6073b554e4 100644 --- a/sys/kern/kern_prot.c +++ b/sys/kern/kern_prot.c @@ -1434,6 +1434,25 @@ cr_canseejailproc(struct ucred *u1, struct ucred *u2) return (ESRCH); } +/* + * Helper for cr_cansee*() functions to abide by system-wide security.bsd.see_* + * policies. Determines if u1 "can see" u2 according to these policies. + * Returns: 0 for permitted, ESRCH otherwise + */ +int +cr_bsd_visible(struct ucred *u1, struct ucred *u2) +{ + int error; + + if ((error = cr_canseeotheruids(u1, u2))) + return (error); + if ((error = cr_canseeothergids(u1, u2))) + return (error); + if ((error = cr_canseejailproc(u1, u2))) + return (error); + return (0); +} + /*- * Determine if u1 "can see" the subject specified by u2. * Returns: 0 for permitted, an errno value otherwise diff --git a/sys/sys/proc.h b/sys/sys/proc.h index 3102cae7add0..8609bbd124ad 100644 --- a/sys/sys/proc.h +++ b/sys/sys/proc.h @@ -1163,6 +1163,7 @@ void ast_sched(struct thread *td, int tda); void ast_unsched_locked(struct thread *td, int tda); struct thread *choosethread(void); +int cr_bsd_visible(struct ucred *u1, struct ucred *u2); int cr_cansee(struct ucred *u1, struct ucred *u2); int cr_canseesocket(struct ucred *cred, struct socket *so); int cr_canseeothergids(struct ucred *u1, struct ucred *u2);