From owner-cvs-all@FreeBSD.ORG Thu Oct 16 03:44:25 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9F48B16A4B3; Thu, 16 Oct 2003 03:44:25 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1ECCB43FB1; Thu, 16 Oct 2003 03:44:25 -0700 (PDT) (envelope-from bde@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.9/8.12.9) with ESMTP id h9GAiOXJ073057; Thu, 16 Oct 2003 03:44:24 -0700 (PDT) (envelope-from bde@repoman.freebsd.org) Received: (from bde@localhost) by repoman.freebsd.org (8.12.9/8.12.9/Submit) id h9GAiOpF073056; Thu, 16 Oct 2003 03:44:24 -0700 (PDT) (envelope-from bde) Message-Id: <200310161044.h9GAiOpF073056@repoman.freebsd.org> From: Bruce Evans Date: Thu, 16 Oct 2003 03:44:24 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/i386/isa apic_vector.s X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Oct 2003 10:44:25 -0000 bde 2003/10/16 03:44:24 PDT FreeBSD src repository Modified files: sys/i386/isa apic_vector.s Log: Don't forget to load %es with the kernel data segment selector in Xcpustop(). %es is used in at least the call to savectx() when savectx() calls bcopy(), so not loading it was fatal if a stop IPI interrupts user mode. This reduces bugs starting and stopping CPUs for debuggers. CPUs are stopped mainly in kdb_trap() and cpu_reset(). At reset time there is a good chance that all the CPUs are in the kernel, so the bug was probably harmless then. Revision Changes Path 1.90 +3 -0 src/sys/i386/isa/apic_vector.s