From nobody Wed Feb 15 16:48:42 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PH3tt4sFqz3qXxb for ; Wed, 15 Feb 2023 16:48:54 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PH3tt4R8Tz3rDD for ; Wed, 15 Feb 2023 16:48:54 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-x52f.google.com with SMTP id d40so21948776eda.8 for ; Wed, 15 Feb 2023 08:48:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=f9HHNSj0BJ9JJz02WdH58PNIqR0yq8mvHeKrTOnr3UM=; b=l/BS+zbuxy8h7kw10/QUitLsuuhQPjo7db2BtzdEmIouaC6pOSqM5BMeDONgYrb0Gy VOuY1qOBe64Gh8Wej6r2b4M41WegTTZBMrJKe83PvtJfhekwdiD+mXd7TS9e7XJKbyYb 7aOQuDaWDinRDNxOfARImdfWtoErE6Xz0iolYbBOUUAlvLQib+RkU8z6tIftJDLdOOW1 ooAmxs47cNLfnA+ad+4VGok8fsug9oUP7e4Qxhk47lXbQmmhZG3hANA7Eq0l09b0ScLt BojbwgQNQZ3RTk+DZgr4er7+LH/2Vf409pFXR3x8oezMpx4Lbsmvn1ltclZd6era1B5J JMDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=f9HHNSj0BJ9JJz02WdH58PNIqR0yq8mvHeKrTOnr3UM=; b=yrkgx6uBxI3r546LJYHImROjryLFMlBJSHN879rOibFUGGcN9ax4OBFDN1UbXxBu5c 7/DQkpBxGfY1RE7LAdD3ZPAAHgdmzwdZj2lSWxmms/lwoXXvu2DgBRxQesIQPVu6jElj efHMCxg7lj00VxmmqABmO+xtQdMY2gD1A+ko/XbmuJ8jMWMgIMPziF0l7i/31SNw/WG5 04HJfyGNqAya78woiHjBcE2yd44T2MqPAiqKZUDrS9DBAiQ4gb9iGE6HW4Ni+YuPVbAI Q37KBknyuIyFZgWAsgpilarDaLau6o4x+uTWmQyGsFX8P/Oe7Yk8YrMNSVYFlP/5PIHV xuDg== X-Gm-Message-State: AO0yUKWoH4cJ+HIDEbEFh0XJ5yQ5zgoM5Mr0shjlT0j6GKNOsuMznHoS r+afP4Pgmllvk05egpJImTGhk8gxQktlxttWh+JY5w== X-Google-Smtp-Source: AK7set/wwQhLk4T1b+YQO9iy1D1+t1fW+CrZvk3uMGjcWmAFCh+J9r+z0lsgsFzjygKRQbhDOqAv+4kFMIhTjoLH/kY= X-Received: by 2002:a17:906:a409:b0:8b1:2d36:a58e with SMTP id l9-20020a170906a40900b008b12d36a58emr1435934ejz.2.1676479733296; Wed, 15 Feb 2023 08:48:53 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202205241917.24OJHipu099732@gitrepo.freebsd.org> <20230215103139.c66c65a80b9be787deaa36a2@bidouilliste.com> In-Reply-To: From: Warner Losh Date: Wed, 15 Feb 2023 09:48:42 -0700 Message-ID: Subject: Re: git: 7919c76dbdd2 - main - bsdinstall: use gpt/efiboot0 label in /etc/fstab To: Alan Somers Cc: Emmanuel Vadot , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000fa048e05f4bfda11" X-Rspamd-Queue-Id: 4PH3tt4R8Tz3rDD X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N --000000000000fa048e05f4bfda11 Content-Type: text/plain; charset="UTF-8" On Wed, Feb 15, 2023 at 9:35 AM Alan Somers wrote: > On Wed, Feb 15, 2023 at 2:31 AM Emmanuel Vadot > wrote: > > > > > > Hello Alan, > > > > On Tue, 24 May 2022 19:17:44 GMT > > Alan Somers wrote: > > > > > The branch main has been updated by asomers: > > > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=7919c76dbdd20161247d1bfb647110d87ca5ee0f > > > > > > commit 7919c76dbdd20161247d1bfb647110d87ca5ee0f > > > Author: Alan Somers > > > AuthorDate: 2022-05-24 18:24:12 +0000 > > > Commit: Alan Somers > > > CommitDate: 2022-05-24 19:17:10 +0000 > > > > > > bsdinstall: use gpt/efiboot0 label in /etc/fstab > > > > > > Otherwise, boot will hang if the numbering of disks has changed > since > > > initial install. > > > > > > MFC after: 2 weeks > > > Sponsored by: Axcient > > > Reviewed by: brd > > > Differential Revision: https://reviews.freebsd.org/D35309 > > > > So, I understand the initial problem but this causes a new one. > > efibootmgr is now confused when you ask to print the unix path of the > > ESP because the device resolved is still ada0p1 (for example) and since > > it's not mounted anymore as the label is used we can't discover the > > path to the mounted ESP. > > Since it's now in 13.2 we've just noticed that at work. > > We will parse glabel but it's really horrible to parse and it be good > > to have efibootmgr -E -p working again on a fresh install. > > > > Cheers, > > > > -- > > Emmanuel Vadot > > Annoying. Could you please open a bugzilla PR so we don't lose track of > this? > Yea, when I wrote the code I kinda gave up after needing to walk backwards in the geom mesh for places there were no back pointers. I've left more details on the bug that corvind@ filled. Likely a little brute force is all that's needed to find what we need... Warner --000000000000fa048e05f4bfda11 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Wed, Feb 15, 2023 at 9:35 AM Alan = Somers <asomers@freebsd.org&g= t; wrote:
On Wed= , Feb 15, 2023 at 2:31 AM Emmanuel Vadot <manu@bidouilliste.com> wrote:
>
>
>=C2=A0 Hello Alan,
>
> On Tue, 24 May 2022 19:17:44 GMT
> Alan Somers <asomers@FreeBSD.org> wrote:
>
> > The branch main has been updated by asomers:
> >
> > URL: htt= ps://cgit.FreeBSD.org/src/commit/?id=3D7919c76dbdd20161247d1bfb647110d87ca5= ee0f
> >
> > commit 7919c76dbdd20161247d1bfb647110d87ca5ee0f
> > Author:=C2=A0 =C2=A0 =C2=A0Alan Somers <asomers@FreeBSD.org>= ;
> > AuthorDate: 2022-05-24 18:24:12 +0000
> > Commit:=C2=A0 =C2=A0 =C2=A0Alan Somers <asomers@FreeBSD.org>= ;
> > CommitDate: 2022-05-24 19:17:10 +0000
> >
> >=C2=A0 =C2=A0 =C2=A0bsdinstall: use gpt/efiboot0 label in /etc/fst= ab
> >
> >=C2=A0 =C2=A0 =C2=A0Otherwise, boot will hang if the numbering of = disks has changed since
> >=C2=A0 =C2=A0 =C2=A0initial install.
> >
> >=C2=A0 =C2=A0 =C2=A0MFC after:=C2=A0 =C2=A0 =C2=A0 2 weeks
> >=C2=A0 =C2=A0 =C2=A0Sponsored by:=C2=A0 =C2=A0Axcient
> >=C2=A0 =C2=A0 =C2=A0Reviewed by:=C2=A0 =C2=A0 brd
> >=C2=A0 =C2=A0 =C2=A0Differential Revision: https://review= s.freebsd.org/D35309
>
>=C2=A0 So, I understand the initial problem but this causes a new one.<= br> >=C2=A0 efibootmgr is now confused when you ask to print the unix path o= f the
> ESP because the device resolved is still ada0p1 (for example) and sinc= e
> it's not mounted anymore as the label is used we can't discove= r the
> path to the mounted ESP.
>=C2=A0 Since it's now in 13.2 we've just noticed that at work.<= br> >=C2=A0 We will parse glabel but it's really horrible to parse and i= t be good
> to have efibootmgr -E -p working again on a fresh install.
>
>=C2=A0 Cheers,
>
> --
> Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>

Annoying.=C2=A0 Could you please open a bugzilla PR so we don't lose tr= ack of this?

Yea, when I wrote the code= I kinda gave up after needing to walk backwards in
the geom mesh= for places there were no back pointers. I've left more details on the<= /div>
bug that corvind@ filled. Likely a little brute force is all that= 's needed to find what
we need...

Wa= rner
--000000000000fa048e05f4bfda11--