From owner-svn-src-all@freebsd.org Sat Nov 21 00:08:29 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A5DDFA2E15B for ; Sat, 21 Nov 2015 00:08:29 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: from mail-lf0-f51.google.com (mail-lf0-f51.google.com [209.85.215.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3061F12B6 for ; Sat, 21 Nov 2015 00:08:28 +0000 (UTC) (envelope-from mailing-machine@vniz.net) Received: by lfs39 with SMTP id 39so78830377lfs.3 for ; Fri, 20 Nov 2015 16:08:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=p37Ywhjwef/J6PPIkWOmpp4r78SEBPIiUbUvmSSir4A=; b=VphgQPpGMEfFUqNsN3KDAvR6OV9AXuQsJ14ZZL/UKaOfjK2ZC4wUD5TSu2hs4JX1SU tMm4zk6UFr/2U6lx9A6SSsUWITiXeWWURkr/NGaxfBudXUD3E6xmSfsmmNaHa/eoEmSk 6aezLKrofHW+EzH48XiEQS1hkjRwp+NGo+F3MQi0OBVDxmhFibEZY2byTh+/IIB+0hP6 MY0fWqhEoTOnNjqpWd2ANhF0Pk6A5+3vAJFHsWMvPOfZOdQDHQagfLQCdZBeHu/oD0nk ys1ZLBbMZ4fwmo/cyKWUQ+VmqGMejS/Qgu7uAWsqHfmAof0mkd0CwukXZLXVIOQx5Hlu Tl7Q== X-Gm-Message-State: ALoCoQkBBtup7lqr9qWP1Hs/XIA7Ho+BR8+QQbMHatn2FGJUrb0aGZisq/ONjJMUvOIUzXkzXjSi X-Received: by 10.25.19.168 with SMTP id 40mr7101859lft.68.1448064500638; Fri, 20 Nov 2015 16:08:20 -0800 (PST) Received: from [192.168.1.2] ([89.169.173.68]) by smtp.gmail.com with ESMTPSA id g5sm225550lbd.26.2015.11.20.16.08.19 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 20 Nov 2015 16:08:19 -0800 (PST) Subject: Re: svn commit: r291114 - head/lib/libc/gen To: Ravi Pokala , Ravi Pokala , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201511202236.tAKMaf06048447@repo.freebsd.org> <564FAAB0.6000600@freebsd.org> <28C3C55F-BF25-4DB2-AF05-B57F3F2CCAD5@panasas.com> Cc: "Sanderson, David" From: Andrey Chernov Message-ID: <564FB5F3.1080301@freebsd.org> Date: Sat, 21 Nov 2015 03:08:19 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <28C3C55F-BF25-4DB2-AF05-B57F3F2CCAD5@panasas.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Nov 2015 00:08:29 -0000 On 21.11.2015 2:57, Ravi Pokala wrote: > There's two different things at play - userland resources and kernel resources. Both "FILE *iop" and "struct pid *cur" are userland, while the descriptors in "pdes" are kernel. We clean up the descriptors in "pdes" in call cases, so we're not leaking kernel resources. You're right that "iop" (and "cur", which you didn't mention) appear to be leaked in the child, in that they're not explicitly cleaned up. But they get wiped away by the _execve(), so it doesn't matter. See my next reply. I care not about userland resources, but about fdopen() ability to set FD_CLOEXEC. -- http://ache.vniz.net/