From owner-cvs-all@FreeBSD.ORG Fri Dec 14 01:02:36 2007 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 827DA16A418; Fri, 14 Dec 2007 01:02:36 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.freebsd.org (Postfix) with ESMTP id 549DD13C448; Fri, 14 Dec 2007 01:02:36 +0000 (UTC) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id BEF5D46BBC; Thu, 13 Dec 2007 20:02:35 -0500 (EST) Date: Fri, 14 Dec 2007 01:02:35 +0000 (GMT) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Scott Long In-Reply-To: <4761CDBA.9010906@samsco.org> Message-ID: <20071214005643.R86532@fledge.watson.org> References: <200712122021.lBCKLdvt045540@repoman.freebsd.org> <20071213223319.E81630@maildrop.int.zabbadoz.net> <4761BB7C.3010907@elischer.org> <4761CB3F.3030905@delphij.net> <4761CDBA.9010906@samsco.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: src-committers@FreeBSD.org, d@delphij.net, Kip Macy , Kip Macy , cvs-all@FreeBSD.org, Julian Elischer , cvs-src@FreeBSD.org, "Bjoern A. Zeeb" Subject: Re: cvs commit: src/sys/conf files src/sys/netinet tcp_ofld.c tcp_ofld.h tcp_var.h toedev.h src/sys/sys socket.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Dec 2007 01:02:36 -0000 On Thu, 13 Dec 2007, Scott Long wrote: > This is a completely awesome demonstration of the proverbial bikeshed. I > only wish that, someday, an important subsystem that I spend months/years > working on will be judged by the names and prefixes that I used in it. I > can barely wait. An alternative viewpoint would be that, after a year of fairly catastrophic TCP bugs resulting from a lack of adequate review and testing of TCP changes, a lot of people are keeping a close eye on the TCP stack. Let's not discourage that just yet. I'd like to see all significant changes to TCP discussed on public mailing lists well before they are committed -- at that point, someone saying "actually, I'd name the files a bit differently" is a lot easier to deal with than, say, immediately after they are committed. This needs to be communally owned and maintained code, or in two years time we'll find ourselves in the same position: architectural well-meant changes that are mostly right, but with no review of the details leading to the inevitable failures. Robert N M Watson Computer Laboratory University of Cambridge