From owner-cvs-src-old@FreeBSD.ORG  Fri Aug 14 10:10:07 2009
Return-Path: <owner-cvs-src-old@FreeBSD.ORG>
Delivered-To: cvs-src-old@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A92B0106568D
	for <cvs-src-old@freebsd.org>; Fri, 14 Aug 2009 10:10:07 +0000 (UTC)
	(envelope-from julian@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 936818FC43
	for <cvs-src-old@freebsd.org>; Fri, 14 Aug 2009 10:10:07 +0000 (UTC)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id n7EAA1O2051864
	for <cvs-src-old@freebsd.org>; Fri, 14 Aug 2009 10:10:01 GMT
	(envelope-from julian@repoman.freebsd.org)
Received: (from svn2cvs@localhost)
	by repoman.freebsd.org (8.14.3/8.14.3/Submit) id n7EAA16m051863
	for cvs-src-old@freebsd.org; Fri, 14 Aug 2009 10:10:01 GMT
	(envelope-from julian@repoman.freebsd.org)
Message-Id: <200908141010.n7EAA16m051863@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to
	julian@repoman.freebsd.org using -f
From: Julian Elischer <julian@FreeBSD.org>
Date: Fri, 14 Aug 2009 10:09:45 +0000 (UTC)
To: cvs-src-old@freebsd.org
X-FreeBSD-CVS-Branch: HEAD
Subject: cvs commit: src/sys/netinet/ipfw ip_fw2.c
X-BeenThere: cvs-src-old@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: **OBSOLETE** CVS commit messages for the src tree
	<cvs-src-old.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src-old>,
	<mailto:cvs-src-old-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src-old>
List-Post: <mailto:cvs-src-old@freebsd.org>
List-Help: <mailto:cvs-src-old-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src-old>,
	<mailto:cvs-src-old-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Aug 2009 10:10:07 -0000

julian      2009-08-14 10:09:45 UTC

  FreeBSD src repository

  Modified files:
    sys/netinet/ipfw     ip_fw2.c 
  Log:
  SVN rev 196201 on 2009-08-14 10:09:45Z by julian
  
  Fix ipfw crash on uid or gid check.
  Receiving any ip packet for which there is no existing socket will
  crash if ipfw has a uid or gid test rule, as the uid/gid
  of the non existent owner of said non existent socket is tested.
  Brooks introduced this error as part of his >16 gids patch.
  It appears to be a cut-n-paste error from similar code a few lines
  before. The old code used the 'pcb' variable here, but in the
  new code that switched the 'inp' variable, which is often NULL
  and what is tested in the code further up. The rest of the multi-gid
  patch for ipfw seems solid (and cleaner than previous code).
  
  Reviewed by:    brooks
  Approved by:    re (rwatson)
  
  Revision  Changes    Path
  1.12      +1 -1      src/sys/netinet/ipfw/ip_fw2.c