From owner-cvs-src@FreeBSD.ORG Sun Feb 4 06:17:49 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 3726716A402; Sun, 4 Feb 2007 06:17:49 +0000 (UTC) (envelope-from ariff@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 280F313C441; Sun, 4 Feb 2007 06:17:49 +0000 (UTC) (envelope-from ariff@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id l146HnRL003402; Sun, 4 Feb 2007 06:17:49 GMT (envelope-from ariff@repoman.freebsd.org) Received: (from ariff@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id l146HnZM003401; Sun, 4 Feb 2007 06:17:49 GMT (envelope-from ariff) Message-Id: <200702040617.l146HnZM003401@repoman.freebsd.org> From: Ariff Abdullah Date: Sun, 4 Feb 2007 06:17:49 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/dev/sound/pcm buffer.c buffer.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 Feb 2007 06:17:49 -0000 ariff 2007-02-04 06:17:49 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/sound/pcm buffer.c buffer.h Log: Partial MFC (buffer.h 1.14, buffer.c 1.30) Fix huge memory leak within sound buffer (during channel destruction, buffer resizing, etc.) that was here since eon. Free all (unmanaged) allocated buffer through sndbuf_destroy() in case we forgot to call sndbuf_free(). For a managed buffer (mostly hw specific managed buffer), either provide CHANNEL_FREE() method with appropriate return value to invoke semi-automatic sndbuf_free() or simply do it on their own. If everything is failed, sndbuf_destroy() will come to the rescue as a final measure. Revision Changes Path 1.25.2.2 +10 -0 src/sys/dev/sound/pcm/buffer.c 1.10.2.1 +1 -0 src/sys/dev/sound/pcm/buffer.h