Date: Fri, 8 Aug 2008 22:22:17 +0200 (CEST) From: Fabian Ruch <fabianruch@bsdgroup.de> To: FreeBSD-gnats-submit@FreeBSD.org Cc: ports@FreeBSD.org Subject: ports/126381: [PATCH] audio/jack-rack: Optional GNOME and WITHOUT_NLS support added Message-ID: <200808082022.m78KMHMa082217@beastie.local> Resent-Message-ID: <200808082040.m78Ke3LX000218@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 126381
>Category: ports
>Synopsis: [PATCH] audio/jack-rack: Optional GNOME and WITHOUT_NLS support added
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Fri Aug 08 20:40:03 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator: Fabian Ruch
>Release: FreeBSD 7.0-RELEASE-p2 i386
>Organization:
>Environment:
System: FreeBSD beastie.local 7.0-RELEASE-p2 FreeBSD 7.0-RELEASE-p2 #0: Wed Jun 18 07:33:20 UTC 2008
>Description:
- PORTREVISION increased (dependencies and options modified)
- BUILD_DEPENDS now holds all ports providing headers directly included by source files
- shared libraries the port depends on got versions to be checked
- post-patch script path adjustment replaced by configure argument --disable-desktop-inst
- optional GNOME and WITHOUT_NLS support added on the basis of the porters handbook
- in conjunction with the latter pkg-plist contains substitutes
Hopefully not too much mistakes in language, report and changes...
Generated with FreeBSD Port Tools 0.77
>How-To-Repeat:
>Fix:
--- jack-rack-1.4.5_3.patch begins here ---
diff -ruN --exclude=CVS /usr/home/fabian/ports/audio/jack-rack.orig/Makefile /usr/home/fabian/ports/audio/jack-rack/Makefile
--- /usr/home/fabian/ports/audio/jack-rack.orig/Makefile 2008-08-06 18:02:49.000000000 +0200
+++ /usr/home/fabian/ports/audio/jack-rack/Makefile 2008-08-08 21:37:44.000000000 +0200
@@ -7,27 +7,44 @@
PORTNAME= jack-rack
PORTVERSION= 1.4.5
-PORTREVISION= 2
+PORTREVISION= 3
CATEGORIES= audio
MASTER_SITES= SF/jack-rack
MAINTAINER= ports@FreeBSD.org
COMMENT= A LADSPA effects rack for the JACK audio server
-BUILD_DEPENDS= ${LOCALBASE}/include/ladspa.h:${PORTSDIR}/audio/ladspa
-LIB_DEPENDS= jack:${PORTSDIR}/audio/jack \
- lrdf:${PORTSDIR}/textproc/liblrdf
-RUN_DEPENDS= ${LOCALBASE}/include/ladspa.h:${PORTSDIR}/audio/ladspa
+BUILD_DEPENDS= ${LOCALBASE}/include/ladspa.h:${PORTSDIR}/audio/ladspa \
+ ${LOCALBASE}/include/jack/jack.h:${PORTSDIR}/audio/jack \
+ ${LOCALBASE}/include/lrdf.h:${PORTSDIR}/textproc/liblrdf
+LIB_DEPENDS= jack.0:${PORTSDIR}/audio/jack \
+ lrdf.2:${PORTSDIR}/textproc/liblrdf
USE_BZIP2= yes
-USE_GNOME= libgnomeui libxml2
+USE_GNOME= gtk20 libxml2
+WANT_GNOME= yes
GNU_CONFIGURE= yes
CONFIGURE_ENV= CPPFLAGS="-I${LOCALBASE}/include" \
LDFLAGS="-L${LOCALBASE}/lib"
-CONFIGURE_ARGS= --disable-ladcca --disable-lash
+CONFIGURE_ARGS=--disable-ladcca --disable-lash --disable-desktop-inst
-post-patch:
- @${REINPLACE_CMD} -e '/^jr_desktop_install/ s|/usr/share|${PREFIX}/share|' \
- ${WRKSRC}/configure
+.if !defined(WITHOUT_NLS)
+USE_GETTEXT= yes
+PLIST_SUB= NLS=""
+.else
+CONFIGURE_ARGS+=--disable-nls
+PLIST_SUB= NLS="@comment "
+.endif
+
+.include <bsd.port.pre.mk>
+
+.if ${HAVE_GNOME:Mlibgnomeui}!=""
+USE_GNOME+= gnomeprefix gnomehack libgnomeui
+PKGNAMESUFFIX= -gnome
+PLIST_SUB+= DATADIR="share/gnome"
+.else
+CONFIGURE_ARGS+=--disable-gnome
+PLIST_SUB+= DATADIR="share"
+.endif
-.include <bsd.port.mk>
+.include <bsd.port.post.mk>
diff -ruN --exclude=CVS /usr/home/fabian/ports/audio/jack-rack.orig/pkg-plist /usr/home/fabian/ports/audio/jack-rack/pkg-plist
--- /usr/home/fabian/ports/audio/jack-rack.orig/pkg-plist 2008-08-06 18:02:49.000000000 +0200
+++ /usr/home/fabian/ports/audio/jack-rack/pkg-plist 2008-08-06 18:02:49.000000000 +0200
@@ -1,16 +1,16 @@
bin/jack-rack
-share/applications/jack-rack.desktop
-share/dtds/jack_rack_1.0.dtd
-share/dtds/jack_rack_1.1.dtd
-share/dtds/jack_rack_1.2.dtd
-share/jack-rack/gnome-mixer-small.png
-share/jack-rack/jack-rack-logo.png
-share/jack-rack/jr-cross.png
-share/jack-rack/jr-down-arrow.png
-share/jack-rack/jr-up-arrow.png
-share/locale/fr/LC_MESSAGES/jack-rack.mo
-share/locale/ru/LC_MESSAGES/jack-rack.mo
-share/pixmaps/jack-rack-icon.png
-@dirrmtry share/applications
-@dirrmtry share/dtds
-@dirrm share/jack-rack
+%%DATADIR%%/applications/jack-rack.desktop
+%%DATADIR%%/dtds/jack_rack_1.0.dtd
+%%DATADIR%%/dtds/jack_rack_1.1.dtd
+%%DATADIR%%/dtds/jack_rack_1.2.dtd
+%%DATADIR%%/jack-rack/gnome-mixer-small.png
+%%DATADIR%%/jack-rack/jack-rack-logo.png
+%%DATADIR%%/jack-rack/jr-cross.png
+%%DATADIR%%/jack-rack/jr-down-arrow.png
+%%DATADIR%%/jack-rack/jr-up-arrow.png
+%%NLS%%%%DATADIR%%/locale/fr/LC_MESSAGES/jack-rack.mo
+%%NLS%%%%DATADIR%%/locale/ru/LC_MESSAGES/jack-rack.mo
+%%DATADIR%%/pixmaps/jack-rack-icon.png
+@dirrmtry %%DATADIR%%/applications
+@dirrmtry %%DATADIR%%/dtds
+@dirrm %%DATADIR%%/jack-rack
--- jack-rack-1.4.5_3.patch ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200808082022.m78KMHMa082217>