From owner-cvs-all Fri Sep 6 14:10:24 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 61AF637B400; Fri, 6 Sep 2002 14:10:16 -0700 (PDT) Received: from canning.wemm.org (canning.wemm.org [192.203.228.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2750A43E4A; Fri, 6 Sep 2002 14:10:16 -0700 (PDT) (envelope-from peter@wemm.org) Received: from wemm.org (localhost [127.0.0.1]) by canning.wemm.org (Postfix) with ESMTP id A381C2A7D6; Fri, 6 Sep 2002 14:10:15 -0700 (PDT) (envelope-from peter@wemm.org) X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: Maxim Sobolev Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net if_gre.c if_gre.h src/sys/netinet ip_gre.c In-Reply-To: <200209061816.g86IG3ni003518@freefall.freebsd.org> Date: Fri, 06 Sep 2002 14:10:15 -0700 From: Peter Wemm Message-Id: <20020906211015.A381C2A7D6@canning.wemm.org> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Maxim Sobolev wrote: > sobomax 2002/09/06 11:16:03 PDT > > Modified files: > sys/net if_gre.c if_gre.h > sys/netinet ip_gre.c > Log: > Reduce namespace pollution by staticizing everything, which doesn't need to > be visible from outside of the module. This seems to break kdump: ===> usr.bin/kdump cc -O -pipe -I/home/src/usr.bin/kdump/../ktrace -I/home/src/usr.bin/kdump/../.. -c /home/src/usr.bin/kdump/kdump.c cc -O -pipe -I/home/src/usr.bin/kdump/../ktrace -I/home/src/usr.bin/kdump/../.. -c ioctl.c In file included from ioctl.c:63: /usr/obj/home/src/i386/usr/include/net/if_gre.h:89: field `gi_i' has incomplete type /usr/obj/home/src/i386/usr/include/net/if_gre.h:133: field `mi' has incomplete type Cheers, -Peter -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message