From owner-freebsd-arm@FreeBSD.ORG  Wed Oct 31 10:26:01 2012
Return-Path: <owner-freebsd-arm@FreeBSD.ORG>
Delivered-To: freebsd-arm@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id C49D0D63;
 Wed, 31 Oct 2012 10:26:01 +0000 (UTC)
 (envelope-from doginou@kanar.ci0.org)
Received: from kanar.ci0.org (unknown
 [IPv6:2a01:e0b:1:150:ca0a:a9ff:fef1:a4c9])
 by mx1.freebsd.org (Postfix) with ESMTP id 5198F8FC12;
 Wed, 31 Oct 2012 10:26:00 +0000 (UTC)
Received: from kanar.ci0.org (pluxor@localhost [127.0.0.1])
 by kanar.ci0.org (8.14.5/8.14.5) with ESMTP id q9VAPbmP025385;
 Wed, 31 Oct 2012 11:25:37 +0100 (CET)
 (envelope-from doginou@kanar.ci0.org)
Received: (from doginou@localhost)
 by kanar.ci0.org (8.14.5/8.14.5/Submit) id q9VAPbKt025384;
 Wed, 31 Oct 2012 11:25:37 +0100 (CET) (envelope-from doginou)
Date: Wed, 31 Oct 2012 11:25:37 +0100
From: Olivier Houchard <cognet@ci0.org>
To: Giovanni Trematerra <gianni@freebsd.org>
Subject: Re: [PATCH] use vtophys instead of pmap_kextract
Message-ID: <20121031102536.GA25336@ci0.org>
References: <CACfq093f9w8BXOboHV0jy6OMKjCdVaD5BJPT+gZ9bn+yuQJHbg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CACfq093f9w8BXOboHV0jy6OMKjCdVaD5BJPT+gZ9bn+yuQJHbg@mail.gmail.com>
User-Agent: Mutt/1.4.2.3i
Cc: freebsd-arm@freebsd.org
X-BeenThere: freebsd-arm@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Porting FreeBSD to the StrongARM Processor <freebsd-arm.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-arm>,
 <mailto:freebsd-arm-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arm>
List-Post: <mailto:freebsd-arm@freebsd.org>
List-Help: <mailto:freebsd-arm-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arm>,
 <mailto:freebsd-arm-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 31 Oct 2012 10:26:01 -0000

Hi Giovanni,

On Tue, Oct 30, 2012 at 11:12:20PM +0100, Giovanni Trematerra wrote:
> Hi,
> could you please review and commit the patch below?
> 
> The patch changes the calls to pmap_kextract in vtophys macro.
> This also fixes a compiler warning when SMP is enabled to Marvel
> ARMADA XP boards.
> 

I'm not sure there's a point in doing this, the uses of pmap_kextract() are
legit, and using vtophys() instead would just hide potential type bugs. I'd
rather just explicitely add a cast in the Marvel code, as your original patch
for the TI code did.

Regards,

Olivier