Date: Sat, 10 Nov 2012 13:50:01 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: "Jason E. Hale" <jhale@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r307265 - head/multimedia/xmms Message-ID: <20121110135000.GA19769@FreeBSD.org> In-Reply-To: <8250312.uWLkCNKtQT@mocha.verizon.net> References: <201211100944.qAA9i1aM075322@svn.freebsd.org> <8250312.uWLkCNKtQT@mocha.verizon.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Nov 10, 2012 at 08:20:37AM -0500, Jason E. Hale wrote: > On Saturday, November 10, 2012 09:44:01 Alexey Dokuchaev wrote: > > New Revision: 307265 > > URL: http://svnweb.freebsd.org/changeset/ports/307265 > > > > Log: > > Apparently, in some cases (per what I observe here) using empty(...) for > > testing specific PORT_OPTIONS instead of kosher ! breaks the build. Fix > > this. While here, move the test below the target. > > > That's because it should just be: > .if empty(PORT_OPTIONS:MSIMD) > > The ${...} should be removed. The ! works too, but isn't any more kosher. Shit, you're right! I guess at this time point it does not make any sense to change it back though (it's consistent with recommended way and I personally like it better :-). ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121110135000.GA19769>