From owner-svn-src-all@freebsd.org Sat Sep 23 23:33:28 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9FE2AE1408C; Sat, 23 Sep 2017 23:33:28 +0000 (UTC) (envelope-from jonlooney@gmail.com) Received: from mail-wm0-x230.google.com (mail-wm0-x230.google.com [IPv6:2a00:1450:400c:c09::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3208D3404; Sat, 23 Sep 2017 23:33:28 +0000 (UTC) (envelope-from jonlooney@gmail.com) Received: by mail-wm0-x230.google.com with SMTP id q124so11265158wmb.0; Sat, 23 Sep 2017 16:33:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=GSmvvxETpbylxZPoJPmFDysvWLT30z5wZLjVfcR7gF4=; b=UDRSV/adcSW7SLh7jRk3poqILr3T77nWIhFrjBTdZLl/PGACd4iSgN8FPX3o5KUwqE HpAcNWMhYEuQFRyW5SQUENxKt0kbE4Z9NEygYbONYlHAA8LoLCMNKvu5vtdJv4Izzf1E HUxRIYmATWmbycmThoeS3HGJr3/m6eIaYm3E9jVzxGkkDbwXoCST8ud/kC0mmQQfn/YD L2qdVdDdt8aJqWUPCMyOy7RWQHj1b5JChRxxlTMs6CMoo0zSj8M4jN20Ow0UPvuBDnrl T0/oNhn/FJu+hc17wp2WpO9yY4dElZHKm4yfwONa1iUMkCimJP+rUFAytchY826x9Sg/ sxJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=GSmvvxETpbylxZPoJPmFDysvWLT30z5wZLjVfcR7gF4=; b=TTgjKuNk6wMwRBzVl1PAZzRowHt39SCPWuuva8Mbs1gKaAiC/wsvuVlngsVkD9xhoQ oZH5E2Cizygv0ny9RFBo+YSal6ZrW/65btY1bEbOq74eacTY4OqXrhGxG9sr9OpwqBmY kb5CjRJrL2nOASfGv7f4cfjhlhx/I1OqspQlCWD9r68JbNXXEemZkaBiDqlqr4kHiQ1A n2gL2179tXR3ncsuEP2Cak9zqYz1yG18bVH1+wT2YJJ1TTV5/bSe7siNzXown/aVfO2S xx27/tdni7eG4tUt308So3GTdV8sO7ms3mtDwJKkIhQllHUl9McG4Vx6osNAaiAF7oQX rmUg== X-Gm-Message-State: AHPjjUgfTSnI14t/3w3rFT9sQchvNAYP4z2GwerEWqJIg9OA7ntR7wSb SepTFkhwrz4NMGrB7CXz+UVZXxyEHuKXjm1h7wcvUO/f X-Google-Smtp-Source: AOwi7QAxbrejgJ1NIDkz0+qztwUJOVFb1v7TGEKhlv3wSJags2pJmyV80dlIwhUD8LGBb3O6gMyDU4foSh846rBj4Tc= X-Received: by 10.28.218.209 with SMTP id r200mr6504066wmg.97.1506209606557; Sat, 23 Sep 2017 16:33:26 -0700 (PDT) MIME-Version: 1.0 Received: by 10.223.157.10 with HTTP; Sat, 23 Sep 2017 16:33:26 -0700 (PDT) In-Reply-To: <6F5DC92C-2CF6-4A33-9663-BFECB7DB65F2@lists.zabbadoz.net> References: <201709230135.v8N1ZE6S063264@repo.freebsd.org> <283397c7-a01e-3776-7ed3-b64d68003d0b@sasktel.net> <6F5DC92C-2CF6-4A33-9663-BFECB7DB65F2@lists.zabbadoz.net> From: Jonathan Looney Date: Sat, 23 Sep 2017 19:33:26 -0400 Message-ID: Subject: Re: svn commit: r323942 - head/sys/net To: "Bjoern A. Zeeb" Cc: Stephen Hurd , Stephen Hurd , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Sep 2017 23:33:28 -0000 On Sat, Sep 23, 2017 at 4:37 AM, Bjoern A. Zeeb < bzeeb-lists@lists.zabbadoz.net> wrote: > > Then this makes no sense as we don=E2=80=99t do LRO if forwarding is enab= led on > the machine; > https://svnweb.freebsd.org/base/head/sys/netinet/tcp_lro.c? > annotate=3D317390#l645 Yes, that is true. However, this change still makes a difference. Previously, if LRO was not enabled or the packet was not eligible for LRO, the iflib code would call ifp->if_input() once for each packet. Now, the iflib code will build a chain of packets for which it couldn't do LRO and call ifp->if_input() once for the entire chain. (I agree that was not obvious from the rather short commit message and the diff in the email. The lack of comments or meaningful variable names did not help to alleviate the confusion. Nonetheless, when I looked at the diff with enough surrounding context, it became clear.) Jonathan