From owner-cvs-src@FreeBSD.ORG Tue Dec 20 04:12:35 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E946316A41F for ; Tue, 20 Dec 2005 04:12:35 +0000 (GMT) (envelope-from kabaev@gmail.com) Received: from zproxy.gmail.com (zproxy.gmail.com [64.233.162.195]) by mx1.FreeBSD.org (Postfix) with ESMTP id 65E9443D62 for ; Tue, 20 Dec 2005 04:12:32 +0000 (GMT) (envelope-from kabaev@gmail.com) Received: by zproxy.gmail.com with SMTP id 8so1395997nzo for ; Mon, 19 Dec 2005 20:12:31 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:date:from:to:cc:subject:message-id:in-reply-to:references:x-mailer:mime-version:content-type:content-transfer-encoding; b=lqip/pQ8ueqPYn/S3aOFN/ZWS+b4kXwS1nGFWIYR8TD5yuCxC1ab6YFdWqxdPoWOB8bFw3g9yKd8IJqY3tUN852arlWP432wXIDi/bVC8l2pFKyQjN3IWyiZS/h6VyWc+OIRjBifn7o9v9r40LT/MAScw1iW288evU1vcQdU5jI= Received: by 10.36.222.77 with SMTP id u77mr1170462nzg; Mon, 19 Dec 2005 20:12:31 -0800 (PST) Received: from kan.dnsalias.net ( [24.63.93.195]) by mx.gmail.com with ESMTP id 40sm4714424nzf.2005.12.19.20.12.30; Mon, 19 Dec 2005 20:12:31 -0800 (PST) Date: Mon, 19 Dec 2005 23:12:29 -0500 From: Alexander Kabaev To: "Christian S.J. Peron" Message-ID: <20051219231229.6d663308@kan.dnsalias.net> In-Reply-To: <20051220032724.GA12119@hub.freebsd.org> References: <200512200049.jBK0nxil048441@repoman.freebsd.org> <20051220032724.GA12119@hub.freebsd.org> X-Mailer: Sylpheed-Claws 1.9.13 (GTK+ 2.6.9; i386-portbld-freebsd7.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Pawel Jakub Dawidek , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern vfs_syscalls.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Dec 2005 04:12:36 -0000 On Tue, 20 Dec 2005 03:27:24 +0000 "Christian S.J. Peron" wrote: > On Tue, Dec 20, 2005 at 12:49:59AM +0000, Pawel Jakub Dawidek wrote: > > pjd 2005-12-20 00:49:59 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/kern vfs_syscalls.c > > Log: > > Reduce Giant scope a bit, as fdrop() is believed to be MPSAFE. > > The purpose of this change is consistency (not performance > > improvement:)), as it was hard to tell if fdrop() is MPSAFE or not > > when I saw it sometimes under the Giant and sometimes without it. > > > > Glanced at by: ssouhlal, kan > > > > Revision Changes Path > > 1.396 +7 -9 src/sys/kern/vfs_syscalls.c > > Did you check to make sure that all the fo_close() operations are MP > safe? I think we are safe in the common case, but we need to pay > special attention to edge cases like the ones in > sys/opencrypto/cryptodev.c (cryptof_close()). I am not sure that > these operations are MP safe yet, in which case we might run into > problems without the Giant aquisition. > > -- > Christian S.J. Peron > csjp@FreeBSD.ORG > FreeBSD Committer > FreeBSD Security Team As far as I can see, the code changes apply only to descriptors backed by vnodes, and vn_closefile takes care of acquiring Giant before calling into non-mpsafe FS VOPS. So cryptof_close() operation is not affected by this patch. -- Alexander Kabaev