Date: Sat, 14 Apr 2018 08:57:10 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 227500] audio/mous: update to 2.0.1 Message-ID: <bug-227500-7788-LhhCCD7C0a@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-227500-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-227500-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D227500 Tobias Kortkamp <tobik@freebsd.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tobik@freebsd.org --- Comment #2 from Tobias Kortkamp <tobik@freebsd.org> --- Thanks for your submission. While this looks mostly ok to me there here are couple of things that could be improved. Can you submit an updated patch? +MASTER_SITES=3D GH USE_GITHUB=3Dyes already implies the same, so this can be removed. +PORTVERSION=3D 2.0.1 +DISTVERSIONPREFIX=3D v ... +GH_TAGNAME=3D v2.0.1 Remove GH_TAGNAME. DISTVERSIONPREFIX + PORTVERSION already sets it to the same value. +CMAKE_ARGS+=3D -DWITH_PLUGIN_ALSA=3D0 \ + -DWITH_PLUGIN_LIBAO=3D0 \ + -DWITH_PLUGIN_COREAUDIO=3D0 \ + -DWITH_PLUGIN_FAAC=3D0 \ + -DWITH_PLUGIN_FAAD=3D0 \ + -DWITH_PLUGIN_WMA=3D0 This should use CMAKE_OFF i.e. CMAKE_OFF=3D WITH_PLUGIN_ALSA \ WITH_PLUGIN_LIBAO \ WITH_PLUGIN_COREAUDIO \ WITH_PLUGIN_FAAC \ wITH_PLUGIN_FAAD \ WITH_PLUGIN_WMA +SNDIO_CMAKE_ON=3D -DWITH_PLUGIN_SNDIO=3D1 +SNDIO_CMAKE_OFF=3D -DWITH_PLUGIN_SNDIO=3D0 This can be replaced by the much easier to read SNDIO_CMAKE_BOOL=3D WITH_PLUGIN_SNDIO This also applies to all the other *_CMAKE_{ON,OFF} pairs. +USES=3D cmake:outsource,noninja compiler:c++14-lang Why is noninja needed? Having a small comment in the Makefile to explain why it's needed is always nice. +INSTALL_TARGET=3D install/strip This can probably be removed too. Uses/cmake.mk already sets it. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-227500-7788-LhhCCD7C0a>