From owner-svn-src-all@freebsd.org Fri Jan 25 18:23:15 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 66DD114BD5E8 for ; Fri, 25 Jan 2019 18:23:15 +0000 (UTC) (envelope-from oliver.pinter@hardenedbsd.org) Received: from mail-yb1-xb2c.google.com (mail-yb1-xb2c.google.com [IPv6:2607:f8b0:4864:20::b2c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id EB9228FB4A for ; Fri, 25 Jan 2019 18:23:14 +0000 (UTC) (envelope-from oliver.pinter@hardenedbsd.org) Received: by mail-yb1-xb2c.google.com with SMTP id h81so4208410ybg.2 for ; Fri, 25 Jan 2019 10:23:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Objjj4un4U35y7rbuOftV4znjkTzyQQSM7KheT0gsZk=; b=WbAOQDNxIE6eAoFiHmvq2McFgWfclfg+1IDzfE45DMj8wFO68TxFy+zdAFTQqHb0lL Tb+l9nYlGx+625DfhFElzOIp5C9y6eQWC2SXlsvkcYClZ8wKT0LYRo7NDI4SlmUgJOcZ ytoPOln8WwwK2HxiSr4s80aeWImwX1h/b1d/Q1BhLqQXC4U44VL2z7VY3MNtCeySF/dU vLHoK8O+TdLeQpiIbHfRpHwIRPPJdU289rXe2QFnt3abDvqcxhBwcoQCm9QYd35L0Ojw EbGmcanxbQEDDRV8HxU2eXdIF+msna0srFeXcZ7oKbHDQbtqL1+pk7452/s+VTqHqm2Z pYUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Objjj4un4U35y7rbuOftV4znjkTzyQQSM7KheT0gsZk=; b=uICnQDwOFbGrCbbhc/+7GYjfDe+BfRj/YkXly7DIi3OLQ+xznhZN88/9z6hS881noZ /i+xSi7lRkqRRZnM02/Gg9tpbpE8YQ+o1lJYEaPMjQ1FfDpe2Ybmc6B96evdt245UcnD m8RmGA7jV8KR1oDoGLK0Wm9GmnXqQFhfq3K5UcuoBJhhUPRWbBaoBI5+H/q22lxPphCH OlOX31lSa9sTpXxheguDMn895Z4ZKV1e08k1q8aT3qmwBJkxICe5lsPHpPTD3TdZ3MQa Z2W7PxvUsBQsbduWf0p2JR7hb4csHQ9utDTGyGbOgeQqBsOm2a3lVuyyccjy3SDKcfLh uJDA== X-Gm-Message-State: AJcUukeQfBOAXcjo36NCXsiQ4AciTTTqiOxhK6obIIuQS8FyQrqr0siz pRI9IDOwrPDaaJzNcvV0iknLwcOOifB0spmKk8PB/A== X-Google-Smtp-Source: ALg8bN75mFjUSnq/dNeHISIjILIf0pUOIrl2S5LNaj0fcXs16VtWF5SQdM5D3GUs1V168lVI23364FsuI4fiY8sNwvs= X-Received: by 2002:a25:bd5:: with SMTP id 204mr11658825ybl.486.1548440594319; Fri, 25 Jan 2019 10:23:14 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a5b:ec8:0:0:0:0:0 with HTTP; Fri, 25 Jan 2019 10:23:13 -0800 (PST) In-Reply-To: <20190125181320.GA5015@FreeBSD.org> References: <201901251339.x0PDd5sG088601@pdx.rh.CN85.dnsmgr.net> <20190125060258.GA25351@v2> <20190125181320.GA5015@FreeBSD.org> From: Oliver Pinter Date: Fri, 25 Jan 2019 19:23:13 +0100 Message-ID: Subject: Re: svn commit: r343416 - head/bin/sh To: Alexey Dokuchaev Cc: "rgrimes@freebsd.org" , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" X-Rspamd-Queue-Id: EB9228FB4A X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.978,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jan 2019 18:23:15 -0000 On Friday, January 25, 2019, Alexey Dokuchaev wrote: > On Fri, Jan 25, 2019 at 06:02:58AM +0000, Edward Napierala wrote: > > The aliases are gone, let's continue on the remaining bits below. > > They are not gone, they were commented out; also, bogus double linefeeds > are not gone. But most importantly, this whole file is useless and IMHO > should just be removed. /bin/sh is not supposed to be one's interactive > shell. False. Since the ability to install the system from pkg, and the ability to remove the tcsh package easily, someone really want to or try to use sh as their default interactive shell. >From other hand there are no clear communication about the fact that the /bin/sh isn't suitable for interactive in non-developer visible place - like in motd or in official documentations, fix me if I'm wrong. > > > It is alien, because it's different from their experience > > from other systems they are used to. > > This argument does not really hold because /bin/sh is not... see above. > > > It doesn't affect existing installs. It doesn't affect people > > who run the default root shell (tcsh), nor folks who use shells > > AFAICT default root shell is /bin/csh, not tcsh. ;-) But that also > means that /usr/src/bin/sh/dot.shrc doesn't have to exist: those who > change the root shell should either pick another interactive shell, > or if they want /bin/sh be ready to deal with sanitary environment. > > > And for folks who do have their own tree with their preferred > > /root/.shrc to "make distribution" from, it should actually make > > their diff to upstream smaller. > > I don't like extra files, esp. configuration files that look like they > are for interactive shell while our /bin/sh is in fact not. This is > confusing, and FreeBSD is not supposed to be confusing. > > > It is a syntax problem: > > > > trasz@v2:~ % while :; do date; sleep 1; done > > while: Expression Syntax. > > do: Command not found. > > done: Command not found. > > Are you trying to use sh(1) loop in (t)csh? Why? And what does it have > to do with the /usr/src/bin/sh/dot.shrc issue? > > ./danfe > _______________________________________________ > svn-src-head@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-head > To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org" >