From owner-freebsd-ports@freebsd.org Thu May 17 23:29:38 2018 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 15A4CEE327C for ; Thu, 17 May 2018 23:29:38 +0000 (UTC) (envelope-from john@saltant.com) Received: from twaddle.saltant.net (twaddle.saltant.net [IPv6:2001:470:8d6f:1001::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9BB0C7B38D; Thu, 17 May 2018 23:29:37 +0000 (UTC) (envelope-from john@saltant.com) Received: from dither.saltant.net (dither.saltant.net [IPv6:2001:470:8d6f:1001::3]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by twaddle.saltant.net (Postfix) with ESMTPSA id F014311202; Thu, 17 May 2018 19:29:36 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=saltant.com; s=twaddle; t=1526599777; bh=PbNMmtL/z950h0/M2f8n/jBhBIdayowyNi9osAlGLis=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=Gw+JhMVngvR1o5isEaD6pIt3lwfMK3k9G23xToHAKod0Rk0fP4HxhQA6iv/B9RWKB 0V3ap3ysKwwqQ2NM/8XSNqqBwBPgNaWJYOZcaCsogWmOBQN4tL5k3qz7WJrdB8fptW 6Se291oBFrZw15vHO5noeftOvEL9QgfDlEqY+FNoR7e1oaiC5ToxNvD3rNx6q4ze7Z V5gPTC2b9PACtmFGj/uT2HUMU+iTvexig4lY75VtOMOWW3FshtRXKJwyZdTCwCXZiC cRAUYRVNzlwf/ZKZfoHQF479YwUHTqQ1XWiVEYLQNQpnvJuNzRRrkkesbBLEI3386h bnS6CR2ldRDWQ== Subject: Re: Practice of "Sponsored by" in commit messages To: Maxim Sobolev Cc: FreeBSD Ports References: <3cc77471-4200-1f45-e83d-2ae4d636f4fa@saltant.com> From: "John W. O'Brien" Autocrypt: addr=john@saltant.com; prefer-encrypt=mutual; keydata= xsFNBFpcMG0BEACeAEQ0ZTUEH+6B8XIBid2H8g1yY+niHxVphqz8JwnQtYX+bS+Kl3vr783F HH81DEbfPtYgHY53NF9FjSzCyj13lXVnEGQOdxXzZVKsN1nyuXCN2hDOFH7Yc5yQ8h85T4Hv sqPIGIXOztu4MX14iUAcTgLhfibNQBeKDeNI+BBeaE9lPuNVeiM+xsI4JYcjmDbjFzAHRpBo ull0koUFh6RZAKE7u17yLej1pTIQQVjQpWdK37BAq4hdkLwjGDY8mDGo3ZwGdNibxIAxv/wi KU6u2DfUg8+kLHIhOqk/+kFQ/uK5YA1azsyD5eIbNAs4W7LglA6SkiGBglTwkP0VCrkPdD14 6sx3U7uFgexDWbVuhLIkcPQ0SRmnjgUKHgk7px/jMvAPKSKoL0JQNdP/+pnO9CDLGmoHx9gE 5kVr5dQK8c/WauEfimAdE9qLuN6vb0Iei73q3e3OOHAUusR5wC5SwXt4iilbaK4r04NKXyfb SB3+qWST07F9cmMscfEStSBhpez3awB+1jz8gr40tkEGsFZGvD2KKAgZdKpoxv6IrZepclWz HpqHF01SRFORYMsd1d83XlEu/S1/Z9YJ87RoCdZuYCkjnoRPtpTi9d+JD/u3ZiQFwLUz/Ne3 VqiGKvY66EGcO3tvANMg6GWD9sqlnBDp9Lls0ChEY3dgDYd6DQARAQABzSJKb2huIFcuIE8n QnJpZW4gPGpvaG5Ac2FsdGFudC5jb20+wsGUBBMBCAA+AhsDBQsJCAcCBhUKCQgLAgQWAgMB Ah4BAheAFiEENPkbBr3zmPAVSH2HM8TWS4ldvzsFAlpcMTMFCQX2qcYACgkQM8TWS4ldvztT xQ//eHb1mgd40Z0fN2GnJti6/9uJ771IO6slFQ02GZcXZI+FIQo8Yd1dHe0e0Codu78qvJNr ggUtqdxH6SVp7K1AWHeLH5S0PF6iG5B+YUux080wEv/Mr8PPMgAD8gS3wiPDDgB/kUXO52bn DC3Fc0dUrFE/JAOByVEEDL5nLF6SQNpAtIUnaAIIuhKxi0d40LMcLUwuJ6jExynw8Iu7OVtu Y1PRAH5ESt6wYZq8ro8ukh4rMOxiWtT1yNEgHgnq3N4jKErVo87YJijHSSj80IKxUiKb/T6K tGTEBTKiSUV3OFj0ZoPxcbUmhIg2sBCNHaUCiI0KabqN1NyK2glKtcK6NpWy3JIHvtr3+VL1 /tvQTwlVUIacmsuxkGzm5vJPs/i2RtwsJXEXPmIRNgJ1EwZgpg5VqqEUDlmSyRLb48QcDrdv utKLA1MKLib1fD+0XmxZTbCMlFMlvJjAoBlVq60mvB/Jnv1TTnZ2eN6DKMWoxHKmPICh5F1q esmT/aJRIUoCiAgcChi4Ol4XmW3dM7ypjKCGHzyr6emCky5pjqSQZyFzg0RN5UjUQBISAGmJ E8hCFZIy7tf8meqIDbtkONh+JShN6u3t02JrnzSOQjZCh5WQW9Pnu7unJlIsYB10aZ6rvuAK YjghT8QLG8QVgJj/U9oeVG1Ag60fmLZdOFjRGmnOwU0EWlwwbQEQANebvidw1D5SKSmG3Ut8 p9vngBi5HjYe4FSYcfz0NgYa893RiScQ6yjOwuEf/fEoBgvpVnhcbu0JsaYvDNNzFGzPQcj0 CFhkr5s7REWNLGmmFCxCaGieTxIQdYsLxwn72mops8bsrL0a++8NDE+l7X4K3EUyp9GP7pIq 4l9jeIJ/RnX3yySRlXxcM3P+DV9ltXsnQ9pC/qEVVyK18C1zoiskhxmAY9cv9TJOaANHtA7R 7+hM5TyppIz7kqiwiCf6XfVFqKH0I0srdamb0KTnAZpmyx7iNKYl60PdIfEwkwck8fcGwOSA lwE9CLkHLwKMjx/gF3xRag5xjOdP/Out0cQ/pXv8DWnKblWbiGZheB4xUqhOT9Cj/8u/tKtC 51C9wID26hsrhtSAMJPUwQoo/SwLNEd1JpkqUP1njOdlV8FmM1EozHLPSvwlTm6oWwubkkY6 QkUHqXuO+2VdNhyDfx23fQhd0UPhQ0ceDRnjaSB9ycWqpktBP5iNQajYbx5Ktt8fC2Y+Ztjo u1KY7wJSUzqh7uZgR1TqIOVZp7bdPLBGHW5eNEf0Awq17utGe6d9i4hPmeNqELUz71hjmABm bIQJ+VgqYcQ0T/PrjwhzHv5g3jn67/ftW91nlTNpbhwm8suIdPA1hF6vgnZ3B4+JsevnevLG yU6YCb0OOKleP6pZABEBAAHCwXwEGAEIACYCGwwWIQQ0+RsGvfOY8BVIfYczxNZLiV2/OwUC WlwxTQUJBBV2YAAKCRAzxNZLiV2/O2PnD/wMKz/rzYbf0SaTvgae4jqryrcWRta56dcnVe7W KPuUu4Q/WBGhXKeCfPrlr399bILxZGw5TXuGMjS8gEoMd81PEMcWaMpgg3F569Cxd9GN6AZd LXXrZa0aM7dvZkz98ymILEnqHMpF74sLvZY2PrsOwo2gKXNqhtCJ2ph8OUKhG+NHvAomjMu9 lPQMkXJ4HRV0OljawqAe4y+IFu2K4abWwZw1mdniTCb5al8V2umzf26QL0DgeFp3banlfjYW Dn5cRuDBQqIoR/6cQaKdFKTJYiTVK3p3WRWiJQniYi39S8CR646w+zVi7ax1shSB0r0lxIFo CZu285HcMd7HsHH+T2ZI45ilayUoyoZvxPPlwhiRzyYZ6qqAAXKDihhda7uNApUqLwoSn5FW njmx6KdlVPF9ycCdf+in5k6nVlHWG15ogF/Y96K+/Q1Iuod9rzWqT4bz9a5olY8r++QE3V1b H3z803wXEUAJg+WGTkYXFNw7w6RhSSEhBRzupDoCROSkRhe3vQGy5FLG+BMV9n9nevhj5sBx CM1BbNBdB5H/2RcXh0wSb6zjewgs3UAbBvCQOdMAMo8XpYM5SLBqtaY7oalBElTxtFnwSNJm hMbahYE/wHbkmMqalrzGyQxbSUdrmE64CIX8xmv47fnjRoTZMzKim/02MRH+Ss1M+rLzpw== Organization: Saltant Solutions Message-ID: <732c3f40-1765-6883-dbec-f5c77db8e30c@saltant.com> Date: Thu, 17 May 2018 19:29:28 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ipxY3PvvdIpwXsh7e05OaHurAqQLPHb0W" X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 May 2018 23:29:38 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ipxY3PvvdIpwXsh7e05OaHurAqQLPHb0W Content-Type: multipart/mixed; boundary="zOfGIU9lqhpobE3sN38iax2hPQuUXcDdu"; protected-headers="v1" From: "John W. O'Brien" To: Maxim Sobolev Cc: FreeBSD Ports Message-ID: <732c3f40-1765-6883-dbec-f5c77db8e30c@saltant.com> Subject: Re: Practice of "Sponsored by" in commit messages References: <3cc77471-4200-1f45-e83d-2ae4d636f4fa@saltant.com> In-Reply-To: --zOfGIU9lqhpobE3sN38iax2hPQuUXcDdu Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 2018/05/17 19:18, Maxim Sobolev wrote: > John, no, not really, sorry. Work is done, credit is given. The form an= d > amount of this credit is between whoever does the work and whoever is > being credited. I don't see why is there any third-party to be involved= > in governing whether or not this credit is "appropriate", "sufficient" > or "all encompassing" for the work in question. This is just a credit, > it does not affect the quality of work, nor the license (which is > 2-clause BSD) nor the copyright holder. Three things that really matter= > long-time. So "Sponsored by" it's just the message on the t-shirt, > having only meaning to whoever produces the piece and whoever wears it,= > but nothing in particular to the outside world. IMHO. I fear that you and I are still not on the same page. The difference between a t-shirt and a commit message is that two or three or four people can all do work on the same commit, but only one person can wear a t-shirt. Taking the analogy further, if you hang a t-shirt with your employer's logo on a piece of work that you and I collaborated to produce, don't you think my employer might feel slighted? What if I had done 80% of the work? > On Thu, May 17, 2018 at 3:43 PM, John W. O'Brien > wrote: >=20 > On 2018/05/14 20:14, Maxim Sobolev wrote: > > What's wrong with a current practice. Why is it of any concern to= you, > > John? Just curious that is not very clear from your message. It i= s like > > someone trying to moderate what people in general or some group i= n > > particular (e.g. freebsd committers) are allowed to put on their > > t-shirts just because you find it offensive or inappropriate. >=20 > I don't find crediting sponsors offensive nor inappropriate. Quite = the > contrary. What I find problematic is when multiple people do work, = not > all with sponsorship or the same sponsorship, and only one person's= > sponsor is mentioned in a way that seems to imply that all the work= was > sponsored. >=20 > What I'm proposing is not to end or ban the practice, but to improv= e and > refine it so that sponsors are credited for what they sponsor and n= ot > for what they don't sponsor. >=20 > Is that clearer? >=20 > > On Mon, May 14, 2018, 4:40 PM John W. O'Brien > > >> wrote: > > > >=C2=A0 =C2=A0 =C2=A0Hello FreeBSD Ports, > > > >=C2=A0 =C2=A0 =C2=A0The Committer's Guide section on Commit Log Me= ssages [0], > doesn't cover > >=C2=A0 =C2=A0 =C2=A0the use of the "Sponsored by" key word. As a n= on-committer > contributor, > >=C2=A0 =C2=A0 =C2=A0it only recently occurred to me to wonder what= work that credit is > >=C2=A0 =C2=A0 =C2=A0intended to represent, and whether some light = definition would be > >=C2=A0 =C2=A0 =C2=A0helpful to reduce ambiguity. > > > >=C2=A0 =C2=A0 =C2=A0When a committer credits a sponsor of theirs, = from which the > contributor > >=C2=A0 =C2=A0 =C2=A0received no sponsorship, the portrayal feels a= little awkward. > Does this > >=C2=A0 =C2=A0 =C2=A0strike the list as a problem, and if so, how o= ught it be solved? > > > >=C2=A0 =C2=A0 =C2=A0To make this concrete, allow me to illustrate = the situation. > > > >=C2=A0 =C2=A0 =C2=A0Alice, working on her own time, prepares and c= ontributes a > patch. Bob, > >=C2=A0 =C2=A0 =C2=A0who works for Acme Corp, reviews and commits t= he patch on > company time. > >=C2=A0 =C2=A0 =C2=A0The commit message includes "Sponsored by: Acm= e Corp". Alice > eagerly > >=C2=A0 =C2=A0 =C2=A0awaits her check from Acme Corp. Should the co= mmit message > have read > >=C2=A0 =C2=A0 =C2=A0"Sponsored by: Acme Corp (Bob)"? > > > >=C2=A0 =C2=A0 =C2=A0This could be extensible to multiple sponsorsh= ips. If, > instead, Alice > >=C2=A0 =C2=A0 =C2=A0prepares the patch having received a grant to = do so from Best > Sys Dev, > >=C2=A0 =C2=A0 =C2=A0the commit message could state "Sponsored by: = Acme Corp (Bob), > Best Sys > >=C2=A0 =C2=A0 =C2=A0Dev (Alice)". > > > >=C2=A0 =C2=A0 =C2=A0[0] > >=C2=A0 =C2=A0 > =C2=A0https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committe= rs-guide/article.html#commit-log-message > > > > >=C2=A0 =C2=A0 =C2=A0PS: I realize that this issue transcends ports= , but it's not > clear where > >=C2=A0 =C2=A0 =C2=A0I should send this instead, and this list seem= s like it would > have a > >=C2=A0 =C2=A0 =C2=A0reasonably high concentration of people with a= stake in the > discussion. --=20 John W. O'Brien OpenPGP keys: 0x33C4D64B895DBF3B --zOfGIU9lqhpobE3sN38iax2hPQuUXcDdu-- --ipxY3PvvdIpwXsh7e05OaHurAqQLPHb0W Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEKpEHkkRoSDiIJkQOWPtK56pP/m4FAlr+EFkACgkQWPtK56pP /m4LQQgAhjViefg1gNeusXV7QGV7vgDHVNWG0FRVQRvxhxy1dQtuf6R7GzqGPEcD MuCjOJzn/WwZIA4htRzpS+JyLoJGc+Ad8FhCcLKM2rCDP+L4RtQrxC3x6WDwd8Ga SExhRbWSq54+pZ0EwEZNlNq1ekGa880rU7k9XMobnjFBBZQR/uya50vxQeiYGQSo J+X86KuWMD+KFpthYXUw9faaVIwfpHY5Da5YeueCael6ViYpVhqsY70XuhGcPzhE KkLpHxW6G/h4qhWn3/XnWXEpfiZ25V/Kbclc1Q2Rdyzw8CbiZuXg/1WChlax8zVm YbEUmYTiCz9wCWVbwdyqj4SIuQqtdQ== =Hkn5 -----END PGP SIGNATURE----- --ipxY3PvvdIpwXsh7e05OaHurAqQLPHb0W--