From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Jun 4 09:20:11 2011 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A129210657C5 for ; Sat, 4 Jun 2011 09:20:11 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 6D5848FC12 for ; Sat, 4 Jun 2011 09:20:11 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p549KB1w024393 for ; Sat, 4 Jun 2011 09:20:11 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p549KBhi024391; Sat, 4 Jun 2011 09:20:11 GMT (envelope-from gnats) Resent-Date: Sat, 4 Jun 2011 09:20:11 GMT Resent-Message-Id: <201106040920.p549KBhi024391@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Chris Rees Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 568F21065672 for ; Sat, 4 Jun 2011 09:17:42 +0000 (UTC) (envelope-from utisoft@hotmail.com) Received: from blu0-omc1-s9.blu0.hotmail.com (blu0-omc1-s9.blu0.hotmail.com [65.55.116.20]) by mx1.freebsd.org (Postfix) with ESMTP id 0E7C18FC0A for ; Sat, 4 Jun 2011 09:17:41 +0000 (UTC) Received: from BLU0-SMTP30 ([65.55.116.8]) by blu0-omc1-s9.blu0.hotmail.com with Microsoft SMTPSVC(6.0.3790.4675); Sat, 4 Jun 2011 02:17:41 -0700 Received: from zeus.bayofrum.net ([90.221.7.100]) by BLU0-SMTP30.phx.gbl over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Sat, 4 Jun 2011 02:17:39 -0700 Received: from zeus.bayofrum.net (crees@localhost [127.0.0.1]) by zeus.bayofrum.net (8.14.4/8.14.4) with ESMTP id p549HC5J012960 (version=TLSv1/SSLv3 cipher=DHE-DSS-AES256-SHA bits=256 verify=NO) for ; Sat, 4 Jun 2011 10:17:12 +0100 (BST) (envelope-from chris@zeus.bayofrum.net) Received: (from crees@localhost) by zeus.bayofrum.net (8.14.4/8.14.4/Submit) id p549HCOf012959; Sat, 4 Jun 2011 10:17:12 +0100 (BST) (envelope-from chris) Message-Id: Date: Sat, 4 Jun 2011 10:17:12 +0100 From: Chris Rees Sender: To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/157582: Fix port: games/ldmud should use USERs X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Chris Rees List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Jun 2011 09:20:11 -0000 >Number: 157582 >Category: ports >Synopsis: Fix port: games/ldmud should use USERs >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sat Jun 04 09:20:11 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Chris Rees >Release: FreeBSD 8.2-RELEASE-p1 i386 >Organization: bayofrum >Environment: System: FreeBSD zeus.bayofrum.net 8.2-RELEASE-p1 FreeBSD 8.2-RELEASE-p1 #0: Sat Apr 30 15:09:06 BST 2011 root@zeus.bayofrum.net:/usr/obj/usr/src/sys/ZEUS i386 >Description: This port uses pkg-install to create new users instead of using USERS= and GROUPS= >How-To-Repeat: >Fix: - Use USERS and GROUPS Submitted by: Chris Rees (utisoft@gmail.com) Please note that pkg-deinstall and pkg-install have been removed. --- games-ldmud.patch begins here --- Index: Makefile =================================================================== RCS file: /exports/cvsroot-freebsd/ports/games/ldmud/Makefile,v retrieving revision 1.8 diff -u -r1.8 Makefile --- Makefile 20 Nov 2009 22:53:02 -0000 1.8 +++ Makefile 2 Jun 2011 17:44:37 -0000 @@ -20,6 +20,9 @@ MAN1= ldmud.1 MAKE_JOBS_UNSAFE= yes +USERS= mud +GROUPS= ${USERS} + LOGDIR= ${DATADIR} .if defined(MUDLIB) && ${MUDLIB} == lpmud PLIST_SUB+= LPMUD="" MUDLIB="@comment " @@ -55,8 +58,5 @@ | ${CPIO} -pdmu -R ${SHAREOWN}:${SHAREGRP} ${DOCSDIR} ${RM} -f ${DOCSDIR}/Makefile .endif - # Run package install script - ${SETENV} PKG_PREFIX=${PREFIX} ${SH} ${PKGDIR}/pkg-install ${PKGNAME} \ - POST-INSTALL .include Index: pkg-deinstall =================================================================== RCS file: pkg-deinstall diff -N pkg-deinstall --- pkg-deinstall 5 Sep 2003 22:26:41 -0000 1.1 +++ /dev/null 1 Jan 1970 00:00:00 -0000 @@ -1,15 +0,0 @@ -#!/bin/sh -# $FreeBSD: ports/games/ldmud/pkg-deinstall,v 1.1 2003/09/05 22:26:41 glewis Exp $ -# - -if [ "$2" != "POST-DEINSTALL" ]; then - exit 0 -fi - -USER=mud - -if pw usershow "${USER}" 2>/dev/null 1>&2; then - echo "To delete MUD user permanently, use 'pw userdel \"${USER}\"'" -fi - -exit 0 Index: pkg-install =================================================================== RCS file: pkg-install diff -N pkg-install --- pkg-install 5 Sep 2003 22:26:41 -0000 1.1 +++ /dev/null 1 Jan 1970 00:00:00 -0000 @@ -1,37 +0,0 @@ -#!/bin/sh -# $FreeBSD: ports/games/ldmud/pkg-install,v 1.1 2003/09/05 22:26:41 glewis Exp $ - -if [ "$2" = "PRE-INSTALL" ]; then - exit 0 -fi - -PATH=/bin:/sbin:/usr/bin:/usr/sbin - -USER=mud -GROUP=${USER} -UID=97 -GID=${UID} - -if pw groupshow "${GROUP}" 2>/dev/null; then - echo "Using existing group \"${GROUP}\"." -else - if pw groupadd "${GROUP}" -g ${GID}; then - echo "Added group \"${GROUP}\"." - else - echo "Adding group \"${GROUP}\" failed..." - exit 1 - fi -fi - -if pw usershow "${USER}" 2>/dev/null; then - echo "Using existing user \"${USER}\"." -else - if pw useradd "${USER}" -u ${UID} -g "${GROUP}" -h - \ - -s "/bin/sh" -d "/nonexistent" -c "MUD Owner" - then - echo "Added user \"${USER}\"." - else - echo "Adding user \"${USER}\" failed..." - exit 1 - fi -fi --- games-ldmud.patch ends here --- -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean. >Release-Note: >Audit-Trail: >Unformatted: