From owner-freebsd-fs@freebsd.org Sat Dec 12 17:33:18 2020 Return-Path: Delivered-To: freebsd-fs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6B1D04BB520 for ; Sat, 12 Dec 2020 17:33:18 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-QB1-obe.outbound.protection.outlook.com (mail-eopbgr660076.outbound.protection.outlook.com [40.107.66.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CtZW126XKz3hTF for ; Sat, 12 Dec 2020 17:33:16 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oQjbnLOnSF2GPlitCetNJXWivT8DxfYlpIR5kAIFl8PMYOW8pXFgEGr0JpTCKbMp9QcXxc28gxF60cSwtD/ELyPfe+7DtJ4VB4B738LIR8LqbtNbY7iCvJkDJuPvkJKm6IUnMGEyj8qtXYZrZntJDAHTcNj5Slf/8FcgDKc4BA5xe5+pz/coqjJKA1koEtOePKoMRBdgKRpUKduHbV3bK2bEEfchPtvRu1lUJkdDXzjLSmTGIv0tIKwoqocs6em3WC7RL/EG3VHlj8YoMKrLfE23xmvGvEixFivYrT4mRjP74U1w6U3cgX0V2qnIQKlNKCIk0hCZDg9TDzahnfrMyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dfM5XBztkhn4kj4oaFFOr2LZgHyoCPN2ViEZOO5bR/U=; b=XAvDO5Tc+I4oqMKw81CYNMnK8BCrIyeO/KVycctkicNclfBI2HPCNNFtogeVIBGWuxh4mW6iVNOsA5hP6iu53w5hf0tF7PuN2ywyApBHSC4peE9BKrEjfyl4LFgrZvLTMMNLT1Br6maDPjmQ4M76QEmubANEgZ+NfwT1hA2a6sDDmn/631Rd278jJCMCPmrb+tsPew0gOdcd2xibSHixsq56KBw1xx29SyqyAbMa92TefOymZiQ/bOvppyXXnqQRcvuqMIG4k+n7kWC6+RJUV7pXXoYudv7ZTfk4b9c6JDPe/EeiNFVcXeykQvUfxoFoTHzNr0m9CkryrnF7k2+X5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=uoguelph.ca; dmarc=pass action=none header.from=uoguelph.ca; dkim=pass header.d=uoguelph.ca; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uoguelph.ca; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dfM5XBztkhn4kj4oaFFOr2LZgHyoCPN2ViEZOO5bR/U=; b=iKJd7UAfADxDHChWNobPjoqMeqcnvaOXC4bwGL1m8EQ7Z94g1M7y3Kh7WtgAcvaZ53+KDksPA8CaUsMGwLMeL2OhvcY5kTMg6v5DVNiwwOtBDVGVgwlH6wbnbm6IbBeOjoKWqk4r3M2t56NmQkGJwMRVO9DfkHFgsxibDxYONj/XrI9vj6RWEjC+Y/ormx82Wm1LBHa0dqQ5T6uXxyYjuwL+dGKGTNYNFEHW4BeeBOafpXPgqIuvT25oJ8DzreAlhrG2gPDV2ABN3HJMenPtcMA/WdQi5NZGdVEW/t3Pq1MYT/d7rtsDWZOHsG+ONFeY+XiuLR+9FacAhkBjEOkQgw== Received: from YQXPR0101MB0968.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c00:19::29) by QB1PR01MB3985.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c00:3c::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.12; Sat, 12 Dec 2020 17:33:15 +0000 Received: from YQXPR0101MB0968.CANPRD01.PROD.OUTLOOK.COM ([fe80::7d6b:aa68:78f4:5d94]) by YQXPR0101MB0968.CANPRD01.PROD.OUTLOOK.COM ([fe80::7d6b:aa68:78f4:5d94%7]) with mapi id 15.20.3654.019; Sat, 12 Dec 2020 17:33:06 +0000 From: Rick Macklem To: Konstantin Belousov CC: J David , "freebsd-fs@freebsd.org" Subject: Re: Major issues with nfsv4 Thread-Topic: Major issues with nfsv4 Thread-Index: AQHWzw/HDat+dHoH9kKG5K3Xpd53kqnxDteQgAFi0QCAABTa84AALLCAgAAVvcmAAAu0AIAA4wiA Date: Sat, 12 Dec 2020 17:33:06 +0000 Message-ID: References: , In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 815e41b4-7d2d-4b50-c058-08d89ec3fc47 x-ms-traffictypediagnostic: QB1PR01MB3985: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ECTDa+9z6UiKOZWRa/gpKC5vBFIMEINHXt3p/Z5Y+HMIDzWaZx5JSaHgn0rg6RcdUuN0DrFi51TZAZD27W9ySqJz/QLJSvuVV/YkcWHXcDgbavFpf3Kg1+xRNJwHgQ9D5pd64WTJzHWq+QYa41rviZRwG5YVrFdtrl+cz5Xg4ZJw5p0fepoRM9nudZTw/EhF+FQ0G+rInR/T9cKG1zD6AMrIf5cqtQ6gWXIuuFc+CAfiOMJr9QTdun+s4EGK2CP5IbyxiEUSqk0wVZkvnNMBbQ8io9DaPr8C1ezk5QLMSBvsvJabdXuBM9S6pyL6KTfpf4AwBY196JZd4Lk96nLKWQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YQXPR0101MB0968.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(376002)(136003)(39860400002)(346002)(366004)(396003)(4326008)(8676002)(64756008)(33656002)(66446008)(66476007)(66556008)(66946007)(76116006)(6506007)(8936002)(52536014)(91956017)(4744005)(2906002)(71200400001)(54906003)(7696005)(86362001)(186003)(478600001)(316002)(83380400001)(5660300002)(6916009)(9686003)(55016002)(786003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?iso-8859-1?Q?8L8hbcawwzS3o+y0spIvwSVlOH4/cpR8jusq7f2gkBJ/ccPYyGivsnBX9y?= =?iso-8859-1?Q?uxliLR+1dlQuy5mxvZNu4g2JZepsyT66syxKep9iKMdYG3HZrxdLmaci6y?= =?iso-8859-1?Q?D2oyUQRBvD9IIwyMyfRqt4Tqs6EHUsdjaUbPbzmwQZQ6nDy8Jb2F0sOTw6?= =?iso-8859-1?Q?T7OBpsIr3BIya24tadgg9IAOMNz6qMbg5gZF2NSLQHhitzFChyQvhV7rEM?= =?iso-8859-1?Q?c21f3DOPdBa7VsCSMd3RZrDObXiJCe8RV9hY8S7xR4BYhMliBeKnUVwMg6?= =?iso-8859-1?Q?NFC2UaYwzYNAoBeztsMcsOlTGMfgNWBxDLzte34CWzWBybhWxEsw5wIkB1?= =?iso-8859-1?Q?0o/jSmsx0D9SSpd07fLjDh3cU6YXLrQ/vbYA/tSfEMspH6io2ko3+141SK?= =?iso-8859-1?Q?M1FPTiwlRfvSI0+bAmbDfB8unhThVf5ni2UOCuqzw/6JXvWiw8B22/WMQj?= =?iso-8859-1?Q?hrkyouPkiWIUBzcj+N5eO0GFlN8rvTv93uwlTthFSzCaRGFshsl5lXwXI4?= =?iso-8859-1?Q?c9Ku0oP9+ZGUxkEF3F1ObLZ/1zQcljmF+jjHsjImX7vGu62UpxlxPVg0B5?= =?iso-8859-1?Q?IqAtZw5yBo0Ql4tWd9oFE9OKsR1T+xj0DHJwbup6EAgy0qWrtQYTd3T/uj?= =?iso-8859-1?Q?WjE91dDKcG2YlaQNUSYFItA5F8h84m/4/ASxzlthhccwcn8XKOcusGelqG?= =?iso-8859-1?Q?BIDOHzzvkdM/u/d2llJx70dTw1zVAjA1UmgMSwKwzXF3wDpGZ8D6Ahjy2w?= =?iso-8859-1?Q?z1OcXdiyirk1RC0k9UM4gyvoK8TepHCXQk+fRI4BV+LE1v/hTyLG7kpswi?= =?iso-8859-1?Q?L80r2XAJ/ER3s98XaYDZxbJyGYyq/WtkJ3kHJOWTgS3lEuqMyPpXRtfuVC?= =?iso-8859-1?Q?NvtXo3kmAmGZGEg0VsAizb57USIRE4dVogx1cfy5Hbp+FWu+1JvoSOORt/?= =?iso-8859-1?Q?8Uo3Vk5mTM1eFLJu2TJ2YYbNTrc+DFuhZUlEuI8NAjT36OcQs1KRjTpTyk?= =?iso-8859-1?Q?ThDETomTBO+XZ5UXvgs5GqN19I4/kiATrICdIaxY/v+XWLB2vLFcxvlYD4?= =?iso-8859-1?Q?77aBN+eMwPNH9YZ7GcBaW3Q=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: YQXPR0101MB0968.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 815e41b4-7d2d-4b50-c058-08d89ec3fc47 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Dec 2020 17:33:06.0337 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1IoQCdLb+pneTiElapy9n+PkmwxYFx2EaoH8inQEvUTeom4PP1lRSUAGNi9kLypLvHywFh0kTRsUvaOrAM5UUw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: QB1PR01MB3985 X-Rspamd-Queue-Id: 4CtZW126XKz3hTF X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=uoguelph.ca header.s=selector1 header.b=iKJd7UAf; arc=pass (microsoft.com:s=arcselector9901:i=1); dmarc=pass (policy=none) header.from=uoguelph.ca; spf=pass (mx1.freebsd.org: domain of rmacklem@uoguelph.ca designates 40.107.66.76 as permitted sender) smtp.mailfrom=rmacklem@uoguelph.ca X-Spamd-Result: default: False [-4.00 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:40.107.0.0/16]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[uoguelph.ca:+]; DMARC_POLICY_ALLOW(-0.50)[uoguelph.ca,none]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; RBL_DBL_DONT_QUERY_IPS(0.00)[40.107.66.76:from]; ARC_ALLOW(-1.00)[microsoft.com:s=arcselector9901:i=1]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:8075, ipnet:40.104.0.0/14, country:US]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[uoguelph.ca:s=selector1]; FREEFALL_USER(0.00)[rmacklem]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DWL_DNSWL_LOW(-1.00)[uoguelph.ca:dkim]; SPAMHAUS_ZRD(0.00)[40.107.66.76:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; NEURAL_SPAM_LONG(1.00)[1.000]; RCVD_IN_DNSWL_NONE(0.00)[40.107.66.76:from]; RWL_MAILSPIKE_POSSIBLE(0.00)[40.107.66.76:from]; FREEMAIL_CC(0.00)[gmail.com,freebsd.org]; MAILMAN_DEST(0.00)[freebsd-fs] X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Dec 2020 17:33:18 -0000 Konstantin Belousov wrote:=0A= [stuff snipped]=0A= >Nullfs vnodes keep a reference on the lower vnode. When nullfs vnode=0A= >caching is enabled, nullfs vnodes survive after a vfs syscall is finished.= =0A= >=0A= >NFSv4 mount automatically sets flag MNTK_NULL_NOCACHE that disables nullfs= =0A= >vnode cache.=0A= Thanks Kostik, I see that. (And I recall discussions about disabling the nu= llfs caching.)=0A= =0A= Now, if I understand it correctly, if vrele() is called with the vnode shar= ed locked,=0A= then VOP_INACTIVE() won't be called.=0A= --> It is VOP_INACTIVE()/VOP_RECLAIM() in the NFSv4 client that does the cl= oses.=0A= Normally the NFS client calls vput() when the vnode is locked, but is there= a case=0A= where nullfs might cause vrele() to be called on the lower vp when it is sh= ared=0A= locked? (Delaying closes until VOP_RECLAIM() would cause problems, I think?= )=0A= =0A= Note that, until we see the "nfsstat -c -E" we won't know if lots of opens= =0A= are an issue anyhow.=0A= =0A= Thanks for the help, rick=0A= =0A=