From owner-cvs-all@FreeBSD.ORG Mon May 26 21:01:22 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CE0E237B401; Mon, 26 May 2003 21:01:22 -0700 (PDT) Received: from magic.adaptec.com (magic-mail.adaptec.com [208.236.45.100]) by mx1.FreeBSD.org (Postfix) with ESMTP id 08C0443F75; Mon, 26 May 2003 21:01:22 -0700 (PDT) (envelope-from scott_long@btc.adaptec.com) Received: from redfish.adaptec.com (redfish.adaptec.com [162.62.50.11]) by magic.adaptec.com (8.11.6/8.11.6) with ESMTP id h4R3ukZ09284; Mon, 26 May 2003 20:56:46 -0700 Received: from btc.adaptec.com (hollin.btc.adaptec.com [10.100.253.56]) by redfish.adaptec.com (8.8.8p2+Sun/8.8.8) with ESMTP id VAA02770; Mon, 26 May 2003 21:01:14 -0700 (PDT) Message-ID: <3ED2E303.7070304@btc.adaptec.com> Date: Mon, 26 May 2003 22:01:07 -0600 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.3) Gecko/20030425 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Nate Lawson References: <20030526040103.EF60537B401@hub.freebsd.org> <20030526201453.V5016@root.org> In-Reply-To: <20030526201453.V5016@root.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: Scott Long cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/alpha/alpha busdma_machdep.csrc/sys/alpha/include bus.h src/sys/amd64/amd64 busdma_machdep.c src/sys/amd64/include bus_dma.h src/sys/i386/i386 busdma_machdep X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 May 2003 04:01:23 -0000 Nate Lawson wrote: > On Sun, 25 May 2003, Scott Long wrote: > >> Modified files: >> sys/alpha/alpha busdma_machdep.c >> sys/alpha/include bus.h >> sys/amd64/amd64 busdma_machdep.c >> sys/amd64/include bus_dma.h >> sys/i386/i386 busdma_machdep.c >> sys/i386/include bus_dma.h >> sys/sparc64/include bus.h iommuvar.h >> sys/sparc64/pci psycho.c >> sys/sparc64/sbus sbus.c >> sys/sparc64/sparc64 iommu.c >> Log: >> De-orbit bus_dmamem_alloc_size(). It's a hack and was never used anyways. >> No need for it to pollute the 5.x API any further. >> >> Approved by: re (bmah) > > > Do you plan to address this in the future? I believe it was useful for a > few drivers. I seem to recall you mentioning a more general approach for > the future. > > -Nate The better approach is to have bus_dmamap_load() respect the maxsegs field of the tag and coelesce the segments by whatever means it has available to it (bcopy, GART, etc). Note the the bus_dmamem_alloc_size stuff went into the tree in Jan but was never once used. Scott