From owner-cvs-src-old@FreeBSD.ORG Fri Aug 14 10:25:37 2009 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 11395106568C for ; Fri, 14 Aug 2009 10:25:37 +0000 (UTC) (envelope-from julian@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id F35F58FC61 for ; Fri, 14 Aug 2009 10:25:36 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id n7EAPaVk053148 for ; Fri, 14 Aug 2009 10:25:36 GMT (envelope-from julian@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id n7EAPasv053147 for cvs-src-old@freebsd.org; Fri, 14 Aug 2009 10:25:36 GMT (envelope-from julian@repoman.freebsd.org) Message-Id: <200908141025.n7EAPasv053147@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to julian@repoman.freebsd.org using -f From: Julian Elischer Date: Fri, 14 Aug 2009 10:25:14 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: RELENG_8 Subject: cvs commit: src/sys/netinet/ipfw ip_fw2.c X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Aug 2009 10:25:37 -0000 julian 2009-08-14 10:25:14 UTC FreeBSD src repository Modified files: (Branch: RELENG_8) sys/netinet/ipfw ip_fw2.c Log: SVN rev 196202 on 2009-08-14 10:25:14Z by julian MFC of r196201 URL: http://svn.freebsd.org/changeset/base/196201 Fix ipfw crash on uid or gid check. Receiving any ip packet for which there is no existing socket will crash if ipfw has a uid or gid test rule, as the uid/gid of the non existent owner of said non existent socket is tested. Brooks introduced this error as part of his >16 gids patch. It appears to be a cut-n-paste error from similar code a few lines before. The old code used the 'pcb' variable here, but in the new code that switched the 'inp' variable, which is often NULL and what is tested in the code further up. The rest of the multi-gid patch for ipfw seems solid (and cleaner than previous code). p.s. What's up with all the properties changing? It is a fresh checkout. Reviewed by: brooks Approved by: re (rwatson) Revision Changes Path 1.11.2.2 +1 -1 src/sys/netinet/ipfw/ip_fw2.c