From owner-freebsd-current@FreeBSD.ORG Mon Mar 21 18:39:53 2011 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D0BAB106567B for ; Mon, 21 Mar 2011 18:39:53 +0000 (UTC) (envelope-from rdivacky@vlakno.cz) Received: from vlakno.cz (lev.vlakno.cz [77.93.215.190]) by mx1.freebsd.org (Postfix) with ESMTP id 8C1DA8FC12 for ; Mon, 21 Mar 2011 18:39:53 +0000 (UTC) Received: from lev.vlakno.cz (localhost [127.0.0.1]) by vlakno.cz (Postfix) with ESMTP id BA5339CB15F; Mon, 21 Mar 2011 19:21:43 +0100 (CET) X-Virus-Scanned: amavisd-new at vlakno.cz Received: from vlakno.cz ([127.0.0.1]) by lev.vlakno.cz (lev.vlakno.cz [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id E7CR4pyBQFx5; Mon, 21 Mar 2011 19:21:43 +0100 (CET) Received: by vlakno.cz (Postfix, from userid 1076) id 0ED239CB186; Mon, 21 Mar 2011 19:21:43 +0100 (CET) Date: Mon, 21 Mar 2011 19:21:43 +0100 From: Roman Divacky To: Fabian Keil Message-ID: <20110321182142.GA73111@freebsd.org> References: <20110314185943.GA98118@freebsd.org> <20110320204104.2cc0ef74@r500.local> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110320204104.2cc0ef74@r500.local> User-Agent: Mutt/1.4.2.3i Cc: current@freebsd.org Subject: Re: [TESTING]: boot2 compilation with -mregparm=3 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Mar 2011 18:39:53 -0000 On Sun, Mar 20, 2011 at 08:41:04PM +0100, Fabian Keil wrote: > Roman Divacky wrote: > > > This patch: > > > > > > http://lev.vlakno.cz/~rdivacky/boot2-mregparm.patch > > > > > > makes boot2 to be compiled with -mregparm=3 (which shrinks it > > some). It changes CFLAGS to include -mregparm=3 and also > > rewrites sio.S to use register passing. > > > > This survived my testing in qemu and jhb@s review. > > Works for me on amd64 with gcc, but I don't use either > a serial console or gptboot/zfsboot. thank you for testing, although I really need someone to test this on serial console {gpt,zfs}boot it seems to work for me and fail for the other tester so I really dont know what to think roman