Date: Fri, 31 Oct 2003 06:59:33 +1100 From: Peter Jeremy <PeterJeremy@optushome.com.au> To: "M. Warner Losh" <imp@bsdimp.com> Cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libc/rpc clnt_simple.c Message-ID: <20031030195933.GB1649@cirb503493.alcatel.com.au> In-Reply-To: <20031029.223237.01027561.imp@bsdimp.com> References: <200310290918.h9T9IiwQ095857@repoman.freebsd.org> <20031029095700.GU84474@garage.freebsd.pl> <20031029101805.GA24695@falcon.midgard.homeip.net> <20031029.223237.01027561.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Oct 29, 2003 at 10:32:37PM -0700, M. Warner Losh wrote:
>Yes. More correct. For the same reason that
>
> while (foo) {
> ...
> }
>
>is more correct than:
>
>top:
> if (foo) goto out;
> ...
> goto top;
>out:
>
>In that it is the more appropriate construct to use in the context.
>Even though they are both guaranteed to be the same, one is more
>correct than the other.
Just to nit-pick but the two conditional tests are complements. One
needs a '!' to make them the same.
Peter
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20031030195933.GB1649>