From nobody Thu Apr 25 22:11:38 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VQVSp38Ngz5JfY5 for ; Thu, 25 Apr 2024 22:11:54 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-vs1-xe30.google.com (mail-vs1-xe30.google.com [IPv6:2607:f8b0:4864:20::e30]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VQVSp1Ggbz4571 for ; Thu, 25 Apr 2024 22:11:54 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-vs1-xe30.google.com with SMTP id ada2fe7eead31-47a21e0cde6so615703137.0 for ; Thu, 25 Apr 2024 15:11:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1714083112; x=1714687912; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=o7nMoV10V7vDN46T6ZzC0RFPgwEu9BB+wWEhKOtLlz4=; b=Fhhxy5lQ416a0Zj8TA2U+27/G+wAnl/gY3SKf46erpXU9YoIYd2UyTkZ8tUpeh8Hlj N2fk0AwJ5iLKhdhtynes/24OuDTxjKNRc7LbnR0LEkRzKDr9cz6fAesnI1VNZYRXBYZg kpuAY1O8yRe4GSUqGRWZNU71u4vQHrntH9lNYfvSYE6E/oTF2c+g7vtnug8u0T2FKpFQ 3dkwqz8Xvxa3UyDLRxIDQxgT1kY3OOQvxcBN7aY8TxxRwwJN+mAa8pVPIwCTyB85xjP3 7v/1SFWC2wzVckdaiPUWmaU82SMpu+nuU5meaiSQeikUYY6bowjlYlNAhMNeJdP+ozY5 70VQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714083112; x=1714687912; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=o7nMoV10V7vDN46T6ZzC0RFPgwEu9BB+wWEhKOtLlz4=; b=FHOkVI87OuTJOhfHZMhNQxhbSWqyrSf4F+bE7afMaM7C7q0WaO+vs9oLK3hAeVLO5B SMYrqxeEAA3F2hXoC97g8igZqPobyn81+VRCjrUjrpXGhl4A022SCMMW5RMfSa/+LK8K imhUvWBgjFYZDJ/js/4tJocKtfCDlU/7WO188l+o/MLgwt0tKWsHm0hbmFG6CKTVQYef 8STPdJLahzFJrWrHeN1o+XPFAfyUdj3WJLyIcj5HVLEIAWTOMUoSxzdblJ2FpIzj87EK vJc74JcDEEu/ULIfErwpXF+dda1AXLrxG68t0Sm6haL6MwfEJP+/EF3stw8PbYeP2h55 guCA== X-Forwarded-Encrypted: i=1; AJvYcCUUiH7it5n3dISTtRj9bTx8ygHlwmJ0dW2Rt7g/09gPL+XXEpFEdDgBmMjFBl63QFSxP/fpsOqOeieyg8FPdWqO8XE1R+lMDsZgm2PXaAhO X-Gm-Message-State: AOJu0YyG4O8wjc6lNJ0j/TEjFm5Q3vuuQd7UJevJateDcTqlbip243it CFPUpGZI2LJqHF0vzPlTC1ToTZyNSIf81CPONfVNR5Y+GqVMKHlRnjX0V4wRc9Mui8B6TGKpQG6 YmfYvVKKBhPts1pCYal+zDgBRGuOKXsiT+0Te7C1fXtCT44tpybc= X-Google-Smtp-Source: AGHT+IG0kMyhTj9QYrsv6MLNGuss0KFUH92UOj2HRbrMu5tOlX48UET67/U8A3AkzxXsptFDOrug30rcaSnlg49dcB4= X-Received: by 2002:a05:6122:30a6:b0:4d4:3ec6:421e with SMTP id cd38-20020a05612230a600b004d43ec6421emr936581vkb.4.1714083111579; Thu, 25 Apr 2024 15:11:51 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 References: <202404192311.43JNBiVS059729@gitrepo.freebsd.org> <0100018f169ec80a-47d419c2-2cd6-4ee1-89da-3f4782429089-000000@email.amazonses.com> <0100018f16c8f23a-eacbe781-3f6e-4f02-9b4d-d26468364b1f-000000@email.amazonses.com> <7473b5ed-433b-4d51-8a23-cf6464eb4416@FreeBSD.org> <7FA67865-F391-4773-86BA-9998B3EC855E@googlemail.com> <142362e6-8a88-43f5-bff6-6ff90a12802e@FreeBSD.org> In-Reply-To: <142362e6-8a88-43f5-bff6-6ff90a12802e@FreeBSD.org> From: Warner Losh Date: Thu, 25 Apr 2024 16:11:38 -0600 Message-ID: Subject: Re: git: 1bd4f769caf8 - main - add dtb support for RPI CM4, CM4s, CM4_ioBoard To: Kyle Evans Cc: =?UTF-8?Q?Klaus_K=C3=BCchemann?= , Colin Percival , src-committers , "" , "" Content-Type: multipart/alternative; boundary="000000000000fb51510616f312a6" X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4VQVSp1Ggbz4571 --000000000000fb51510616f312a6 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Apr 25, 2024, 4:09=E2=80=AFPM Kyle Evans wrote= : > On 4/25/24 16:44, Klaus K=C3=BCchemann wrote: > > > > > >> Am 25.04.2024 um 22:01 schrieb Kyle Evans : > >> > >> On 4/25/24 14:43, Colin Percival wrote: > >>> On 4/25/24 12:24, Warner Losh wrote: > >>>> On Thu, Apr 25, 2024, 12:57=E2=80=AFPM Colin Percival >>>> > wrote: > >>>> On 4/19/24 16:11, Warner Losh wrote: > >>>> > add dtb support for RPI CM4, CM4s, CM4_ioBoard > >>>> > > >>>> > Signed-off-by: Klaus K=C3=BCchemann >>>> > > >>>> > Reviewed by: imp > >>>> > Pull Request: > >>>> https://github.com/freebsd/freebsd-src/pull/1182 > >>>> > >>>> > --- > >>>> > --- a/release/arm64/RPI.conf > >>>> > +++ b/release/arm64/RPI.conf > >>>> > -DTB=3D"bcm2710-rpi-2-b.dtb bcm2710-rpi-3-b.dtb > >>>> bcm2710-rpi-3-b-plus.dtb > >>>> bcm2710-rpi-cm3.dtb bcm2711-rpi-4-b.dtb" > >>>> > +DTB=3D"bcm2710-rpi-2-b.dtb bcm2710-rpi-3-b.dtb > >>>> bcm2710-rpi-3-b-plus.dtb > >>>> bcm2710-rpi-cm3.dtb \ > >>>> > + bcm2711-rpi-4-b.dtb bcm2711-rpi-cm4-io.dtb > >>>> bcm2711-rpi-cm4.dtb > >>>> bcm2711-rpi-cm4s.dtb" > >>>> > >>>> This broke the RPI release build, since bcm2711-rpi-cm4s.dtb > >>>> doesn't exist. > >>>> Is it provided by a port which we should add to the RPI build? > >>>> > >>>> I thought it was in tree. I'll look into this and report back. > >>> Entirely possible. The release-building code is trying to copy it fr= om > >>> /usr/local/share/rpi-firmware/bcm2711-rpi-cm4s.dtb > >>> so if it's somewhere else we need to adjust that code. > >> > >> The rpi-firmware port is supposed to provide all .dtb used here, but > >> we've never installed that one. It really shouldn't have been > >> included in the list to begin with, but I guess if there's demand we > >> should fix the port to include it. > >> > >> Thanks, > >> > >> Kyle Evans > > > > we only have tested/fixed the CM4-model, not forceably need the > > cm4s.dtb , so no objections to remove cm4s.dtb from the dtb-list at > > least temporarily. > > > > But please hold cm4.dtb and the cm4_io_.dtb, which will then hopefully > > not break the rpi-release anymore. > > > > I'm going to go ahead and remove just the rpi-cm4s.dtb, feel free to > update the port (sysutils/rpi-firmware) to grab it then try again once > new packages are available with it so that we don't break the snapshot > again from the same file. > Thanks. Warner Thanks, > > Kyle Evans > --000000000000fb51510616f312a6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Thu, Apr 25, 2024, 4:09=E2=80=AFPM Kyle Evans <<= a href=3D"mailto:kevans@freebsd.org">kevans@freebsd.org> wrote:
<= /div>
On 4/25/24 16:44, Klaus K=C3=BCchemann = wrote:
>
>
>> Am 25.04.2024 um 22:01 schrieb Kyle Evans <kevans@FreeBSD.org&g= t;:
>>
>> On 4/25/24 14:43, Colin Percival wrote:
>>> On 4/25/24 12:24, Warner Losh wrote:
>>>> On Thu, Apr 25, 2024, 12:57=E2=80=AFPM Colin Percival <= cperciva@tarsnap.com
>>>> <mailto:cperciva@tarsnap.com>> wrote:
>>>> =C2=A0=C2=A0=C2=A0 On 4/19/24 16:11, Warner Losh wrote: >>>> =C2=A0=C2=A0=C2=A0=C2=A0 >=C2=A0 =C2=A0 =C2=A0 add dtb = support for RPI CM4, CM4s, CM4_ioBoard
>>>> =C2=A0=C2=A0=C2=A0=C2=A0 >
>>>> =C2=A0=C2=A0=C2=A0=C2=A0 >=C2=A0 =C2=A0 =C2=A0 Signed-o= ff-by: Klaus K=C3=BCchemann <maciphone2@googlemail.com
>>>> =C2=A0=C2=A0=C2=A0 <mailto:maciphone2@googlemail= .com>>
>>>> =C2=A0=C2=A0=C2=A0=C2=A0 >=C2=A0 =C2=A0 =C2=A0 Reviewed= by: imp
>>>> =C2=A0=C2=A0=C2=A0=C2=A0 >=C2=A0 =C2=A0 =C2=A0 Pull Req= uest:
>>>> https://github.com/freeb= sd/freebsd-src/pull/1182
>>>> =C2=A0=C2=A0=C2=A0 <h= ttps://github.com/freebsd/freebsd-src/pull/1182>
>>>> =C2=A0=C2=A0=C2=A0=C2=A0 > ---
>>>> =C2=A0=C2=A0=C2=A0=C2=A0 > --- a/release/arm64/RPI.conf=
>>>> =C2=A0=C2=A0=C2=A0=C2=A0 > +++ b/release/arm64/RPI.conf=
>>>> =C2=A0=C2=A0=C2=A0=C2=A0 > -DTB=3D"bcm2710-rpi-2-b= .dtb bcm2710-rpi-3-b.dtb
>>>> bcm2710-rpi-3-b-plus.dtb
>>>> =C2=A0=C2=A0=C2=A0 bcm2710-rpi-cm3.dtb bcm2711-rpi-4-b.dtb= "
>>>> =C2=A0=C2=A0=C2=A0=C2=A0 > +DTB=3D"bcm2710-rpi-2-b= .dtb bcm2710-rpi-3-b.dtb
>>>> bcm2710-rpi-3-b-plus.dtb
>>>> =C2=A0=C2=A0=C2=A0 bcm2710-rpi-cm3.dtb \
>>>> =C2=A0=C2=A0=C2=A0=C2=A0 > +=C2=A0 =C2=A0 =C2=A0bcm2711= -rpi-4-b.dtb bcm2711-rpi-cm4-io.dtb
>>>> bcm2711-rpi-cm4.dtb
>>>> =C2=A0=C2=A0=C2=A0 bcm2711-rpi-cm4s.dtb"
>>>>
>>>> =C2=A0=C2=A0=C2=A0 This broke the RPI release build, since= bcm2711-rpi-cm4s.dtb
>>>> doesn't exist.
>>>> =C2=A0=C2=A0=C2=A0 Is it provided by a port which we shoul= d add to the RPI build?
>>>>
>>>> I thought it was in tree. I'll look into this and repo= rt back.
>>> Entirely possible.=C2=A0 The release-building code is trying t= o copy it from
>>> /usr/local/share/rpi-firmware/bcm2711-rpi-cm4s.dtb
>>> so if it's somewhere else we need to adjust that code.
>>
>> The rpi-firmware port is supposed to provide all .dtb used here, b= ut
>> we've never installed that one.=C2=A0 It really shouldn't = have been
>> included in the list to begin with, but I guess if there's dem= and we
>> should fix the port to include it.
>>
>> Thanks,
>>
>> Kyle Evans
>
> we only have tested/fixed the CM4-model, =C2=A0not forceably need the =
> cm4s.dtb , so no objections to remove cm4s.dtb from the dtb-list at > least temporarily.
>
> But please hold cm4.dtb and the cm4_io_.dtb, which will then hopefully=
> not break the rpi-release anymore.
>

I'm going to go ahead and remove just the rpi-cm4s.dtb, feel free to update the port (sysutils/rpi-firmware) to grab it then try again once
new packages are available with it so that we don't break the snapshot =
again from the same file.
Thanks.

Warner=C2=A0

<= div class=3D"gmail_quote">
Thanks,

Kyle Evans
--000000000000fb51510616f312a6--