From nobody Tue Jun 9 14:09:42 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gZW4l1l1Nz6g3Gc for ; Tue, 09 Jun 2026 14:09:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gZW4k6dD4z3tpD for ; Tue, 09 Jun 2026 14:09:42 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1781014182; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ixH9PMi++iMgDF5rC3Hs7C98vi811JPHHjq1HBqixFc=; b=sTao4wCiMb/hq3/gcge867SLoZNB5uNq9s0nGulKptsJtQT2CXzE976+NZBd7tEXbsOEEM QyTIahYoG6xdpSRudAX5xlwLMECd0wDaU+9k+sSHfKMf1tlxC5Yp3ipAfZvU/hV5maD2pB izisqgva99rWc9fJm1yasKiQOJ1vgW5Z1gco8MVGunhSgLUNIo8AIvWixg6FLaT8NmQZ2i IuGNy8SP7o9MYBuSajIvt9FXUlRCfG2FSwgzJiDPetICTOh5xMcWoPq0Y9gW0IdY16EOeA 4wggTAPoebkXeQUeb0TrLnbL0UTpAxTScgt0+/jJ2gxFPoeCPsWiGpoDke+YlQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1781014182; a=rsa-sha256; cv=none; b=wrkxyOBxms9syJuiksLCLFFvmP6cCGwouHFgwnD7trdJtqtH0SSos+l3nCS2FL8OCvkSAb K/GZouftU1ErjkrE+JljljR9nCrLpFXxdRPiyEAIb3ulPR1suXhMT7rJh2hvmPSq7aMJpC sSKrhsHYJiFDkpiNIWsbo9C7SjI7wnbV111kr5upoDbLFAazjgtabrrKZDxQ/oDWrNkjAq cNQ14KGq2tpzQ+kaYyU5CEGHXj6QAu9RLy9AWhvUe4DRmuhKjnty4fpa7U/jmLiIFnIYTJ ojHu/AJBMlyIp91BalndHEuwo360OyVrQO+cQDoLm9JN7MRQciyI26N01ZK2MA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1781014182; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ixH9PMi++iMgDF5rC3Hs7C98vi811JPHHjq1HBqixFc=; b=WImC6VUD0ywndUEYt83a31iTgDAA5BIES7P0JsWQfQGPhyF6RYt45JcFT9DCYuuiOFGykj r+nF9q6gzx49t02digsLL/8U8jDeooL9OE9v2+5IFvckRtuzLp8t8A4VnLEJS6Rlu4A5Cj PMdQInjPfNWnZmY/gIgYxri5rNokEPc9AEfJs7n9TFLC/5tdvAn5GIxveQOTlKgq7lMTqJ pop45qTWAryMru2cHZMWeYTt1pTtse4o26zATEEWnCi14+8PLuWmVOEsddb37+kddbWaNo XpEKtURgdpkAciYnMDS4N7Tko211+u6CUT1OJX+e/ZfmsNCHqfVK5qjh/Bi7qA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gZW4k6Dp8zdrL for ; Tue, 09 Jun 2026 14:09:42 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 45273 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 09 Jun 2026 14:09:42 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Ed Maste Subject: git: 6c81e7622211 - stable/15 - netlink: Avoid potential undefined behaviour List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: emaste X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 6c81e7622211bbe2928fd45422fa55ecfbba8f1b Auto-Submitted: auto-generated Date: Tue, 09 Jun 2026 14:09:42 +0000 Message-Id: <6a281ea6.45273.3fdebcfa@gitrepo.freebsd.org> The branch stable/15 has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=6c81e7622211bbe2928fd45422fa55ecfbba8f1b commit 6c81e7622211bbe2928fd45422fa55ecfbba8f1b Author: Ed Maste AuthorDate: 2026-05-22 14:55:49 +0000 Commit: Ed Maste CommitDate: 2026-06-09 13:40:29 +0000 netlink: Avoid potential undefined behaviour Taking the address of an OOB array element is UB, even if not dereferenced. Reviewed by: des, bz Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D57172 (cherry picked from commit 4d125ed6e7d445d574c11dc35c40ec3013559806) --- sys/netlink/netlink_generic.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/sys/netlink/netlink_generic.c b/sys/netlink/netlink_generic.c index c2f82eed5656..50c12175e14e 100644 --- a/sys/netlink/netlink_generic.c +++ b/sys/netlink/netlink_generic.c @@ -93,12 +93,10 @@ static struct genl_group { static inline struct genl_family * genl_family(uint16_t family_id) { - struct genl_family *gf; - - gf = &families[family_id - GENL_MIN_ID]; KASSERT(family_id - GENL_MIN_ID < MAX_FAMILIES && - gf->family_name != NULL, ("family %u does not exist", family_id)); - return (gf); + families[family_id - GENL_MIN_ID].family_name != NULL, + ("family %u does not exist", family_id)); + return (&families[family_id - GENL_MIN_ID]); } static inline uint16_t