Date: Mon, 20 Apr 2009 08:08:12 GMT From: Panagiotis Christias <p.christias@noc.ntua.gr> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/133866: [patch] www/squid: take into account of squid_chdir when defining squid_pidfile Message-ID: <200904200808.n3K88COQ039278@www.freebsd.org> Resent-Message-ID: <200904200810.n3K8A2vK088408@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 133866
>Category: ports
>Synopsis: [patch] www/squid: take into account of squid_chdir when defining squid_pidfile
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Mon Apr 20 08:10:02 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator: Panagiotis Christias
>Release: 7.1-RELEASE amd64
>Organization:
National Technical University of Athens
>Environment:
FreeBSD diomedes.noc.ntua.gr 7.1-RELEASE FreeBSD 7.1-RELEASE #0: Thu Jan 1 08:58:24 UTC 2009 root@driscoll.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC amd64
>Description:
squid_pidfile definition does not take into account of squid_chdir.
>How-To-Repeat:
Define in /etc/rc.conf:
squid_enable="YES"
squid_chdir="/var/log/squid"
Start squid:
# /usr/local/etc/rc.d/squid start
Starting squid.
Query squid status:
# /usr/local/etc/rc.d/squid status
squid is not running.
Try to stop squid:
# /usr/local/etc/rc.d/squid stop
Stopping squid.
11:03am /usr/local/etc/rc.d # ps -auxww | egrep squid
squid 91413 0.0 0.1 8948 2148 ?? Is 10:29AM 0:00.00 /usr/local/sbin/squid -D
squid 91415 0.0 0.3 17140 6268 ?? S 10:29AM 0:00.23 (squid) -D (squid)
squid 91416 0.0 0.0 2560 668 ?? Is 10:29AM 0:00.00 (unlinkd) (unlinkd)
root 94458 0.0 0.1 7884 1316 p1 S+ 11:03AM 0:00.00 egrep squid
>Fix:
See attached patch:
Patch attached with submission follows:
*** ports/www/squid/files/squid.in.orig 2007-08-14 05:32:11.000000000 +0300
--- ports/www/squid/files/squid.in 2009-04-20 10:34:19.000000000 +0300
***************
*** 40,46 ****
squid_chdir=${squid_chdir:-"%%PREFIX%%/squid/logs"}
squid_enable=${squid_enable:-"NO"}
squid_flags=${squid_flags-"-D"}
! squid_pidfile=${squid_pidfile:-"%%PREFIX%%/squid/logs/squid.pid"}
squid_user=${squid_user:-%%SQUID_UID%%}
default_config=%%PREFIX%%/etc/squid/squid.conf
--- 40,46 ----
squid_chdir=${squid_chdir:-"%%PREFIX%%/squid/logs"}
squid_enable=${squid_enable:-"NO"}
squid_flags=${squid_flags-"-D"}
! squid_pidfile=${squid_pidfile:-"${squid_chdir}/squid.pid"}
squid_user=${squid_user:-%%SQUID_UID%%}
default_config=%%PREFIX%%/etc/squid/squid.conf
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200904200808.n3K88COQ039278>