From owner-freebsd-current@FreeBSD.ORG Thu Aug 19 14:53:14 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C96FE16A4CE for ; Thu, 19 Aug 2004 14:53:14 +0000 (GMT) Received: from mail6.speakeasy.net (mail6.speakeasy.net [216.254.0.206]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9066643D49 for ; Thu, 19 Aug 2004 14:53:14 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 24785 invoked from network); 19 Aug 2004 14:53:14 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 19 Aug 2004 14:53:13 -0000 Received: from [10.50.40.208] (gw1.twc.weather.com [216.133.140.1]) (authenticated bits=0) by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id i7JEr99B055336; Thu, 19 Aug 2004 10:53:10 -0400 (EDT) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Maxim Sobolev Date: Thu, 19 Aug 2004 10:53:05 -0400 User-Agent: KMail/1.6.2 References: <4124B473.9070004@portaone.com> In-Reply-To: <4124B473.9070004@portaone.com> MIME-Version: 1.0 Content-Disposition: inline Message-Id: <200408191053.05776.jhb@FreeBSD.org> Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: current@FreeBSD.org Subject: Re: Extending cdboot with options "Press any key to boot from CD" prompt X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Aug 2004 14:53:14 -0000 On Thursday 19 August 2004 10:08 am, Maxim Sobolev wrote: > Hi, > > Please review/comment on attached patch, which extends cdboot with > "Press any key to boot from CD" prompt inspired by Windows installation > CDs. IMHO this feature is quite useful for installation CDs, and > probably for other interactive one-shot CDs, to prevent machine from > booting off CD again after work is complete. If there is no objections, > I'd like to request repo copy from cdboot.s into cdboot.S and then > commit this change. My plan is to keep this feature turned off by > default, and provide make(1) knob to turn it one if necessary. > > Thanks! > > -Maxim Only thing I would change is to not use suffixes when they aren't necessary since that is the style of the rest of the file. That is, use 'xor %ah,%ah' rather than 'xorb %ah,%ah'. as(1) doesn't need them and the code is easier to read when the mnemnomics are less jagged. Also, if you wanted to get extra cute you would output a '.' each second during the countdown like Windows does. :) -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org