From owner-svn-src-all@freebsd.org Wed Jan 8 09:29:11 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id EE7F01E887B; Wed, 8 Jan 2020 09:29:11 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 47t3pv4zr5z4H13; Wed, 8 Jan 2020 09:29:11 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id 0089Suks040892 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 8 Jan 2020 11:28:59 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 0089Suks040892 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id 0089SuJY040891; Wed, 8 Jan 2020 11:28:56 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Wed, 8 Jan 2020 11:28:56 +0200 From: Konstantin Belousov To: Alexander Motin Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r356480 - head/sys/dev/nvme Message-ID: <20200108092856.GW23031@kib.kiev.ua> References: <202001072310.007NAdmV011346@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202001072310.007NAdmV011346@repo.freebsd.org> X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.3 X-Spam-Checker-Version: SpamAssassin 3.4.3 (2019-12-06) on tom.home X-Rspamd-Queue-Id: 47t3pv4zr5z4H13 X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.996,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jan 2020 09:29:12 -0000 On Tue, Jan 07, 2020 at 11:10:39PM +0000, Alexander Motin wrote: > Author: mav > Date: Tue Jan 7 23:10:38 2020 > New Revision: 356480 > URL: https://svnweb.freebsd.org/changeset/base/356480 > > Log: > Increate HMB limit from 1% to 5%. > > SSD capacity in laptops is growing faster then RAM size, so my original > guess seems too low on second thought. Hopefully nobody will build large > array of those crappy SSDs. It seems that this should be a knob. > > MFC after: 2 weeks > X-MFC-with: 356474 > > Modified: > head/sys/dev/nvme/nvme_ctrlr.c > > Modified: head/sys/dev/nvme/nvme_ctrlr.c > ============================================================================== > --- head/sys/dev/nvme/nvme_ctrlr.c Tue Jan 7 22:45:02 2020 (r356479) > +++ head/sys/dev/nvme/nvme_ctrlr.c Tue Jan 7 23:10:38 2020 (r356480) > @@ -881,8 +881,8 @@ nvme_ctrlr_hmb_alloc(struct nvme_controller *ctrlr) > int err, i; > uint64_t max; > > - /* Limit HMB to 1% of RAM size per device by default. */ > - max = (uint64_t)physmem * PAGE_SIZE / 100; > + /* Limit HMB to 5% of RAM size per device by default. */ > + max = (uint64_t)physmem * PAGE_SIZE / 20; > TUNABLE_UINT64_FETCH("hw.nvme.hmb_max", &max); > > min = (long long unsigned)ctrlr->cdata.hmmin * 4096;