Date: Thu, 7 Nov 2024 11:59:18 -0800 From: Warner Losh <imp@bsdimp.com> To: Alexander Leidinger <Alexander@leidinger.net> Cc: Current FreeBSD <freebsd-current@freebsd.org> Subject: Re: No valid device tree blob found! Message-ID: <CANCZdfq%2BUuP7Ya69jz5jnoBB1Cg2Y-sHq1g%2BixsmEvjU7cSipA@mail.gmail.com> In-Reply-To: <a007694a811d1daa48703236b3eba007@Leidinger.net> References: <8cf9adb0e7ca6340460c695ffd64a0df@Leidinger.net> <896b9ce404ffcb126dcdd6008583b117@Leidinger.net> <CANCZdfr4qGgyt=fN4%2BJiFytthjseNo_2B0LVXHZNH93Y3vqEVg@mail.gmail.com> <a007694a811d1daa48703236b3eba007@Leidinger.net>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Wed, Nov 6, 2024 at 3:41 AM Alexander Leidinger <Alexander@leidinger.net> wrote: > Am 2024-11-02 17:08, schrieb Warner Losh: > > > > On Sat, Nov 2, 2024, 10:03 AM Alexander Leidinger <Alexander@leidinger.net> > wrote: > > Am 2024-10-30 22:11, schrieb Alexander Leidinger: > > > WARNING! Trying to fire up the kernel, but no device tree blob found! > > For anyone interested, I opened > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=282493 for this. > > > Yea. This is a hang or a bad console. The warning is lame and misleading. > > Can you bisect? > > Found it. > > # git bisect bad > c87b3f0006be9ac5813f1ff636f18c9b4a41b08e is the first bad commit > commit c87b3f0006be9ac5813f1ff636f18c9b4a41b08e (HEAD) > Author: Warner Losh <imp@FreeBSD.org> > Date: Mon Oct 14 15:58:10 2024 -0600 > > uart: uart_getenv: check for NULL class last, not first > > This allows one to specify dt:XXXX when the default class isn't > compiled > into the kernel. It's not an error to not have a class until we're done > parsing the spec, so defer checking until then. > > Sponsored by: Netflix > Reviewed by: adrian, andrew, markj > Differential Revision: https://reviews.freebsd.org/D47078 > > sys/dev/uart/uart_subr.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > -current as of today without this change boots just fine on the Ampere > system in the Oracle cloud. > what's your loader.conf? this should only matter if something is set there... Warner [-- Attachment #2 --] <div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Nov 6, 2024 at 3:41 AM Alexander Leidinger <<a href="mailto:Alexander@leidinger.net">Alexander@leidinger.net</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div style="font-size:10pt;font-family:Verdana,Geneva,sans-serif"> <div style="font-size:10pt;font-family:Verdana,Geneva,sans-serif"> <p id="m_33128641647853291v1reply-intro">Am 2024-11-02 17:08, schrieb Warner Losh:</p> <blockquote type="cite" style="padding:0px 0.4em;border-left:2px solid rgb(16,16,255);margin:0px"> <div id="m_33128641647853291v1replybody1"> <div dir="auto"> <div><br><br> <div> <div dir="ltr">On Sat, Nov 2, 2024, 10:03 AM Alexander Leidinger <<a href="mailto:Alexander@leidinger.net" rel="noreferrer" target="_blank">Alexander@leidinger.net</a>> wrote:</div> <blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Am 2024-10-30 22:11, schrieb Alexander Leidinger:<br><br>> WARNING! Trying to fire up the kernel, but no device tree blob found!<br><br>For anyone interested, I opened <br><a href="https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=282493" rel="noopener noreferrer" target="_blank">https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=282493</a> for this.</blockquote> </div> </div> <div dir="auto"> </div> <div dir="auto">Yea. This is a hang or a bad console. The warning is lame and misleading.</div> <div dir="auto"> </div> <div dir="auto">Can you bisect?</div> </div> </div> </blockquote> <p>Found it.</p> <p style="padding-left:40px"># git bisect bad<br>c87b3f0006be9ac5813f1ff636f18c9b4a41b08e is the first bad commit<br>commit c87b3f0006be9ac5813f1ff636f18c9b4a41b08e (HEAD)<br>Author: Warner Losh <imp@FreeBSD.org><br>Date: Mon Oct 14 15:58:10 2024 -0600</p> <p style="padding-left:40px"> uart: uart_getenv: check for NULL class last, not first</p> <p style="padding-left:40px"> This allows one to specify dt:XXXX when the default class isn't compiled<br> into the kernel. It's not an error to not have a class until we're done<br> parsing the spec, so defer checking until then.</p> <p style="padding-left:40px"> Sponsored by: Netflix<br> Reviewed by: adrian, andrew, markj<br> Differential Revision: <a href="https://reviews.freebsd.org/D47078" target="_blank">https://reviews.freebsd.org/D47078</a></p> <p style="padding-left:40px"> sys/dev/uart/uart_subr.c | 14 +++++++-------<br> 1 file changed, 7 insertions(+), 7 deletions(-)</p> <p>-current as of today without this change boots just fine on the Ampere system in the Oracle cloud.</p></div></div></blockquote><div><br></div><div>what's your loader.conf? this should only matter if something is set there... </div><div><br></div><div>Warner </div></div></div>help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfq%2BUuP7Ya69jz5jnoBB1Cg2Y-sHq1g%2BixsmEvjU7cSipA>
