From owner-freebsd-ports-bugs@freebsd.org Sat Apr 20 14:35:06 2019 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C6667158F284 for ; Sat, 20 Apr 2019 14:35:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 57B2393071 for ; Sat, 20 Apr 2019 14:35:06 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id 14BA8158F283; Sat, 20 Apr 2019 14:35:06 +0000 (UTC) Delivered-To: ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E66E4158F282 for ; Sat, 20 Apr 2019 14:35:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 769BD9306E for ; Sat, 20 Apr 2019 14:35:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 9DFAD65CE for ; Sat, 20 Apr 2019 14:35:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x3KEZ44v042978 for ; Sat, 20 Apr 2019 14:35:04 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x3KEZ4Jv042977 for ports-bugs@FreeBSD.org; Sat, 20 Apr 2019 14:35:04 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 233319] net-mgmt/unbound_exporter: Update port to latest commit of unbound_exporter Date: Sat, 20 Apr 2019 14:35:03 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: koobs@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback+ X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Apr 2019 14:35:07 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D233319 --- Comment #11 from Kubilay Kocak --- Aside from confirmation of QA (portlint / poudriere), it's likely to be just waiting for someone with Go/golang experience to review/test before committ= ing. FWIW, the patch as supplied doesn't apply as is. Having said that, ive made= the changes to the port manually, and will run through QA. If it passes I'll co= mmit it as is. For example, as is, the port fails portlint with: =3D=3D=3D> Validating port with portlint WARN: Makefile: [39]: possible direct use of command "echo" found. use ${ECHO_CMD} or ${ECHO_MSG} instead. FATAL: Makefile: DISTVERSIONPREFIX appears out-of-order. FATAL: Makefile: order must be PORTNAME/PORTVERSION/DISTVERSIONPREFIX/DISTVERSION/DISTVERSIONSUFFIX/PORTRE= VISION/PORTEPOCH/CATEGORIES/MASTER_SITES/MASTER_SITE_SUBDIR/PROJECTHOST/PKG= NAMEPREFIX/PKGNAMESUFFIX/DISTNAME/EXTRACT_SUFX/DISTFILES/DIST_SUBDIR/EXTRAC= T_ONLY. 2 fatal errors and 1 warning found. For future issues, it's really important as a maintainer to run a port thro= ugh as much QA as possible, at the very least portlint and poudriere, and confi= rm that the port passes QA when submitting the changes. Doing so picks up many issues before submission that can prevent an issue from progressing quickly. Also, regarding the PORTVERSION, it would be great to see upstream start to= use Git tags to tag proper version numbers (x.y.z), so that this port can use t= hose tags, instead of git tags directly to fetch the code, and reference in PORTVERSION --=20 You are receiving this mail because: You are the assignee for the bug.=