Date: Fri, 7 May 2010 16:23:51 +0200 (CEST) From: Guido Falsi <mad@madpilot.net> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/146376: [PATCH] www/apache: fails to start with mod_auth_digest after last commit Message-ID: <20100507142352.023E31C52@megatron.madpilot.net> Resent-Message-ID: <201005071430.o47EU471041947@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 146376
>Category: ports
>Synopsis: [PATCH] www/apache: fails to start with mod_auth_digest after last commit
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Fri May 07 14:30:04 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator: Guido Falsi
>Release: FreeBSD 8.0-STABLE amd64
>Organization:
none
>Environment:
System: FreeBSD megatron.madpilot.net 8.0-STABLE FreeBSD 8.0-STABLE #13: Sat Apr 24 17:35:12 CEST 2010 root@megatron.madpilot.net:/usr/obj/usr/src/sys/MEGATRON amd64
>Description:
After this morning's commits apache was dieing on startup with the following errors in it's log:
[Fri May 07 12:53:55 2010] [notice] Digest: generating secret for digest authentication ...
[Fri May 07 12:53:55 2010] [crit] (2)No such file or directory: Digest: error generating secret: No such file or directory
Configuration Failed
due to a failed connect() from the apr port.
The problem appears also when using included apr.
This affect only people using mod_auth_digest.
After some search I found out that apr enables and prefers egd when any configure options references it (so both --with-egd and --without-egd DO enable it), so ignoring /dev/random.
I noticed also that the apr code conditionally includes egd support XOR /dev/random support (never both).
I assume it is, then, safe to remove any reference to egd in our ports.
AFAIK we do not have egd on FreebSD, and anyway do provide a decent /dev/random, which I think is to be preferred anyway.
>How-To-Repeat:
install apache, enable mod_auth_digest and try to start apache.
>Fix:
diff -ruN ports.old/devel/apr/Makefile ports/devel/apr/Makefile
--- ports.old/devel/apr/Makefile 2010-05-07 16:02:50.589568957 +0200
+++ ports/devel/apr/Makefile 2010-05-07 16:03:35.179196696 +0200
@@ -27,7 +27,6 @@
NDBM "Enable NDBM support in apr-util" off \
PGSQL "Enable Postgresql suport in apr-util" off \
SQLITE "Enable SQLite3 support in apr-util" off \
- EGD "Use EGD compatible sockets in apr" off \
DEVRANDOM "Use /dev/random or compatible in apr" off
APR_VERSION= 1.4.2
@@ -80,17 +79,6 @@
.endif
.endif
-.if defined(WITHOUT_EGD)
-APR_CONF_ARGS+= --without-egd
-.else
-APR_CONF_ARGS+= --with-egd
-.if defined(PKGNAMESUFFIX)
-PKGNAMESUFFIX:= ${PKGNAMESUFFIX}-egd
-.else
-PKGNAMESUFFIX= -egd
-.endif
-.endif
-
.if defined(WITHOUT_DEVRANDOM)
APR_CONF_ARGS+= --without-devrandom
.else
diff -ruN ports.old/www/apache22/Makefile ports/www/apache22/Makefile
--- ports.old/www/apache22/Makefile 2010-05-07 16:02:18.011646821 +0200
+++ ports/www/apache22/Makefile 2010-05-07 16:03:17.438280295 +0200
@@ -171,12 +171,8 @@
.endif
.if defined(WITH_AUTH_DIGEST)
-WITH_EGD= yes
WITH_DEVRANDOM= yes
.endif
-.if defined(WITH_EGD)
-CONFIGURE_ARGS+= --with-egd
-.endif
.if defined(WITH_DEVRANDOM)
CONFIGURE_ARGS+= --with-devrandom
.endif
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100507142352.023E31C52>