From owner-freebsd-current@FreeBSD.ORG Fri Feb 20 17:20:20 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from green.homeunix.org (freefall.freebsd.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 70A3916A4CE; Fri, 20 Feb 2004 17:20:20 -0800 (PST) Received: from green.homeunix.org (green@localhost [127.0.0.1]) by green.homeunix.org (8.12.10/8.12.9) with ESMTP id i1L1KIHS014662; Fri, 20 Feb 2004 20:20:19 -0500 (EST) (envelope-from green@green.homeunix.org) Received: from localhost (green@localhost)i1L1KIWH014659; Fri, 20 Feb 2004 20:20:18 -0500 (EST) Message-Id: <200402210120.i1L1KIWH014659@green.homeunix.org> X-Mailer: exmh version 2.6.3 04/04/2003 with nmh-1.0.4 To: Daniel Eischen In-Reply-To: Message from Daniel Eischen From: "Brian F. Feldman" Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Fri, 20 Feb 2004 20:20:18 -0500 Sender: green@green.homeunix.org cc: current@FreeBSD.org Subject: Re: Testers wanted: reentrant resolver X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Feb 2004 01:20:20 -0000 Daniel Eischen wrote: > > Other APIs have the option of failing. __h_errno() does not have the option > > of failing, so what do I do if pthread_key_create() fails? Also, if > > malloc() fails each time pthread_getspecific() returns NULL for the thread? > > The API isn't thread-safe by design, so if malloc() fails, > just use the global errno. A better design would be to > add the thread-safe interfaces I mention above, and have > the non-thread-safe interfaces first do the pthread_once(), > pthread_[gs]etspecific() thing and then call the thread-safe > interfaces. Since the malloc() will be the first thing > in the entry point, you can fail right away: Ok, just had a "good idea". Since h_errno belongs to the resolver, too, why don't I just implement __h_errno() inside res_init.c and make the storage come from the same place the per-thread struct _res {} storage comes from? That should make you happy, and it makes me happy because it doesn't add an "extra" failure point. -- Brian Fundakowski Feldman \'[ FreeBSD ]''''''''''\ <> green@FreeBSD.org \ The Power to Serve! \ Opinions expressed are my own. \,,,,,,,,,,,,,,,,,,,,,,\