From owner-freebsd-current@FreeBSD.ORG  Thu Jun 24 19:26:56 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 6AD0616A4CE
	for <current@freebsd.org>; Thu, 24 Jun 2004 19:26:56 +0000 (GMT)
Received: from brain.otenet.gr (brain.otenet.gr [195.170.0.25])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 937C943D58
	for <current@freebsd.org>; Thu, 24 Jun 2004 19:26:53 +0000 (GMT)
	(envelope-from keramida@ceid.upatras.gr)
Received: from gothmog.gr (patr530-a053.otenet.gr [212.205.215.53])
	i5OJQWnP030615
	for <current@freebsd.org>; Thu, 24 Jun 2004 22:26:33 +0300
Received: from gothmog.gr (gothmog [127.0.0.1])
	by gothmog.gr (8.12.11/8.12.11) with ESMTP id i5OJQUA9000816
	for <current@freebsd.org>; Thu, 24 Jun 2004 22:26:30 +0300 (EEST)
	(envelope-from keramida@ceid.upatras.gr)
Received: (from giorgos@localhost)
	by gothmog.gr (8.12.11/8.12.11/Submit) id i5OJQUeA000815
	for current@freebsd.org; Thu, 24 Jun 2004 22:26:30 +0300 (EEST)
	(envelope-from keramida@ceid.upatras.gr)
Date: Thu, 24 Jun 2004 22:26:30 +0300
From: Giorgos Keramidas <keramida@ceid.upatras.gr>
To: current@freebsd.org
Message-ID: <20040624192630.GA739@gothmog.gr>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
X-Mailman-Approved-At: Fri, 25 Jun 2004 11:42:40 +0000
Subject: FIX: today's ipfilter "mutex not locked" panic
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 24 Jun 2004 19:26:56 -0000

FWIW,

I've locally fixed the panics that some people mentioned today for
ipfilter with the following minor diff.  Now I can enable ipfilter
at boot time and still boot without panics.

--- patch begins ---
Index: sys/contrib/ipfilter/netinet/fil.c
===================================================================
RCS file: /home/ncvs/src/sys/contrib/ipfilter/netinet/fil.c,v
retrieving revision 1.38
diff -u -r1.38 fil.c
--- sys/contrib/ipfilter/netinet/fil.c	21 Jun 2004 22:46:35 -0000	1.38
+++ sys/contrib/ipfilter/netinet/fil.c	24 Jun 2004 19:17:33 -0000
@@ -2155,9 +2155,6 @@
 		ip_natsync(ifp);
 		ip_statesync(ifp);
 	}
-#  if defined(__FreeBSD_version) && (__FreeBSD_version >= 500043)
-	IFNET_RUNLOCK();
-#  endif
 	ip_natsync((struct ifnet *)-1);
 #  if defined(__FreeBSD_version) && (__FreeBSD_version >= 500043)
 	IFNET_RUNLOCK();
--- patch ends ---