From owner-freebsd-current@FreeBSD.ORG Mon Nov 10 01:02:29 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DBCA216A4CE; Mon, 10 Nov 2003 01:02:29 -0800 (PST) Received: from herring.nlsystems.com (mailgate.nlsystems.com [80.177.232.242]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6B00D43FF9; Mon, 10 Nov 2003 01:02:28 -0800 (PST) (envelope-from dfr@nlsystems.com) Received: from [10.0.0.2] (herring.nlsystems.com [10.0.0.2]) hAA923vf021819; Mon, 10 Nov 2003 09:02:11 GMT (envelope-from dfr@nlsystems.com) From: Doug Rabson To: Alfred Perlstein In-Reply-To: <20031110051010.GC33733@elvis.mu.org> References: <20031110051010.GC33733@elvis.mu.org> Content-Type: text/plain Message-Id: <1068454923.21784.1.camel@herring.nlsystems.com> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.5 Date: Mon, 10 Nov 2003 09:02:03 +0000 Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=0.0 required=5.0 tests=none autolearn=no version=2.60 X-Spam-Checker-Version: SpamAssassin 2.60 (1.212-2003-09-23-exp) on herring.nlsystems.com cc: dfr@freebsd.org cc: current@freebsd.org Subject: Re: taskqueue patch X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Nov 2003 09:02:30 -0000 I wasn't involved in converting taskqueue from 4.x-style SWIs to kernel threads so I can't be sure but this does look reasonable. I've been wondering about the 'not exiting' diagnostic from init for a while myself. On Mon, 2003-11-10 at 05:10, Alfred Perlstein wrote: > I noticed that init was complaining about processes not exiting > when doing a transition to single user mode. It appears > that the problem is that the taskqueue kernel process is > started with RFNOWAIT but doesn't respect orderly shutdown > signs. > > Diff follows: > > Index: subr_taskqueue.c > =================================================================== > RCS file: /home/ncvs/src/sys/kern/subr_taskqueue.c,v > retrieving revision 1.19 > diff -u -r1.19 subr_taskqueue.c > --- subr_taskqueue.c 6 Sep 2003 21:05:18 -0000 1.19 > +++ subr_taskqueue.c 10 Nov 2003 05:00:00 -0000 > @@ -271,7 +271,7 @@ > > TASKQUEUE_DEFINE(thread, taskqueue_thread_enqueue, 0, > kthread_create(taskqueue_kthread, NULL, > - &taskqueue_thread_proc, RFNOWAIT, 0, "taskqueue")); > + &taskqueue_thread_proc, 0, 0, "taskqueue")); > > int > taskqueue_enqueue_fast(struct taskqueue *queue, struct task *task) >