From owner-cvs-src-old@FreeBSD.ORG Tue Jan 25 20:34:15 2011 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7D1671065674 for ; Tue, 25 Jan 2011 20:34:15 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 507748FC14 for ; Tue, 25 Jan 2011 20:34:15 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.4/8.14.4) with ESMTP id p0PKYF8j046299 for ; Tue, 25 Jan 2011 20:34:15 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.4/8.14.4/Submit) id p0PKYFMn046298 for cvs-src-old@freebsd.org; Tue, 25 Jan 2011 20:34:15 GMT (envelope-from jhb@repoman.freebsd.org) Message-Id: <201101252034.p0PKYFMn046298@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to jhb@repoman.freebsd.org using -f From: John Baldwin Date: Tue, 25 Jan 2011 20:33:47 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: RELENG_7 Subject: cvs commit: src/sys/kern kern_exec.c kern_exit.c kern_fork.c kern_ktrace.c kern_proc.c src/sys/sys ktrace.h X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Jan 2011 20:34:15 -0000 jhb 2011-01-25 20:33:47 UTC FreeBSD src repository Modified files: (Branch: RELENG_7) sys/kern kern_exec.c kern_exit.c kern_fork.c kern_ktrace.c kern_proc.c sys/sys ktrace.h Log: SVN rev 217839 on 2011-01-25 20:33:47Z by jhb MFC 211514,214158: - There isn't really a need to hold the ktrace mutex just to read the value of p_traceflag that is stored in the kinfo_proc structure. - When disabling ktracing on a process, free any pending requests that may be left. This fixes a memory leak that can occur when tracing is disabled on a process via disabling tracing of a specific file (or if an I/O error occurs with the tracefile) if the process's next system call is exit(). The trace disabling code clears p_traceflag, so exit1() doesn't do any KTRACE-related cleanup leading to the leak. I chose to make the free'ing of pending records synchronous rather than patching exit1(). - Move KTRACE-specific logic out of kern_(exec|exit|fork).c and into kern_ktrace.c instead. Make ktrace_mtx private to kern_ktrace.c as a result. Revision Changes Path 1.308.2.15 +2 -10 src/sys/kern/kern_exec.c 1.304.2.7 +1 -31 src/sys/kern/kern_exit.c 1.282.2.11 +1 -15 src/sys/kern/kern_fork.c 1.121.2.5 +102 -24 src/sys/kern/kern_ktrace.c 1.252.2.27 +0 -6 src/sys/kern/kern_proc.c 1.33.2.3 +2 -2 src/sys/sys/ktrace.h