From nobody Thu Oct 9 20:41:25 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cjMGt1KDTz6C5hs; Thu, 09 Oct 2025 20:41:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cjMGs5ZFPz3ZZP; Thu, 09 Oct 2025 20:41:25 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1760042485; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=K4HZNTwlK0G/FGSJSOB7GvkCmVdKUeTXZyDUI7vObzw=; b=eTlUU4lMdd/yYA/Bi+dTIr1tUG4YTTBb7TyzloF2YZkskKJywsPmaeUc/YwJ37bUmK+Dpl z88JJ3Vy4YFDdhbmU40D2Q78A7aOGT2FuyohjsOD9Kr1zPCymsZmLyQGSujretmtHMUGNE xakkvqmsAvvne9vMF/yYruCNaF0hsz5v1iBYyG9tlXyiJ5P639m4qdjAQ3jdsdljGSZcGW C1NtULKCpbjiIYSf2RIJ4BX+OQ8PQS9agbSd1LVLLDhVzqOhcFHVvZu0CKgQKs4/NNHP+e zmja2cbKKh3lANrT/V6Pj4BDPVvON9HR6i9+wehShSJZS/q/4eyP65xgG8g1+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1760042485; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=K4HZNTwlK0G/FGSJSOB7GvkCmVdKUeTXZyDUI7vObzw=; b=TxVUeVuh6vwMU6Nwr3AKcORpU8pjs9PqI35nWwbOUNLyyYOCKQ/qc1S/2Uv+OmL5d7oLZv bIb0Lq3gFvH8jBmNdWPoileGdmFEpNT+oEf1/z0kC27Cb06pVDek5BPch88pJfJdKQ4Ouj DEpOgV0Wo4IagPSuQUg0JNT7oodTa1emoazatMIuMXc5ja/s3KDUGtJwl2e3h4TkyKQjAN 1GTYM4HIZaSmdj7Ef5SEwXiMCXqCH5FmNwDlVd8vrfn2QVQ5ahUbAV+3sa4tO+4bLDxOMf w941RekeTJgEqHUY4eum1L65Ociosf8HYHFI2X3HnXkRXRiVHzcLcVLZw++sqw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1760042485; a=rsa-sha256; cv=none; b=G+lrixE0uZwA747WnccuNC7GwIQhKvK6u7xU61LGqPf3eGBtNBv2LkfIrw0yOSyeSBnrsL 4d5x+XlZ7UeRfN6jqZ3BD54G/E5O6MTk43s5wedsnREIwnA2qKQczS9da/xWVMa/Nd0BEK tV5kn7vHazXWS0fS9/pbvPlXpYDC9dipytvkSeag75EnqJjyEYQA/AMzOCq/zK3Lrhf697 phPwW/tfo45wNWkbI/i+TpaUE/PS/HYyhOVc3UuLwZ0zySmGRQk5c6uofTtvz0xGUsnEIo PTu4XC+g0keqyQRgRcZ7Alv2cb5XG5wiSBLvfeB61BVcjbW3oRI9o2X71beSug== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cjMGs4wZzzZJl; Thu, 09 Oct 2025 20:41:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 599KfPvk089926; Thu, 9 Oct 2025 20:41:25 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 599KfP2f089922; Thu, 9 Oct 2025 20:41:25 GMT (envelope-from git) Date: Thu, 9 Oct 2025 20:41:25 GMT Message-Id: <202510092041.599KfP2f089922@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Olivier Certner Subject: git: 94f08f6a84e3 - stable/15 - nfsuserd: Fix OOB access on membership of too many groups, take 2 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 94f08f6a84e3e57692c1d244d234007b5a9f5cc5 Auto-Submitted: auto-generated The branch stable/15 has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=94f08f6a84e3e57692c1d244d234007b5a9f5cc5 commit 94f08f6a84e3e57692c1d244d234007b5a9f5cc5 Author: Olivier Certner AuthorDate: 2025-10-09 17:03:11 +0000 Commit: Olivier Certner CommitDate: 2025-10-09 20:40:43 +0000 nfsuserd: Fix OOB access on membership of too many groups, take 2 Forgot to reset 'ngroup' after one of the calls to getgrouplist() in the previous commit with same title (referenced also below). MFC after: 1 hour Fixes: e6c623c86ab4 ("Add support for the "-manage-gids" option to the nfsuserd daemon.") Fixes: bb339adfb2a2 ("nfsuserd: Fix OOB access on membership of too many groups") Sponsored by: The FreeBSD Foundation (cherry picked from commit 75eb6846269bb9bec1eaf4f0ad93d7525715b550) --- usr.sbin/nfsuserd/nfsuserd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/usr.sbin/nfsuserd/nfsuserd.c b/usr.sbin/nfsuserd/nfsuserd.c index 0e5c9c8f1e50..058253beaf95 100644 --- a/usr.sbin/nfsuserd/nfsuserd.c +++ b/usr.sbin/nfsuserd/nfsuserd.c @@ -629,6 +629,7 @@ nfsuserdsrv(struct svc_req *rqstp, SVCXPRT *transp) syslog(LOG_ERR, "Group list of user '%s' too big", pwd->pw_name); + ngroup = NGROUPS; } nid.nid_ngroup = ngroup; nid.nid_grps = grps;