From owner-freebsd-bugs Wed Nov 12 08:30:21 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.7/8.8.7) id IAA15405 for bugs-outgoing; Wed, 12 Nov 1997 08:30:21 -0800 (PST) (envelope-from owner-freebsd-bugs) Received: (from gnats@localhost) by hub.freebsd.org (8.8.7/8.8.7) id IAA15385; Wed, 12 Nov 1997 08:30:07 -0800 (PST) (envelope-from gnats) Resent-Date: Wed, 12 Nov 1997 08:30:07 -0800 (PST) Resent-Message-Id: <199711121630.IAA15385@hub.freebsd.org> Resent-From: gnats (GNATS Management) Resent-To: freebsd-bugs Resent-Reply-To: FreeBSD-gnats@FreeBSD.ORG, frf@xocolatl.com Received: from ns.tesco-stores.cz ([194.228.14.253]) by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id IAA14386 for ; Wed, 12 Nov 1997 08:16:47 -0800 (PST) (envelope-from frf@crux.tesco-stores.cz) Received: from crux.tesco-stores.cz (crux.tesco-stores.cz [194.228.14.134]) by ns.tesco-stores.cz (8.8.2/8.8.2) with ESMTP id RAA10735 for ; Wed, 12 Nov 1997 17:11:28 +0100 Received: (from root@localhost) by crux.tesco-stores.cz (8.8.8/8.8.7) id QAA00772; Wed, 12 Nov 1997 16:18:14 +0100 (CET) Message-Id: <199711121518.QAA00772@crux.tesco-stores.cz> Date: Wed, 12 Nov 1997 16:18:14 +0100 (CET) From: frf@xocolatl.com Reply-To: frf@xocolatl.com To: FreeBSD-gnats-submit@FreeBSD.ORG X-Send-Pr-Version: 3.2 Subject: i386/5019: Noisey debugging code in sb_dsp.c Sender: owner-freebsd-bugs@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk >Number: 5019 >Category: i386 >Synopsis: Noisey debugging code in sb_dsp.c >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Class: change-request >Submitter-Id: current-users >Arrival-Date: Wed Nov 12 08:30:02 PST 1997 >Last-Modified: >Originator: frf >Organization: >Release: FreeBSD 3.0-CURRENT i386 >Environment: 3.0-CURRENT FreeBSD 3.0-CURRENT #3: Mon Nov 10 22:03:10 CET 1997 >Description: Someone left their debugging printf's in /sys/i386/isa/sound/sb_dsp.c >How-To-Repeat: Build a kernel with SBPro support and play some music. Watch your logfiles fill-up. Nov 9 21:03:14 crux /kernel: dsp_speed 8000 Nov 9 21:03:14 crux /kernel: dsp_speed done 8000 Nov 9 21:03:18 crux /kernel: dsp_speed 8000 Nov 9 21:03:18 crux /kernel: dsp_speed done 8000 Nov 10 15:29:45 crux /kernel: dsp_speed 8000 Nov 10 15:29:45 crux /kernel: dsp_speed done 8000 Nov 10 15:29:45 crux /kernel: dsp_speed 44100 Nov 10 15:29:45 crux /kernel: dsp_speed done 43478 Nov 10 15:29:45 crux /kernel: dsp_speed 44100 Nov 10 15:29:45 crux /kernel: dsp_speed done 43478 Nov 10 15:30:48 crux /kernel: dsp_speed 8000 Nov 10 15:30:48 crux /kernel: dsp_speed done 8000 Nov 10 15:30:48 crux /kernel: dsp_speed 43478 Nov 10 15:30:49 crux /kernel: dsp_speed done 43478 >Fix: --cut --- /sys/i386/isa/sound/sb_dsp.c Fri Oct 31 18:25:05 1997 +++ sys/i386/isa/sound/sb_dsp.c Wed Nov 12 15:45:38 1997 @@ -231,7 +231,9 @@ u_long flags; int max_speed = 44100; -printf("dsp_speed %d\n", speed); /* XXX lr 970601 */ +#ifdef DSP_DEBUG + printf("dsp_speed %d\n", speed); /* XXX lr 970601 */ +#endif if (speed < 4000) speed = 4000; @@ -310,7 +312,9 @@ speed /= 2; dsp_current_speed = speed; -printf("dsp_speed done %d\n", speed); +#ifdef DSP_DEBUG + printf("dsp_speed done %d\n", speed); +#endif return speed; } --cut or just delete the offending lines >Audit-Trail: >Unformatted: