From owner-freebsd-python@FreeBSD.ORG Thu Jul 3 10:51:01 2014 Return-Path: Delivered-To: python@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8ACBA705; Thu, 3 Jul 2014 10:51:01 +0000 (UTC) Received: from mail-pa0-x236.google.com (mail-pa0-x236.google.com [IPv6:2607:f8b0:400e:c03::236]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 57EE72889; Thu, 3 Jul 2014 10:51:01 +0000 (UTC) Received: by mail-pa0-f54.google.com with SMTP id et14so27395pad.13 for ; Thu, 03 Jul 2014 03:51:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:reply-to:user-agent:mime-version:to:cc :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=OxVKU5QjGEn9M0aBVDmD14wlN3ZP4Xn9fegu5uDokfI=; b=VnddqMc+DVb+nt6krWwE80a7tquCsQVv2Z67hGHhSwJoa8cXSM+jOWMK3yOboJefne gv5EMu7Wmgbk49b3Dunc3t1cD+8L0WvfVDtUCo/NKlctg48+u1GyzyzEWJEZKx5a1IJ4 VYZcrlj7b+m8uI9i8SOTKpwfiS3OL6e9KvSXz0osEurM+sujbicm5iWN7EPA0KzC2BBa uDruZGIVyzfRF0F+X+qM0z53eFzR2SRNJAq9X6IIdNRHhih5UY7MV54cT9gxEwCEbZNP rn9km4UIbAakl5QWIDsUQibn5ErsvnwLHRlvPth2MLAOSR05Kb61vpBJiUuUV+W+KKK7 1hxw== X-Received: by 10.66.132.81 with SMTP id os17mr3709996pab.137.1404384660928; Thu, 03 Jul 2014 03:51:00 -0700 (PDT) Received: from [192.168.1.7] (ppp59-167-128-11.static.internode.on.net. [59.167.128.11]) by mx.google.com with ESMTPSA id vy5sm141542692pac.13.2014.07.03.03.50.59 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 03 Jul 2014 03:51:00 -0700 (PDT) Sender: Kubilay Kocak Message-ID: <53B5358D.2030208@FreeBSD.org> Date: Thu, 03 Jul 2014 20:50:53 +1000 From: Kubilay Kocak Reply-To: koobs@FreeBSD.org User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Tijl Coosemans Subject: Re: ports/169276 References: <53B4FC59.9000706@FreeBSD.org> <20140703112112.120f0db3@kalimero.tijl.coosemans.org> <53B52633.9000000@FreeBSD.org> <20140703124756.5177f63b@kalimero.tijl.coosemans.org> In-Reply-To: <20140703124756.5177f63b@kalimero.tijl.coosemans.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: Randy Bush , python@FreeBSD.org X-BeenThere: freebsd-python@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: FreeBSD-specific Python issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jul 2014 10:51:01 -0000 On 3/07/2014 8:47 PM, Tijl Coosemans wrote: > On Thu, 03 Jul 2014 19:45:23 +1000 Kubilay Kocak wrote: >> The cause of the module failures was due to a >> CFLAGS="-I/usr/local/include" in /etc/make.conf so that parts all >> sorted. This is why we kept the comment in there about using CPPFLAGS vs >> CFLAGS (removed in your change) > > I see, that will probably cause subtle problems in other ports as well. > > The reason I removed the comment about CPPFLAGS is because it seemed > redundant to me. Flags like -I and -D should always go into CPPFLAGS. > Adding them to CFLAGS is the special case. > >> I understand the rationale for the move from LDFLAGS -> LIBS, but I am >> still concerned due to the plethora of flags based issues we've had with >> Python in the past >> >> This is especially with regards to the right flags turning up in the >> right places for shared extensions (such as within python-config output) >> and doubly-so for the substantial number of workarounds that we've had >> to retain and maintain locally in the port (see the post-configure and >> pre-patch targets for lang/python27 for example) > > Ok, I think everything is ok at the moment, but feel free to contact > me if some issue comes up. > Much appreciated :)