Date: Wed, 16 Apr 2014 18:10:22 -0500 (CDT) From: Lawrence "The Dreamer" Chen <beastie@tardisi.com> To: FreeBSD-gnats-submit@freebsd.org Subject: ports/188710: [patch] net/boinc-client: fails to detect VirtualBox Message-ID: <201404162310.s3GNAMpr065559@zen.lhaven.homeip.net> Resent-Message-ID: <201404162320.s3GNK0cw052133@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 188710
>Category: ports
>Synopsis: [patch] net/boinc-client: fails to detect VirtualBox
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Wed Apr 16 23:20:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator: Lawrence "The Dreamer" Chen
>Release: FreeBSD 9.2-RELEASE-p4 amd64
>Organization:
>Environment:
System: FreeBSD zen.lhaven.homeip.net 9.2-RELEASE-p4 FreeBSD 9.2-RELEASE-p4 #0: Tue Apr 8 18:08:22 UTC 2014 root@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC amd64
>Description:
Back when I first started running boinc on FreeBSD, it was nice to find
that it detected the presence of VirtualBox and that I was able to
participate in Test4Theory.
But, later whenever I would check on things, I would see that its unable
to find it. In the past this has usually been a issue with boinc-client
starting before virtualbox is ready, but after solving a different
problem in rcordering (tmp/cleartmp being called after vboxheadless
has started, causing the socket in /tmp to vanish.)
I decided I needed to look deeper.
>How-To-Repeat:
>Fix:
Eventually, I found that in hostinfo_unix.cpp, it looks in for
"/usr/lib/virtualbox/VBoxManage" if on a LINUX_LIKE system, or another
way for Mac OS X, but nothing for FreeBSD.
Don't know when it stopped supporting FreeBSD, but now suspect it might
been between the 6.x and 7.x versions. Seem to recall it was something
that had quickly been added near the end of 6.x, but designed into 7.
--- patch begins here ---
--- files/patch-client__hostinfo_unix.cpp.orig 1969-12-31 18:00:00.000000000 -0600
+++ files/patch-client__hostinfo_unix.cpp 2014-04-16 17:14:25.138932145 -0500
@@ -0,0 +1,20 @@
+--- client/hostinfo_unix.cpp.orig 2013-12-20 14:28:08.000000000 -0600
++++ client/hostinfo_unix.cpp 2014-04-16 17:07:56.996236131 -0500
+@@ -1213,6 +1213,8 @@
+
+ #if LINUX_LIKE_SYSTEM
+ safe_strcpy(path, "/usr/lib/virtualbox/VBoxManage");
++#elif defined( __FreeBSD__)
++ safe_strcpy(path, "/usr/local/lib/virtualbox/VBoxManage");
+ #elif defined( __APPLE__)
+ FSRef theFSRef;
+ OSStatus status = noErr;
+@@ -1231,7 +1233,7 @@
+ #endif
+
+ if (boinc_file_exists(path)) {
+-#if LINUX_LIKE_SYSTEM
++#if LINUX_LIKE_SYSTEM || defined( __FreeBSD__)
+ if (access(path, X_OK)) {
+ return 0;
+ }
--- patch ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201404162310.s3GNAMpr065559>