From owner-cvs-all@FreeBSD.ORG Sat Jan 20 10:47:17 2007 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id BBE3F16A402; Sat, 20 Jan 2007 10:47:17 +0000 (UTC) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 9606113C428; Sat, 20 Jan 2007 10:47:17 +0000 (UTC) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id l0KAlH2v076851; Sat, 20 Jan 2007 10:47:17 GMT (envelope-from marius@repoman.freebsd.org) Received: (from marius@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id l0KAlHi5076845; Sat, 20 Jan 2007 10:47:17 GMT (envelope-from marius) Message-Id: <200701201047.l0KAlHi5076845@repoman.freebsd.org> From: Marius Strobl Date: Sat, 20 Jan 2007 10:47:16 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/le lance.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Jan 2007 10:47:17 -0000 marius 2007-01-20 10:47:16 UTC FreeBSD src repository Modified files: sys/dev/le lance.c Log: For setting the port PCnet chips must be powered down or stopped and unlike documented may not take effect without an initialization. So don't invoke (*sc_mediachange) directly in lance_mediachange() but go through lance_init_locked(). It's suboptimal to impose this for all chips but given that besides the affected PCI bus front-end the only other front-end which supports media selection is and likely ever will be the 'ledma' front-end I see not enough reason to break the in-driver API for this (though one could argue both ways here). Revision Changes Path 1.4 +15 -7 src/sys/dev/le/lance.c