Date: Sun, 14 Aug 2005 18:27:55 GMT From: Aldert Nooitgedagt <aldert@nooitgedagt.net> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/84922: [patch] www/aolserver: FIX for non-compiling port Message-ID: <200508141827.j7EIRtDp043464@www.freebsd.org> Resent-Message-ID: <200508141830.j7EIUIq4080850@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 84922
>Category: ports
>Synopsis: [patch] www/aolserver: FIX for non-compiling port
>Confidential: no
>Severity: critical
>Priority: high
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: maintainer-update
>Submitter-Id: current-users
>Arrival-Date: Sun Aug 14 18:30:18 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator: Aldert Nooitgedagt
>Release: 5.4
>Organization:
>Environment:
FreeBSD freebsd54.localdomain 5.4-RELEASE FreeBSD 5.4-RELEASE #0: Sun May 8 10:21:06 UTC 2005 root@harlow.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC i386
>Description:
I wasn't aware aolserver isn't compiling with tcl 8.4.11,
until Bill Fenners posting today. I need to follow this:
http://people.freebsd.org/~fenner/errorlogs/
Based on http://openacs.org/forums/message-view?message%5fid=309814 I created three patches that go into aolserver/files:
patch-conn.c
patch-unix.c
patch-tclobj.c
This seems to fix the problems.
>How-To-Repeat:
Aolserver is not compiling with tcl8.4.11
>Fix:
----------------------
PATCH-CONN.C
----------------------
--- nsd/conn.c.orig Sun Aug 14 16:32:45 2005
+++ nsd/conn.c Sun Aug 14 17:43:31 2005
@@ -840,7 +840,7 @@
}
result = Tcl_GetObjResult(interp);
- connPtr = (Conn *) conn = itPtr->conn;
+ connPtr = conn = (Conn *) itPtr->conn;
/*
* Only the "isconnected" option operates without a conn.
---------------------------
PATCH-UNIX.C
---------------------------
--- nsd/unix.c.orig Sun Aug 14 16:31:07 2005
+++ nsd/unix.c Sun Aug 14 17:16:18 2005
@@ -71,7 +71,7 @@
* As of glibc 2.3 with NPTL, this should be a no-op.
*/
- pthread_kill_other_threads_np();
+/* pthread_kill_other_threads_np(); */
#endif
Ns_Log(Fatal, "received fatal signal %d", signal);
-----------------------------------------
PATCH-TCLOBJ.C
-----------------------------------------
--- nsd/tclobj.c.orig Sun Aug 14 18:37:04 2005
+++ nsd/tclobj.c Sun Aug 14 18:40:23 2005
@@ -85,9 +85,11 @@
if (sizeof(obj.internalRep) < sizeof(Ns_Time)) {
Tcl_Panic("NsTclInitObjs: sizeof(obj.internalRep) < sizeof(Ns_Time)");
}
- if (sizeof(int) < sizeof(long)) {
- Tcl_Panic("NsTclInitObjs: sizeof(int) < sizeof(long)");
- }
+/*
+ * if (sizeof(int) < sizeof(long)) {
+ * Tcl_Panic("NsTclInitObjs: sizeof(int) < sizeof(long)");
+ * }
+*/
intTypePtr = Tcl_GetObjType("int");
if (intTypePtr == NULL) {
Tcl_Panic("NsTclInitObjs: no int type");
---------------------------------------
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200508141827.j7EIRtDp043464>