From nobody Tue Jun 24 02:38:31 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bR8K71t2Sz607Gk for ; Tue, 24 Jun 2025 02:38:51 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic304-25.consmr.mail.gq1.yahoo.com (sonic304-25.consmr.mail.gq1.yahoo.com [98.137.68.206]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4bR8K66jGGz3Fr2 for ; Tue, 24 Jun 2025 02:38:50 +0000 (UTC) (envelope-from marklmi@yahoo.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=yahoo.com header.s=s2048 header.b=lwzp3w61; spf=pass (mx1.freebsd.org: domain of marklmi@yahoo.com designates 98.137.68.206 as permitted sender) smtp.mailfrom=marklmi@yahoo.com; dmarc=pass (policy=reject) header.from=yahoo.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1750732724; bh=QrnIzeoYRKnTtYt0m/P2XYlJ3vWBGevgoFhMjVBJ70Y=; h=From:Subject:Date:To:References:From:Subject:Reply-To; b=lwzp3w61BPRxUkny8zLOFULQ8UzPGxusMISguPdJTpVkBs5uxFyvsEyeD41oAwY0zAblisCUJA9BpKviaY/e1z4pFEXm9EBYEsVR1avAlt9GZuit8TZfsI95xkPXp1e6JAsGolS8GtzizLTWsUETzCcf2WDW5RnqOHRfGn4tCnS9TldjlrJ97P2TtjkF7DIwKFZZtBrhLcQyTyZj91CMuxhLtL8aHn18LoZ89aUG83sMhcL1bdbNcVKY1aa/EgQONDCktA8MIJxQlAz4VGpsqYE5XBjgbylAV0hgntLZaRrd2SZqyFuTYBPnkJiYjUZtkGKdGi8n6HKfGnhbXwo2MQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1750732724; bh=dTkSUM16xEbJW+5B2yoMujVzPB8rzxYHgMtllWmpG0i=; h=X-Sonic-MF:From:Subject:Date:To:From:Subject; b=EU38cgfxGz510+7o4W1pZUZlySskbvP4R9AzViZje8sFTvist2dGGc+6CLKfrH+RRq8VfyxWf4NRCP74OJcC0ozKj1eW+dWNUUoMfP6/RYQ7GpFZO4mIWfldtGi9D/EjYhbLtq4ILozD5w39AlfyKEcqi3OBBHZoBLX+v/kkB2NlLJjZ93epPpJh73uxkMQEtEGHiRAtmgtw+NFHdUAgUvEfayfWv2cAc4a/ocpDONSG+vMMMTDe/SMitIT3X1WoDhVL4Ndn+DTEgydcAW5V/jKEa+OOlWyWmKG5D6N0hZ8/Or4mkolYEdc2wPtnS3rAVbPwLjtwfmzRK7UFzIscYg== X-YMail-OSG: XGbDHdAVM1mXexDNYbAhDmSzt7CWP7d19DtSZTAdXz.f8sdRdw8iVXf6BanXTWS ejz5pt_yOGKE_tAHEAwN2rTBSNWKtSFC0KwiKNFnfoVA9FCPo1zEoNXs8N6gRAugQgYRRblkkqH8 1vaMULus8m2A29wied6Me0BuSZv5CBZo3igMzTs3gT98LFrjxs4Te1ckWiSIRHAdm1JFijWKRgVT z8E4mUb26BHqA.ewGj3n0wBmpw8gZjuiGsDoMQOoml0VVzIwBfdHq4mUsruq9OcQwKuDtLcxnK2A 72IGQzuRhoX_NAHEd4uGH7WtgzN1J02rih.a3P0glmM2ttdYrJ_jOK5uhTkN0joM5tjDU1Pe1Szl RfPAWvhl.dT9ZtJbuDCnOjDJSC__zz8tHoc_xewKhvia2LSooGijsQQLe7_KiHDJ6GhsyiUNndLK rCQjXWVLcVQjz13oD6QI7cCKic0B_ij.BWQVE07NfxU3hmHKJWH4I12iw5jCQGyJojWY9xy736ZN sxqzgcP04iP_4HzV80UHaEXanLijpMlwzP5AL_.p07xKh56TDO.eiAtwwh9w2u0B3xPUbWGVwuOA S5jBzJczDlJ_sxv0Anfoa_cw2TVGjzzpYy8PJkePOLXRzus.uMGUx.BV5Mwx8ma.wUJfO_9iPxN6 4CszmwvfJajPhdkaaJWh3veZE0LLGF7D0FgwuHqw0Fc1nZ9IY4bt50Yh1Udq0ezkIe8MUCn3CJz8 UqX8LLnv5VJCh.XEOR6So1JmbX0StZgKal.ElK_5VVcFnekRgX4vwSdgB.Q2GO6LBd.ZAKV_kxbE vrjh9YvhnK90i8DmF2p7Uc75UOPy.qHCQHV_pcIaDybAXw61vROVtByzigXYtsObYxN1Q1q9UJNK peVBbY_AIYTkOODNbX6jTh6tGH2qM3Qj4FhRXs9BHJ4L8wwWllG_KDas_x5dWT0c_91m3lZyzoE. bOojwpNa0w2Is_VBPbHqktRtEYm7OltZXs9ApKzlxGGjzAJ2YR3oZotMdPnTWMnM2xVZLvHc0Icj KDEYmh31yCkyCNg7deDHXceZjFbaVO81PX4I8FGKu6ZuB9Ac6yw2ARsOh2rF_Irfr1phN3L_T0wy V9Xh6723j0ySy4JG0tGbGSy1nv5GBO4JVMo6Qbbhz1wke3W0PqWD.PhW1Wx0bJIrHgj38cnVVKPB ZNKu5Fw54rY_y9M1AhRQv5w5BiROzhh9jbqGijSB2tAz9YK_LSs9uJXYTihUVRQ8xGBIp2AUTxgQ sYmJ0_NA0O6KHPyVER0cKv3mYOtqIX_YqVaPTSx5Z3lJEsTdihdIEsWct.uS4lbC5N0R1KU3Y0LH .rOhuTYcdpZEWOecuY7LYF.xjz63tIpg5nDH1ZB6XCwInVyaJXurF7nuGpBTn8aY3T7Zu2bqylIM RdB1xW1ZpggV3sptGMeqxWH033oMdTsTSONCzjMKDfUu3xP.bAzFo4.Dh0TzJlyGMVzBFNTkn_zu AIjZx4xYlduS3wS_fJDZiA9hOvmL2Zbk6CM12e8cFfLGRBYXP0DTJ4q7rRF3qoS0pJ0H5tY_eeUi K8CrTC1IEVw4g8SLFgxDK0WzgTlGdb_ff.Ya1C22RgjMRt2QZRcBO5dNFDZtwGMVUDNk7X_chDIi C_ab2fRZbztz93bu.ggmovgcvOXBJHPhHaS54T6UI6LPPvGjDloEMjcH7d6Rsuyvjfx3DcVvgmvu FcGPS_QePVSzHugHYGT8PbI7c0qsD3uhhTzHPprxXQHaJom_KwAhalmk8fsAXdcGA0nZqwwhv0Ov us9Kl3GqPW5svMs2GWjbhz.uFJBBMKTZ56Kq33LcNniuGfen3dAyFiG350skDSw3cFrzRKG4wYEz FqCJdJvKSIFAYGy7L7rLKvIhdG4hsEvyshoz_novMUceDKHSZbuJNkBRWL2T2pnubTMf9teOSCfC LIdzPY1HCiITuCTlyeESP2KErxYZNUumk9pOs5WutCciHXEYYuttlTGDTaZ8KcVDyQyaXmybJaJa kT5hyRKAVkIyZJ.t9ig7nPqSSNaO4Pu.jrpdls1e8z4qy3P48tbes3IPGbUjp8DC8jth9l2qthsy 7ikdF9tWhatxNSnaGAtZDibRF4dUddmHDdgLyookQBlru_kJQxFbuDECyhnonPXswZ.crvIMcaxG 1PIht.srS95JcqtbCQAimhpiHsu54ErL5yYN72dXHY2DfwqYtctj3vuIHDfPeioNJSPqatoSfMEM 1FcnAvxQJKLuskUO03_OBUEtmfbaznKJdVwo0KSBc2zONXBRdvWYVdpxaQdhtOvv9RdItdyhijtZ 5K2yQzqIjbaXzalg7eBxB X-Sonic-MF: X-Sonic-ID: cdcfa0e7-4ca7-41aa-a33a-9007b31c0cae Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.gq1.yahoo.com with HTTP; Tue, 24 Jun 2025 02:38:44 +0000 Received: by hermes--production-gq1-74d64bb7d7-5qmwx (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 14a908669b03e38ad5f5baecd96dba60; Tue, 24 Jun 2025 02:38:42 +0000 (UTC) From: Mark Millard Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.600.51.1.1\)) Subject: RE: git: 81e6c0168d46 - main - lindebugfs.c: Fix possible NULL dereference Message-Id: <98C6A324-35AD-471D-9A95-ABD34657BD98@yahoo.com> Date: Mon, 23 Jun 2025 19:38:31 -0700 To: "dumbbell@freebsd.org" , dev-commits-src-main@freebsd.org X-Mailer: Apple Mail (2.3826.600.51.1.1) References: <98C6A324-35AD-471D-9A95-ABD34657BD98.ref@yahoo.com> X-Spamd-Result: default: False [-1.12 / 15.00]; NEURAL_SPAM_LONG(1.00)[1.000]; NEURAL_HAM_MEDIUM(-0.90)[-0.898]; NEURAL_HAM_SHORT(-0.72)[-0.722]; MV_CASE(0.50)[]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_TWO(0.00)[2]; FREEMAIL_FROM(0.00)[yahoo.com]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; TO_DN_EQ_ADDR_SOME(0.00)[]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; DWL_DNSWL_NONE(0.00)[yahoo.com:dkim]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; DKIM_TRACE(0.00)[yahoo.com:+]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org]; RWL_MAILSPIKE_POSSIBLE(0.00)[98.137.68.206:from]; MID_RHS_MATCH_FROM(0.00)[]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[98.137.68.206:from] X-Rspamd-Queue-Id: 4bR8K66jGGz3Fr2 X-Spamd-Bar: - Jean-S=C3=A9bastien P=C3=A9dron wrote on Date: Mon, 23 Jun 2025 21:54:28 UTC : > The branch main has been updated by dumbbell: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D81e6c0168d46b0f5d5d4c5d0405caca8= da24c35e >=20 > commit 81e6c0168d46b0f5d5d4c5d0405caca8da24c35e > Author: Jean-S=C3=A9bastien P=C3=A9dron > AuthorDate: 2025-06-18 20:32:13 +0000 > Commit: Jean-S=C3=A9bastien P=C3=A9dron > CommitDate: 2025-06-23 21:43:51 +0000 >=20 > lindebugfs.c: Fix possible NULL dereference > =20 > If `debugfs_destroy()` is called early as part of error handling = during > initialzation, `pn->pn_data` is unset. "is unset": Is this wording intended to mean: A) pn->pn_data could hold most any bit pattern? (not previously initialized to a known-valid pointer value [including NULL as an example of known-valid]) vs. B) guaranteed to have been set to either NULL or to a valid non-NULL pointer value? > This led to a panic in that if > because `dm` is NULL. Was NULL actually the only possible value that should not be dereferenced? > Reviewed by: bz > Sponsored by: The FreeBSD Foundation > Differential Revision: https://reviews.freebsd.org/D50985 > --- > sys/compat/lindebugfs/lindebugfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/sys/compat/lindebugfs/lindebugfs.c = b/sys/compat/lindebugfs/lindebugfs.c > index 97f73e79fb6c..50f9377ffec3 100644 > --- a/sys/compat/lindebugfs/lindebugfs.c > +++ b/sys/compat/lindebugfs/lindebugfs.c > @@ -104,7 +104,7 @@ debugfs_destroy(PFS_DESTROY_ARGS) > struct dentry_meta *dm; > =20 > dm =3D pn->pn_data; > - if (dm->dm_type =3D=3D DM_SYMLINK) > + if (dm !=3D NULL && dm->dm_type =3D=3D DM_SYMLINK) The above code would be sufficient for (B) but would not be for (A). If the context is an example of (A), it would appear that the context needs to be changed to be an example of (B). In other words: the new if above would not be what needs to be changed. > free(dm->dm_data, M_DFSINT); > =20 > free(dm, M_DFSINT); =3D=3D=3D Mark Millard marklmi at yahoo.com