Date: Sat, 4 Mar 2006 02:27:47 GMT From: db@db.net To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/94055: bug in devel/porttools w/rt unmaintained ports Message-ID: <200603040227.k242RlGW077605@freefall.freebsd.org> Resent-Message-ID: <200603040230.k242UA0e077693@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 94055
>Category: ports
>Synopsis: bug in devel/porttools w/rt unmaintained ports
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Sat Mar 04 02:30:10 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator: Diane Bruce
>Release: FreeBSD 6.0-STABLE i386
>Organization:
FreeBSD
>Environment:
System: FreeBSD freefall.freebsd.org 6.0-STABLE FreeBSD 6.0-STABLE #0: Sat Dec 10 03:18:20 UTC 2005 kensmith@freefall.freebsd.org:/usr/obj/usr/src/sys/FREEFALL i386
>Description:
Porttools Cc:s freebsd-ports@ for unmaintained ports. This simply creates
duplicate postings.
>How-To-Repeat:
>Fix:
From: Diane Bruce <db@db.net>
To: Mark Linimon <linimon@lonesome.com>
Cc: sergei@FreeBSD.org
On Sun, Feb 26, 2006 at 01:13:36AM -0600, Mark Linimon wrote:
> Please don't Cc: ports@ on PRs. It just creates duplicate messages. Thanks.
It's a bug in the port submit tool.
If one changes both the maintainer from ports@FreeBSD.org and updates
the port, it cc's ports@FreeBSD.org anyway.
diff attached as well as here (I know my proxy munges patches)
--- /usr/local/share/porttools/cmd_submit.ORIG Sun Feb 26 10:36:38 2006
+++ /usr/local/share/porttools/cmd_submit Sun Feb 26 11:06:18 2006
@@ -233,7 +233,11 @@
NEW_MAINTAINER="`awk '/^\+MAINTAINER/ { print $2; }' ${PATCH}`"
if [ "${NEW_MAINTAINER}" != "${OLD_MAINTAINER}" ]
then
- CC="${OLD_MAINTAINER}"
+ if [ "${OLD_MAINTAINER}" != "ports@FreeBSD.org" ]
+ then
+ CC="${OLD_MAINTAINER}"
+ fi
+
case ${NEW_MAINTAINER} in
# New maintainer is you
${EMAIL})
--
- db@db.net http://www.db.net/~db
--HlL+5n6rz5pIUxbD
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="cmd_submit.diff"
--- /usr/local/share/porttools/cmd_submit.ORIG Sun Feb 26 10:36:38 2006
+++ /usr/local/share/porttools/cmd_submit Sun Feb 26 11:06:18 2006
@@ -233,7 +233,11 @@
NEW_MAINTAINER="`awk '/^\+MAINTAINER/ { print $2; }' ${PATCH}`"
if [ "${NEW_MAINTAINER}" != "${OLD_MAINTAINER}" ]
then
- CC="${OLD_MAINTAINER}"
+ if [ "${OLD_MAINTAINER}" != "ports@FreeBSD.org" ]
+ then
+ CC="${OLD_MAINTAINER}"
+ fi
+
case ${NEW_MAINTAINER} in
# New maintainer is you
${EMAIL})
--HlL+5n6rz5pIUxbD--
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200603040227.k242RlGW077605>