From owner-svn-src-all@freebsd.org Thu Dec 5 19:26:01 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 119DB1A99DC for ; Thu, 5 Dec 2019 19:26:01 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound3d.ore.mailhop.org (outbound3d.ore.mailhop.org [54.186.57.195]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 47TQgD69jmz4YXF for ; Thu, 5 Dec 2019 19:26:00 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1575573959; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=HUyGIy0lwOYhxsy64CAVBoXDvzRcgy72jW6kHVhZj8JIuM/5pji9xDGBc+YVs4IhzcNZBYoWJWtE7 H+lPg+3izolVpdUUQMiJl46XpdwleYXefc6Jo026/glqvWqazmz++lPkg0kEIB2Y/ceBwwuIeyzgc1 6ayscfQNJmM/YVVSK++OAvCZK2eaLi6lJoJFNOb6JW3/cYpUWvq7uKvnaQHfzHMlBw+kPgB2flqk5H KLjF6mzs0M20xR0+KlbruzUExu5g29b+dKW7HVLGGw6+0pL/b+CaGJXA5dLuPC2DrrOVAXhZoX1A87 Fu7En0FvJZj7bQ8xtsEIE64/8eCyvvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:dkim-signature:from; bh=FTzEkFY5lec1ncDRzac7Em410katDo4T5ZLdv1XkYPo=; b=orEflsp2+VIv3N2exv8WSEj+wpVyS/XQ/SRdYATFXjr0E6v0ZreRcLpsRteJ0fHSpAY50Slnd9GWt UH+UJlRnIkU4TuD/tntzEOBU24Jpx24fYIiUNfNmQm7NG9X9CXkNVEjxhDt8sWwXIAxwo8pKzMyJY7 f12b6uMhNX6aIu7EjGF/0HDjnoiwVlyO+6xOWIeEvvB5UCXA4j+VpaPqHLWVXyaFtqB8UJrf8/eHKj 6lCp6bhHN0tQk/vYwCId12WsmqR4o3Pku3FSxp+zE7o6aoERjrMOWNtA4qa8HgS43dBBACQtS9fv8g p3hIkcbdzrcbhTU/7slV0laSifjO9UQ== ARC-Authentication-Results: i=1; outbound3.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:from; bh=FTzEkFY5lec1ncDRzac7Em410katDo4T5ZLdv1XkYPo=; b=ZJZ7eE1caeGqjwzPNPWtUy2+oB7k8KAlPb1bMKIcK/g865dvs0jzITk2lyloOtkpSRi6JmXXmEGGr FTxdmlFJYTUgiI9mDDvjtrC/2A2OZA/0+DQE2eHrKfKBowR2mm1oJs/VG+Mtpf5AdWJNrL1kXO855f niwWQInptmQpcggAqAjg1UIQCj88zELIWix4xZM2bQXxhBqGAM391iYU/bO85BEAAAwcN8tLIUFHDJ JKsW4qb7zsFgr5iFSyH+ODP8Uam4dwberbKHhaWy3V2b7E1Td8BknhZo+4OUUOT2DHY20MVzCm+jH8 cMwRkxXpeNYhVrve7Rrcnjyx/gnScEw== X-MHO-RoutePath: aGlwcGll X-MHO-User: 0ffa423f-1795-11ea-b80c-052b4a66b6b2 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound3.ore.mailhop.org (Halon) with ESMTPSA id 0ffa423f-1795-11ea-b80c-052b4a66b6b2; Thu, 05 Dec 2019 19:25:58 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id xB5JPvxe008340; Thu, 5 Dec 2019 12:25:57 -0700 (MST) (envelope-from ian@freebsd.org) Message-ID: Subject: Re: svn commit: r355301 - head/usr.sbin/bhyve From: Ian Lepore To: rgrimes@FreeBSD.org, John Baldwin Cc: Vincenzo Maffione , src-committers , svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org Date: Thu, 05 Dec 2019 12:25:57 -0700 In-Reply-To: <201912051921.xB5JLTMk045371@gndrsh.dnsmgr.net> References: <201912051921.xB5JLTMk045371@gndrsh.dnsmgr.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 47TQgD69jmz4YXF X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-1.97 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-0.98)[-0.983,0]; NEURAL_HAM_LONG(-0.98)[-0.983,0]; ASN(0.00)[asn:16509, ipnet:54.186.0.0/15, country:US] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Dec 2019 19:26:01 -0000 On Thu, 2019-12-05 at 11:21 -0800, Rodney W. Grimes wrote: > > On 12/4/19 9:35 PM, Rodney W. Grimes wrote: > > > > I see, thanks for the pointers. > > > > It looks like cfmakeraw() and tcsetattr() were what I was > > > > looking for. > > > > A bhyve-specific printf wrapper looks the right solution to me. > > > > I can try to sketch a patch for you guys to review, if that's > > > > useful. > > > > > > > > Cheers, > > > > Vincenzo > > > > > > Meanwhile could you please revert the commit, and add a note to > > > D22552 to the effects that this was not the right solution? > > > > I don't think we have to revert as it isn't that big of a > > deal. Just > > fixing it going forward is probably fine. > > I disagree. Not reverting this leads to a bunch of un-needed changes > in the forward moving review, clouding the view of what is really > being changed in that new review which is now a mix of undoing this > and adding a new set of macros to deal with end of line. > It doesn't cloud anything in the new review. Reverting it will change all the \n\r back to just \n. Then exactly the same lines will need changing on the do-over to remove the \n. There are times when backing out a changeset and doing things over from scratch make sense, but this doesn't seem to be one of them. -- Ian