From owner-freebsd-current@freebsd.org Tue Aug 18 13:31:46 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1C8AD3BC323 for ; Tue, 18 Aug 2020 13:31:46 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4BWBds5zhjz43tZ for ; Tue, 18 Aug 2020 13:31:45 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mailman.nyi.freebsd.org (Postfix) id CD4F83BC322; Tue, 18 Aug 2020 13:31:45 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CD1833BBF6D for ; Tue, 18 Aug 2020 13:31:45 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BWBdr24Wtz43yT for ; Tue, 18 Aug 2020 13:31:44 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mail-wr1-x441.google.com with SMTP id r15so8372147wrp.13 for ; Tue, 18 Aug 2020 06:31:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=2ZrgkiViSkN+TN6XpTEOoJ24pV3o/VfAW5+h84khaAQ=; b=Hgvm0U6F/Tzr9lCpm8C2W5ImRMZuBXcSW+3GBwJA5Q03MBiVrI3m+TikGxqjrCJPuM uFnTQfW2La4nYC4vWozA5u4OvJ7rIBa/gLAG5ibmeApnukJlGlvYbgQRRaW313RVcsra M9jYKlTb+TFp0SKM5Pxz4R0Cnm6SgeeZ4CS2A0TA9Mu7rSOAP9bZ+fiRCY3zvaJ31uYl qTOUx6d/eiElxTg7l+ckc0gdlA9Vg3hddvZO8rkVJjJs0xVudk/dC+jPVxr58bMlw8b2 SyfI4D2N7OqycqI/rw9+4lEGDitx9zaztHVkrmG6Bn2HcB4JBtNd9h3ST7a36SpDXbtV 60Bw== X-Gm-Message-State: AOAM531ydoNJ/RUGGlzmdG3r9bq5QW0NMvo/b63xBarXodIH4bHtd3c8 OQGMR35bbqMlR1IKjSgz6MLv5n5y3EXtSU1c5X0= X-Google-Smtp-Source: ABdhPJxWOKktHrjdsRDp0WA09BgmJ6l8K0xqh1gsnvPjCVOPlmwXnJkqlyzFawVovy1sfIXHdN9K/myGcok8vVVa6lE= X-Received: by 2002:adf:f8d0:: with SMTP id f16mr21591777wrq.66.1597757502703; Tue, 18 Aug 2020 06:31:42 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a5d:614c:0:0:0:0:0 with HTTP; Tue, 18 Aug 2020 06:31:41 -0700 (PDT) In-Reply-To: <45283d79-b061-4c8e-b788-8145b9c694a6@www.fastmail.com> References: <45283d79-b061-4c8e-b788-8145b9c694a6@www.fastmail.com> From: Mateusz Guzik Date: Tue, 18 Aug 2020 15:31:41 +0200 Message-ID: Subject: Re: "panic: malloc(M_WAITOK) in non-sleepable context" when inserting usb stick To: moridin@mm.st Cc: current@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4BWBdr24Wtz43yT X-Spamd-Bar: / X-Spamd-Result: default: False [-0.71 / 15.00]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[current@freebsd.org]; TO_DN_NONE(0.00)[]; NEURAL_SPAM_SHORT(0.29)[0.293]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::441:from]; FREEMAIL_TO(0.00)[mm.st]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[current] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Aug 2020 13:31:46 -0000 Hello, this sould take care of it (in that it will print the warning, but not panic the box): diff --git a/sys/kern/kern_malloc.c b/sys/kern/kern_malloc.c index 46eb1c4347c..7b94ca7b880 100644 --- a/sys/kern/kern_malloc.c +++ b/sys/kern/kern_malloc.c @@ -618,8 +618,8 @@ void * unsigned long osize = size; #endif - KASSERT((flags & M_WAITOK) == 0 || THREAD_CAN_SLEEP(), - ("malloc(M_WAITOK) in non-sleepable context")); + if ((flags & M_WAITOK) != 0) + WITNESS_WARN(WARN_GIANTOK | WARN_SLEEPOK, NULL, __func__); #ifdef MALLOC_DEBUG va = NULL; diff --git a/sys/vm/uma_core.c b/sys/vm/uma_core.c index 37d78354200..2e1267ec02f 100644 --- a/sys/vm/uma_core.c +++ b/sys/vm/uma_core.c @@ -3355,8 +3355,8 @@ uma_zalloc_arg(uma_zone_t zone, void *udata, int flags) uma_cache_bucket_t bucket; uma_cache_t cache; - KASSERT((flags & M_WAITOK) == 0 || THREAD_CAN_SLEEP(), - ("uma_zalloc(M_WAITOK) in non-sleepable context")); + if ((flags & M_WAITOK) != 0) + WITNESS_WARN(WARN_GIANTOK | WARN_SLEEPOK, NULL, __func__); /* Enable entropy collection for RANDOM_ENABLE_UMA kernel option */ random_harvest_fast_uma(&zone, sizeof(zone), RANDOM_UMA); On 8/17/20, moridin@mm.st wrote: > r364323, previously I think it was just a warning from witness. Happens > both on boot with stick already inserted, and when inserting the stick in > booted system. > > Looks like my swap partition is no longer big enough for dump, translating > from screen: > > umass0 numa-domain 0 on uhub4 > umass0:2:0: Attached to scbus2 > panic: malloc(M_WAITOK) in non-sleepable context > > vpanic() > panic() > malloc() > disk_alloc() > daregister() > cam_periph_alloc() > daasync() > xpt_async_process_dev() > xpt_async_process() > xpt_done_process() > xpt_done_td() > fork_exit() > fork_trampoline() > _______________________________________________ > freebsd-current@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" > -- Mateusz Guzik