From owner-freebsd-ports-bugs@freebsd.org Sat Aug 20 20:06:07 2016 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 88A37BC031C for ; Sat, 20 Aug 2016 20:06:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 77DB1170E for ; Sat, 20 Aug 2016 20:06:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u7KK6767030417 for ; Sat, 20 Aug 2016 20:06:07 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 203204] [NEW PORT] databases/pgmodeler: PostgreSQL Database Modeler Date: Sat, 20 Aug 2016 20:06:07 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: rakuco@FreeBSD.org X-Bugzilla-Status: In Progress X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Aug 2016 20:06:07 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D203204 Raphael Kubo da Costa changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Open |In Progress --- Comment #8 from Raphael Kubo da Costa --- Hi there, Sorry for the absence. I've finally taken a look at the latest patch (0.8.2) and only have some comments with things that should be improved before land= ing: - You don't need both USES=3Dqmake and USE_QT5=3Dqmake_build; USES=3Dqmake = is enough. - GH_ACCOUNT=3Dpgmodeler is redundant; the ports framework uses ${PORTNAME}= by default. - You should just use "lib" instead of the occurrences of "%%QT_LIBDIR%%" in pkg-plist. The latter should be used only by the Qt ports themselves in general. Thanks for the work; again, I apologize for taking so long to review the pa= tch, at least we're really close now! --=20 You are receiving this mail because: You are the assignee for the bug.=