From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Oct 8 11:10:30 2006 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B875F16A403 for ; Sun, 8 Oct 2006 11:10:30 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7733243D67 for ; Sun, 8 Oct 2006 11:10:22 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k98BAM0J006434 for ; Sun, 8 Oct 2006 11:10:22 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k98BAMQR006433; Sun, 8 Oct 2006 11:10:22 GMT (envelope-from gnats) Resent-Date: Sun, 8 Oct 2006 11:10:22 GMT Resent-Message-Id: <200610081110.k98BAMQR006433@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Roland Smith Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C257C16A40F for ; Sun, 8 Oct 2006 11:02:12 +0000 (UTC) (envelope-from rsmith@xs4all.nl) Received: from smtp-vbr14.xs4all.nl (smtp-vbr14.xs4all.nl [194.109.24.34]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3915243D55 for ; Sun, 8 Oct 2006 11:02:12 +0000 (GMT) (envelope-from rsmith@xs4all.nl) Received: from slackbox.xs4all.nl (slackbox.xs4all.nl [213.84.242.160]) by smtp-vbr14.xs4all.nl (8.13.8/8.13.8) with ESMTP id k98B2A7j020472 for ; Sun, 8 Oct 2006 13:02:11 +0200 (CEST) (envelope-from rsmith@xs4all.nl) Received: by slackbox.xs4all.nl (Postfix, from userid 1001) id 44446B845; Sun, 8 Oct 2006 13:02:10 +0200 (CEST) Message-Id: <20061008110210.44446B845@slackbox.xs4all.nl> Date: Sun, 8 Oct 2006 13:02:10 +0200 (CEST) From: Roland Smith To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/104155: [PATCH] enable optional FLAC support for multimedia/audacious X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Roland Smith List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Oct 2006 11:10:30 -0000 >Number: 104155 >Category: ports >Synopsis: [PATCH] enable optional FLAC support for multimedia/audacious >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sun Oct 08 11:10:21 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Roland Smith >Release: FreeBSD 6.1-STABLE amd64 >Organization: >Environment: System: FreeBSD slackbox.xs4all.nl 6.1-STABLE FreeBSD 6.1-STABLE #0: Sat Sep 9 14:46:57 CEST 2006 rsmith@slackbox.xs4all.nl:/usr/obj/usr/src/sys/RFS amd64 >Description: FLAC support in multimedia/audacious is currently disabled. >How-To-Repeat: cd /usr/ports/multimedia/audacious; make config install clean >Fix: Apply the following patches to the port Makefile and plist. They make FLAC an optional dependency. Note that this also fixes a typo in CONFIGURE_ARGS; '--disable-flc' should be '--disable-flac', according to the configure script for audacious. ---------- Makefile patch ---------- --- Makefile.orig Sun Oct 8 12:24:06 2006 +++ Makefile Sun Oct 8 12:40:06 2006 @@ -32,8 +32,8 @@ INPUT_PLUGINS="${INPUT_PLUGINS}" \ OUTPUT_PLUGINS="${OUTPUT_PLUGINS}" \ VISUALIZATION_PLUGINS="${VISUALIZATION_PLUGINS}" -CONFIGURE_ARGS= --disable-jack --disable-flc --disable-adplug \ - --disable-lirc --disable-alsa --disable-amidiplug --disable-arts --disable-wma +CONFIGURE_ARGS= --disable-jack --disable-adplug --disable-lirc \ +--disable-alsa --disable-amidiplug --disable-arts --disable-wma MAN1= audacious.1 @@ -46,6 +46,7 @@ OPTIONS= VORBIS "Enable Ogg Vorbis input" on \ MODPLUG "Enable modplug input" off \ + FLAC "Enable FLAC input" off \ SID "Enable sid input" off \ MPC "Enable mpc input" off \ ESOUND "Enable Esound output" off \ @@ -74,6 +75,15 @@ .else PLIST_SUB+= MODPLUG="@comment " CONFIGURE_ARGS+= --disable-modplug +.endif + +.if !defined(WITHOUT_FLAC) +INPUT_PLUGINS+= flac +PLIST_SUB+= FLACPLUGIN="" +LIB_DEPENDS+= FLAC.7:${PORTSDIR}/audio/flac +.else +PLIST_SUB+= FLACPLUGIN="@comment " +CONFIGURE_ARGS+= --disable-flac .endif .if !defined(WITHOUT_SID) ---------- Makefile patch ---------- ---------- pkg-plist patch ---------- --- pkg-plist.orig Sun Oct 8 12:36:20 2006 +++ pkg-plist Sun Oct 8 12:37:44 2006 @@ -29,6 +29,7 @@ lib/audacious/Input/libtimidity.so %%VORBISPLUGIN%%lib/audacious/Input/libvorbis.so %%MODPLUG%%lib/audacious/Input/libmodplug.so +%%FLACPLUGIN%%lib/audacious/Input/libflac.so %%MPCPLUGIN%%lib/audacious/Input/libmpc.so %%SIDPLUGIN%%lib/audacious/Input/libsid.so lib/audacious/Input/libwav.so ---------- pkg-plist patch ---------- >Release-Note: >Audit-Trail: >Unformatted: