From owner-svn-src-all@freebsd.org Thu Jun 9 02:21:39 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8BF2EB6E572 for ; Thu, 9 Jun 2016 02:21:39 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x234.google.com (mail-io0-x234.google.com [IPv6:2607:f8b0:4001:c06::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5F63511A7 for ; Thu, 9 Jun 2016 02:21:39 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x234.google.com with SMTP id m62so26244055iof.0 for ; Wed, 08 Jun 2016 19:21:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=dWC3m1rDQo2/NcPjwHWuTCK3Xcp4kUx1gBoQD1sLZpI=; b=Taf55WRKnp95gTaZSTMKpybqNhxCgzm6pTpsEf931etxMyt3iJ13GtbmzrTE86nAr+ iEe3zGcNUOzq/IxX6RN3oYjjcBf1h7NBClqwRsy4TWbPi8CW1dEykvx4gSouRiRA/SM/ AoIfIEjJEHN0bnNvcb6iwUysv+TsdclTlsML4J7g9bya+Wkd1puz1lNKEnoGbCUH1L/a eE9ExFYZgtlpdhf+YhCATY58qCDzzPKeSQEehoAG/puvazScQrD3PV76cE9yQDoQct5h 1oJh51uHPvVWnTC/A9xOCifBxBzxzU4iP1dZ2ikApK2IHXjj74Eymi4j5Wo1U+5s/8RH AWfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=dWC3m1rDQo2/NcPjwHWuTCK3Xcp4kUx1gBoQD1sLZpI=; b=f1nH6R2L6phNdCcuv8doxb0ZW2bZt3IzakJNd0CGND4nrPV9bO+F8TKmL9QqCEecRe oRbDq9BUhznbZsot3Bs9KolGGws14QJfTz1VQVZFSKHsyoIAGu3Ioh0qDxoJKlUHSqO3 v+IqGaBk56bB5ulXl/ctwnHeZVPRy90gAN+3iDbpaLk+lp1Jde+OnBb54Z63WAi5DL5I 8WZdFFDiMSwOwC43cMEqq9q0WPBawzsj1tf/OesdpYfN2uLkFMnd41pCstMcSlMDT3b7 G8lnpPQgXnkP6QaesQIiGlJQ49G1crz2OWk9H0MuisW1mMkWKmRaHW2M1NDMQcNLvcFp Zc2g== X-Gm-Message-State: ALyK8tJkfZgllHs83afnnFnd/vFVuiM+k5WHHxC1vDItnXTD1/mvgiFY5BlJfRfwi3VCWg== X-Received: by 10.107.140.6 with SMTP id o6mr8539838iod.42.1465438898561; Wed, 08 Jun 2016 19:21:38 -0700 (PDT) Received: from [172.17.66.143] (69-165-177-132.dsl.teksavvy.com. [69.165.177.132]) by smtp.gmail.com with ESMTPSA id b71sm2151465itd.14.2016.06.08.19.21.37 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 08 Jun 2016 19:21:37 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: svn commit: r301714 - head/sys/boot/efi/libefi From: Warner Losh In-Reply-To: <201606090202.u5922pwl024436@repo.freebsd.org> Date: Wed, 8 Jun 2016 22:21:36 -0400 Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <90D3441D-D130-4D00-A12D-F4D3B81E606B@bsdimp.com> References: <201606090202.u5922pwl024436@repo.freebsd.org> To: Emmanuel Vadot X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jun 2016 02:21:39 -0000 > On Jun 8, 2016, at 10:02 PM, Emmanuel Vadot wrote: >=20 > Author: manu > Date: Thu Jun 9 02:02:50 2016 > New Revision: 301714 > URL: https://svnweb.freebsd.org/changeset/base/301714 >=20 > Log: > Print a message when the efi disk isn't a logical partition. Why on earth would you do that? This will print a message, one per full = disk, and our systems have 36 disks in them=E2=80=A6 Please consider backing this out... Warner > Approved by: andrew (mentor) > Differential Revision: https://reviews.freebsd.org/D6782 >=20 > Modified: > head/sys/boot/efi/libefi/efipart.c >=20 > Modified: head/sys/boot/efi/libefi/efipart.c > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- head/sys/boot/efi/libefi/efipart.c Thu Jun 9 01:50:43 2016 = (r301713) > +++ head/sys/boot/efi/libefi/efipart.c Thu Jun 9 02:02:50 2016 = (r301714) > @@ -119,8 +119,11 @@ efipart_init(void)=20 > (void**)&blkio); > if (EFI_ERROR(status)) > continue; > - if (!blkio->Media->LogicalPartition) > + if (!blkio->Media->LogicalPartition) { > + printf("%s%d isn't a logical partition, = skipping\n", > + efipart_dev.dv_name, n); > continue; > + } >=20 > /* > * If we come across a logical partition of subtype = CDROM >=20