From owner-cvs-all  Mon Jan  4 22:33:04 1999
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id WAA06605
          for cvs-all-outgoing; Mon, 4 Jan 1999 22:33:04 -0800 (PST)
          (envelope-from owner-cvs-all@FreeBSD.ORG)
Received: from mail.sat.t.u-tokyo.ac.jp (dryad.sat.t.u-tokyo.ac.jp [133.11.156.10])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id WAA06599;
          Mon, 4 Jan 1999 22:32:58 -0800 (PST)
          (envelope-from simokawa@sat.t.u-tokyo.ac.jp)
Received: from ett.sat.t.u-tokyo.ac.jp (ett.sat.t.u-tokyo.ac.jp [133.11.156.43])
	by mail.sat.t.u-tokyo.ac.jp (8.8.6/3.4Wbeta6-SAT1.0) with ESMTP id PAA01704;
	Tue, 5 Jan 1999 15:32:32 +0900 (JST)
	(envelope-from simokawa@sat.t.u-tokyo.ac.jp)
Received: from localhost by ett.sat.t.u-tokyo.ac.jp (8.8.8/sat-V0.6)
	id PAA22025; Tue, 5 Jan 1999 15:32:31 +0900 (JST)
To: kkennawa@physics.adelaide.edu.au
Cc: simokawa@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG,
        ports@FreeBSD.ORG
Subject: Re: cvs commit: ports/graphics/giftrans Makefile ports/graphics/mpeg2codec/patches
         patch-aa ports/graphics/splitmpg/patches patch-aa        
 ports/graphics/xdl/patches patch-aa
In-Reply-To: Your message of "Tue, 5 Jan 1999 16:38:05 +1030 (CST)"
	<Pine.OSF.4.05.9901051634230.21257-100000@bragg>
References: <Pine.OSF.4.05.9901051634230.21257-100000@bragg>
X-Face: OE([KxWyJI0r[R~S/>7ia}SJ)i%a,$-9%7{*yihQk|]gl}2p#"oXmX/fT}Bn7:#j7i14gu$
 jgR\S*&C3R/pJX<mI-4Z8'mqt1R'CjWdw-xqVoilv`\JgZcquM5oVuO^<vt/~051rCDM(`{rM~?{Ok
 r,XC+}Ycm9IJO)odT*-0nyJjBJYzL{GsZ
X-Mailer: Mew version 1.93 on XEmacs 21.0 (Poitou)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-Id: <19990105153230K.simokawa@sat.t.u-tokyo.ac.jp>
Date: Tue, 05 Jan 1999 15:32:30 +0900
From: Hidetoshi Shimokawa <simokawa@sat.t.u-tokyo.ac.jp>
X-Dispatcher: imput version 980905(IM100)
Lines: 41
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk

kkennawa> --- ports/graphics/mpeg2codec/patches/patch-aa  1996/12/09 15:37:24     1.2
kkennawa> +++ /home/ncvs/ports/graphics/mpeg2codec/patches/patch-aa       1999/01/05
kkennawa> 06:00:09     1.3
kkennawa> @@ -33,9 +33,8 @@
kkennawa>   # GNU gcc
kkennawa>   #
kkennawa>  -CC = gcc
kkennawa> --CFLAGS = -O2
kkennawa>  +CC = cc
kkennawa> -+CFLAGS = -O2 -m486
kkennawa> + CFLAGS = -O2
kkennawa>   
kkennawa>   all: mpeg2decode mpeg2encode
kkennawa>   
kkennawa> Erm, wouldn't it be better to just do
kkennawa> CFLAGS ?= -O2
kkennawa> CFLAGS += <anything else the port needs>

Yes, it should be better.

There are many broken ports on alpha. For "m486" option problem,
I just edit patch files directly and check whether it can be built.

Because I cannot do running test for all ports, I would like to
keep changes as small as possible to avoid breaking working ports.

I'd like to leave these kind of fix to the maintainer or someone who
can check carefully.

kkennawa> like I suggested on freebsd-ports when the PR was opened? Alpha people
kkennawa> presumably wouldn't have CFLAGS=-m486 defined, so this works for them as well
kkennawa> as anyone else who wants to use different optimization switches than the port
kkennawa> was written with.

I agree with your idea.

/\ Hidetoshi Shimokawa
\/  simokawa@sat.t.u-tokyo.ac.jp
PGP public key: finger -l simokawa@sat.t.u-tokyo.ac.jp



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message