From owner-svn-src-all@freebsd.org Sun Nov 5 13:03:57 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 64559E6B793; Sun, 5 Nov 2017 13:03:57 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id EE7907F176; Sun, 5 Nov 2017 13:03:56 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id vA5D3oo7093357 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sun, 5 Nov 2017 15:03:50 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua vA5D3oo7093357 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id vA5D3n8l093356; Sun, 5 Nov 2017 15:03:49 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sun, 5 Nov 2017 15:03:49 +0200 From: Konstantin Belousov To: Bruce Evans Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r324853 - in head/sys: kern sys Message-ID: <20171105130349.GZ2566@kib.kiev.ua> References: <201710220811.v9M8Bjw5033551@repo.freebsd.org> <20171105014453.L1354@besplex.bde.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171105014453.L1354@besplex.bde.org> User-Agent: Mutt/1.9.1 (2017-09-22) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Nov 2017 13:03:57 -0000 On Sun, Nov 05, 2017 at 03:06:22AM +1100, Bruce Evans wrote: > On Sun, 22 Oct 2017, Konstantin Belousov wrote: > > > Author: kib > > Date: Sun Oct 22 08:11:45 2017 > > New Revision: 324853 > > URL: https://svnweb.freebsd.org/changeset/base/324853 > > > > Log: > > Remove the support for mknod(S_IFMT), which created dummy vnodes with > > VBAD type. > > > > FFS ffs_write() VOP catches such vnodes and panics, other VOPs do not > > check for the type and their behaviour is really undefined. The > > comment claims that this support was done for 'badsect' to flag bad > > sectors, we do not have such facility in kernel anyway. > > badsect(8) is a utility and this commit breaks it by removing its kernel > support. I see, thank you for the pointer. I will prepare the patch to remove badsect(8).