From owner-cvs-usrsbin Tue Jul 29 07:57:34 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.5/8.8.5) id HAA18922 for cvs-usrsbin-outgoing; Tue, 29 Jul 1997 07:57:34 -0700 (PDT) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id HAA18895; Tue, 29 Jul 1997 07:57:28 -0700 (PDT) Received: (from bde@localhost) by godzilla.zeta.org.au (8.8.5/8.6.9) id AAA05890; Wed, 30 Jul 1997 00:52:25 +1000 Date: Wed, 30 Jul 1997 00:52:25 +1000 From: Bruce Evans Message-Id: <199707291452.AAA05890@godzilla.zeta.org.au> To: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-usrsbin@FreeBSD.ORG, imp@FreeBSD.ORG Subject: Re: cvs commit: src/usr.sbin/lpr/common_source common.c displayq.c rmjob.c startdaemon.c src/usr.sbin/lpr/lpc cmds.c src/usr.sbin/lpr/lpd printjob.c recvjob.c src/usr.sbin/lpr/lpr lpr.c Sender: owner-cvs-usrsbin@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk > common.c: > OpenBSD 1.7: mickey: #if __STDC__ --> #ifdef __STDC__ > ... `#if __STDC__' was correct. `if __STDC__ == 1' would have been more correct. If __STDC__ is defined as anything other than 1, then nonstandardness is guaranteed. `#ifdef __STDC__' works too. However, in /usr/src, there are 864 instancs of `#if __STDC__' and 1004 instances of '#ifdef __STDC__', not to mention 73 instances of '#if defined(__STDC__)' and 48 instances of '#if defined (__STDC__)'. Do you really wish to change them all? (y or n) :-). Most of the ifdefs are from Sun and Gnu. Bruce